From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0602C48BC4 for ; Tue, 20 Feb 2024 03:34:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70EF16B007B; Mon, 19 Feb 2024 22:34:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BEDF6B0081; Mon, 19 Feb 2024 22:34:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 586836B0082; Mon, 19 Feb 2024 22:34:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4AA0E6B007B for ; Mon, 19 Feb 2024 22:34:11 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0C452A0554 for ; Tue, 20 Feb 2024 03:34:11 +0000 (UTC) X-FDA: 81810763902.15.FE9C006 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf28.hostedemail.com (Postfix) with ESMTP id E149CC0004 for ; Tue, 20 Feb 2024 03:34:08 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Cd6QO36K; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of aneesh.kumar@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=aneesh.kumar@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708400049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KwFS8YeLSmOOQ52WyR1FAtDGoDsHb0EiitsziK0Sglw=; b=SyEeMXNfjG386kqC+mOGn8Y7Gv9Ay/IU7skzniYq1a3SvjM7YYUvra3M/Kf2TtTZx17Ryi WWjnMwrzKQKeqRKn+c0bLMuDb9u3eJ52o69c8ZHDLr0Vt8aiiBC2384Uy+muf8eE4UxYZm mafJ19S+auNLtdejIWDIxA9J4MbVgoY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Cd6QO36K; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of aneesh.kumar@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=aneesh.kumar@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708400049; a=rsa-sha256; cv=none; b=ow1qVXaddcUWldAF0Qvc/znos+WDYBEh0uU+/qPHou9QQBBWrzT+1fMrRIAbTCMI7yzm+s jZIXHolvhrKvvKhWOhXOwgc4LuozzR/yP5+UlgMSD65zyHu+Qv/SScZVsRnwILQF8G9yUZ 8iWoSS5UaNCHMmcOVtk+qrwLbncLcBA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1676ACE1720; Tue, 20 Feb 2024 03:34:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5D91C433F1; Tue, 20 Feb 2024 03:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708400045; bh=QTizz13ocUNCbUJS+bH8ogvkXd3AY/hRCYf1inxvxLg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Cd6QO36KOPleyqZk7LlnDGFB3pHTDha34Md4nD3q+khCtUNV0TSzvNmWbfmODDUnF OuaCdEE/whvUsSsYdM9883uPJkgKNY3BiU5GtUpSBcY0JjFX9ZNOu1Wt6XmF7vKGx8 QrBCjEQNislU2mszCZTQv1j6pMwI0dp6YKhwoO4xpTfvLzFEAGOYAztPam8t9k/2rr U/VP5tCmnzKDOqJrlwCpSc4AcT2f/c1H3MdhCV1qYZs2HWe52+UIh1JKCjjccGe7z8 VLWlAEWMpxn6X788BQl+YnLaaoRqSs/twiMeXTQ4+QZQXDlv/u3LhBJydFXm7Y5vRz F/4FPXJqjKm+Q== Message-ID: <1579f759-8106-4f2b-ba8f-93c10fdf36ad@kernel.org> Date: Tue, 20 Feb 2024 09:03:59 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/debug_vm_pgtable: Fix BUG_ON with pud advanced test To: Andrew Morton Cc: Anshuman Khandual , linux-mm@kvack.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org References: <20240129060022.68044-1-aneesh.kumar@kernel.org> <1b3c1513-826d-4908-93c3-212a6f1b2d74@arm.com> <504f70be-deca-4f7f-b28c-d1ec2cf5a348@kernel.org> <105963ed-b489-4b82-973a-9024d74c6e87@kernel.org> <20240219184647.66ca5f8a1a38156b61e43b9c@linux-foundation.org> Content-Language: en-US From: "Aneesh Kumar K.V" In-Reply-To: <20240219184647.66ca5f8a1a38156b61e43b9c@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E149CC0004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: a85m79hytf39uspdjnmgdxrn4eoq3y5c X-HE-Tag: 1708400048-30005 X-HE-Meta: U2FsdGVkX19mMGjz4NAjYBtLoD5sbqclgAreE/bpvp42gpT4gmoqqL9dkkw9sYTzBiZlNYlcX8YB7Y0yGww6jE9SxV5Fl4B8kWrCxrELbmbM9pNBKBZ0Gcs35a+prW9/2g2T4LBJmFRBI2Qexrji/+gS95AXyrVVVNI5VgFNlUGOCubAd0KTt0ct013CfSVIb7QKPb3iXOxOyz0ldIUJc0LtXwaC2Zv21ZpJhwqP8XVVDBRNJ754ONE0JEFJtNyYiPY3ec3pqb+d96LESX9ZdgbxYyTVsHA0XvOQoI5MlnJRG4J2wnDgrkXP/YEROp3Vz/xlDcq734TnQuS4rIbZc2x6A5X87xX1jnJ57zxkIdVc8L71qjav9m2eNyvbFymwNLqz5Ujozk5LcfuvkD3cFflp8o6JQXrNBJnSB2+l9A8kia+UTdsTFaJrqig+ZtbNaJ+sbNMOK2KuWm5e4yEiJm6ONcQmtOEg/BlyeBkQtq0AXZZpOqoQufc7EjVxOO1vYDlhghHx50jffPwRFWDaq6E20ev1b99siwqh7Va7tyYQ0FzFC+YLggNpcyd2V8QjXy/dhTbwEYNiO8wjgahEMynM7B0kNThpwM4FlGtztlAuRKmVco8vuk48aypHNKujhAq4mgn07s31CbXhj8aNlm1fiw7zwu7RN5sgSHCUtJ4qKSeTcGt1x8wpPhVnKU3yRexNW/xEKVPneMmCZ2O3QbgQvFr96w9EPjK7ES6NptSAHo+celYYhXR7uhIDNqYz/qVpg8vI7AZfd5/alSrEceMtyVC82QINvGvirYuBca0ZGinWsADgTvFqJHzprr+9oZObf1E3Xde/v/ToOjtuC2rbKJzmwaUVVB34BR0foqQtEd5wV8b7f++duuhdVdf2rJetIkIp4EFwtpoInBMP2jg0kwTIW7qGNVkDb1cBmVhjO3IJai+HvhDBMIpj/qNVK1DEXG6WdsuE12Rc8l+ 8rvd1TuN nqT9MM4fu4zxl7LHGUdoF97J9M+Yz6V8nW/OzPS9dJXObR6r2NEGEpckge3VT6RK3/bGKH/S0hNdAmztXVhbW0eZH6z0PZQZO0VJiDqOL6Oi01rtanRmjq434MbKV2t+8qMgBn4iwD8EpYFGWNNfMl9gK/oS20BozH1KMh0PCVkHD2lD+0y+aC9Kf/RCLRGLeyJCSLhuAoBsGhMx5x0HZKBLXHE0W172DOKiyTESpGn4qVCt0VjUBapgkg56/EyCcqaL76mAnljMg5Ohw6fTuYJpuS8CHasxx09fZuCBScDeo8qWkdQXjR4MHLlGbsHkk+eUyDYHt3/MhdF4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/20/24 8:16 AM, Andrew Morton wrote: > On Mon, 29 Jan 2024 13:43:39 +0530 "Aneesh Kumar K.V" wrote: > >>> return (pud_val(pud) & (_PAGE_PSE|_PAGE_DEVMAP)) == _PAGE_PSE; >>> } >>> #endif >>> >>> #ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD >>> static inline int pud_devmap(pud_t pud) >>> { >>> return !!(pud_val(pud) & _PAGE_DEVMAP); >>> } >>> #else >>> static inline int pud_devmap(pud_t pud) >>> { >>> return 0; >>> } >>> #endif >>> >>> We might need some more clarity on this regarding x86 platform's pud huge >>> page implementation. >>> >> >> static vm_fault_t create_huge_pud(struct vm_fault *vmf) >> { >> #if defined(CONFIG_TRANSPARENT_HUGEPAGE) && \ >> defined(CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD) >> struct vm_area_struct *vma = vmf->vma; >> /* No support for anonymous transparent PUD pages yet */ >> if (vma_is_anonymous(vma)) >> return VM_FAULT_FALLBACK; >> if (vma->vm_ops->huge_fault) >> return vma->vm_ops->huge_fault(vmf, PUD_ORDER); >> #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ >> return VM_FAULT_FALLBACK; >> } > > cryptic reply, unreplied to. > > What's the thinking here? Should we proceed with the patch as-is, or > are changes needed? > Sorry for the confusion. What i wanted to update with the code was to reiterate that no architectures currently does anonymous pud hugepage. So restricting debug_vm_pgtable pud hugepage test to devmap pte entries should be ok w.r.t these tests. -aneesh