From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1A9DC48BF8 for ; Mon, 19 Feb 2024 22:35:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18F3F6B0071; Mon, 19 Feb 2024 17:35:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 140046B0072; Mon, 19 Feb 2024 17:35:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 006F56B0074; Mon, 19 Feb 2024 17:35:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E6CC36B0071 for ; Mon, 19 Feb 2024 17:35:42 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 934A2A029D for ; Mon, 19 Feb 2024 22:35:42 +0000 (UTC) X-FDA: 81810011724.07.B9B7BE7 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by imf04.hostedemail.com (Postfix) with ESMTP id D463F40004 for ; Mon, 19 Feb 2024 22:35:40 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="ElwHxN/g"; spf=pass (imf04.hostedemail.com: domain of hughd@google.com designates 209.85.128.178 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708382140; a=rsa-sha256; cv=none; b=qa/1hinp3AJR1WCPU+GEu6dpbBYohqeFhs8hbIAo5zsE3TeCM9mUjG1TI6v5FVS6Y2Mk7n 2SOUdhUs1xxxlKKXkC6EKI+4dS2UPBj/o/O3qF8a3R5IxKpTBzIVt3Jsh56RKlcbE4u94m MQtCBqVPo065Q0ibfhdRJhLc615s4LE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="ElwHxN/g"; spf=pass (imf04.hostedemail.com: domain of hughd@google.com designates 209.85.128.178 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708382140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o2LnIFqJqD5R6npETueaLzzFEUVO0eALpRrwN094PGw=; b=e5OXjFyW4WV86MJVubYaQ453t6qLHrm24uUsQr3dh/33j8t6AuJOSG3L0vq4K5kOfGvAt9 hW2o1rMJcy4QIhz7QbYSA7gN39s8O4TDdgacNnBdR7WBQnOI4yfCq8nadIX5UdtaUGT3HX 5ky9KE3frbMFRU1wyrOAMwZL3iELFtQ= Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-6083dc087b3so12950987b3.0 for ; Mon, 19 Feb 2024 14:35:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708382140; x=1708986940; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=o2LnIFqJqD5R6npETueaLzzFEUVO0eALpRrwN094PGw=; b=ElwHxN/gYWe1equ/amIdBzW10tkDEtosL4kDdoTOEH4MYWbW2w00lgpOVEimTMFkgM O+XPYY+f13rwn2PzV/4EzIy2uOVaqtLjSnT7KYRpC/Jx0aEfgUKemNLlRML9UkSnbISa Gfholcu0Z9N47h4Qvrr4IRnM4E8FVeSHBPoDH8yDjGliZgMmUqrYCYA+Tdciii9osey+ nX+8e6gNBQsOoG8Hotg6iyOBG97XXyWwDpU2kZ6dPZ4MJKrBjgS5pHLIGkvzufbsf2Xy +GwLucY2uCRHiC3giHUrvRL/ShpVkRL+NhAk71N4+EYmgvz7u6iQilNXrrlrG0111DWl apYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708382140; x=1708986940; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o2LnIFqJqD5R6npETueaLzzFEUVO0eALpRrwN094PGw=; b=VbTRPvDSXUIpiLosKTcs1IRyHAVETGlXp+MFWZq1fZMuBVThZJsP3jgehBcf2uuFEj EC5OcBofakNAGIeEXTBzRd0//HrawhyA+f6Q29s1+Zf6N2cyDvR717bsCIlhw2u/7un1 2F/o4aJwEvPyEhwRGrolXpqmTZCI50Hx9nM+u/zpy7ggTWo8d2Rm7TMusM+Iwr8PC81+ huAyZFs++hH44RpfCWMnCHqVVenzpmH8YITDCmJ+PTTvIexQebbfmRowt1MFrkE2ohci mFzJulZ7YB6GAeTqeXV38oa/DLhD6NrKaAwlXXIG5c9jMoo6qSDf5q6Cq1tC/i8qSUSi Xg2g== X-Forwarded-Encrypted: i=1; AJvYcCVL5zjp5avNKAwpGOQ3iAoCUZ5vesiJCx9OkMW2viDwkDbVILJ3gSSQvpjNwfYRd3vwzD1Ab0N/PcbVU9UJeVWgT+0= X-Gm-Message-State: AOJu0YxdYxP0tEa1FGF16+7hAy/wxl0hLMEcYVN5PfYypK/50ChRKmrW fd7Aq4Y1Q1oN/iXEBJgZAxV+8fiBtzxLqvncmLZzGinRHByuC8yfSEKDtuiEzw== X-Google-Smtp-Source: AGHT+IF+r1Zamh+n8JrGZUrsW6nzdDOed2DtH1tSqF8a0cHCBBIVpZyEk/XPScFL4t7aufZlh7KSZQ== X-Received: by 2002:a25:848d:0:b0:dc6:be64:cfd1 with SMTP id v13-20020a25848d000000b00dc6be64cfd1mr10817332ybk.36.1708382139813; Mon, 19 Feb 2024 14:35:39 -0800 (PST) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id z33-20020a25ada1000000b00dce0a67ac8bsm1607027ybi.23.2024.02.19.14.35.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 14:35:38 -0800 (PST) Date: Mon, 19 Feb 2024 14:35:25 -0800 (PST) From: Hugh Dickins To: Christoph Hellwig cc: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , Hui Su , Matthew Wilcox , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: put the xfs xfile abstraction on a diet v4 In-Reply-To: <20240219062730.3031391-1-hch@lst.de> Message-ID: <157748fd-18c1-d2ff-8b15-1b218705b355@google.com> References: <20240219062730.3031391-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D463F40004 X-Stat-Signature: 465qwfa3eqecak844ozbqcba5mn9gjao X-Rspam-User: X-HE-Tag: 1708382140-756989 X-HE-Meta: U2FsdGVkX1+iJdAPRaYcXb+A932obQ09svZlvQhx36JerbQ8nEdg93Zi00su17HniUI3i0/on2QhaDN6ylX6BGs9BTm5lj8n/cvMjozXGLWcuNPaBra6kTdAS6g6HpxYu8U9bb6nedqxRkBlhe3g5fe1M+/zxV+9/Nl8tT1voGqlmnviuDUH119smu/g1joKIrtIA5Dfy/kyU3A/YwyHom6YymIeYA4/Zll9GcPfWL+iPTETzgiGEGIC3o2igvsanQGCQwYrQQFWGPWWnwEVGp9KuiX/KiS5PpVC0eWoIefucGoZdDv4WPKKDH9yNmqh/3zHcYoYc+y2pg+47ZXdGLNYfgzxcSJJE4oLbaNNS+FKbFIiBLcGqYsbwlfl97eQySsAIJPLvTpU3J9kmpk3wHKAW7wclygQIKd65vSsO1iplk84hpsnRbS7CGcNqggGY5Vef7F4tPXRQXJQoxwXKa3BQExkhb/9rwk0m8VqoPNDTVX4r2kr7SEgdtOe4lyjPP4yxDHJrWUG5ifNC4eUpNBuRHjJy0OO417LHGfEk1Lag+kd9JCsi1yW8Y497NOcgA+5pF7SmoZgKPIY2feGqFCdYZNzw9ZJlaV+/MlHavQhDYO1V/AWZq7zjdB5i016Qp8A3oHFfcyMqkGCEv0XMPE2VF9YbF5CR9q5fIYmswlwox4QxKrM4PY7+Y8Mgd1afBAxpmhqzXwFM8Q09x7elWjc9FHFxxHSaM11j4rntigfBBAMiChp/4JUuFpJecLBdOcg7gU3fEfwmXvFQ+6vF/U9tMrrabLTbX0J9shPvjg3L3B1IMDp6rQnqaD8lMpe8Y5DTYz85rErhtbM4IgbfIzsdlFUVkUYkRRGK0qUsERwUw1Y1oC95di69emEeGm5LevEKIT8hnIrd7EFafmMirEypPoyInkixY1IDqxBdeka0QlrV0E4rp0pyUCFuu1RzZ76nAf+7za7urKIS3f IEuDNatd tsgznBZalQ7fJ5Ebsj1GpzeNUrvDFyX3amG77p2YIpaD4JehrU5jw15Fcretl4GN8BRxhx4YISFkuL7qIEEvUAzaPv9ExaycdW7yPsU4lq13c/DEzZ5sj7T5d67Dz5Y/kXu1uy1ieIiyn6w/9+QB0h65r65ayiv7Wr/UKoxEksY8AvPskdY26MOmuVEOdN7nW4E3DDIpiJuL14kUOdxkdbdNJp9H3SoTocUAiwu4SRqTJzEXDamlgUVhb+lZ181r9RWJsvuapPuO0FhieqOJ6j04PfOM/FRYBbwkt18JhMKvx6OWAVWuCQ9BpYHH4WKozXDQGrrXGORsDVCM7w2sYyB2asFKMI3BKFyX6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 19 Feb 2024, Christoph Hellwig wrote: > Hi all, > > this series refactors and simplifies the code in the xfs xfile > abstraction, which is a thing layer on a kernel-use shmem file. > > To do this is needs a slighly lower level exports from shmem.c, > which I combined with improving an assert and documentation there. > > As per the previous discussion this should probably be merged through > the xfs tree. > > The series is against current mainline. > > Changes since v3: > - improve the shmem_get_folio documentation > - use VM_NORESERVE > - split and reorder the file setup patches > - improve a commit message Looks good to me (and I was relieved that you resisted Matthew's temptation to rename shmem_get_folio()). Thanks, Hugh