From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC831C432C3 for ; Sat, 16 Nov 2019 03:15:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A74B720700 for ; Sat, 16 Nov 2019 03:15:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A74B720700 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2063A6B0008; Fri, 15 Nov 2019 22:15:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 191636B000A; Fri, 15 Nov 2019 22:15:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A6526B000C; Fri, 15 Nov 2019 22:15:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id E375C6B0008 for ; Fri, 15 Nov 2019 22:15:17 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id B21A3181AEF1E for ; Sat, 16 Nov 2019 03:15:17 +0000 (UTC) X-FDA: 76160674674.13.cats97_110510a1a6a40 X-HE-Tag: cats97_110510a1a6a40 X-Filterd-Recvd-Size: 3162 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Sat, 16 Nov 2019 03:15:15 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R281e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04407;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0TiBsg6Y_1573874109; Received: from localhost(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TiBsg6Y_1573874109) by smtp.aliyun-inc.com(127.0.0.1); Sat, 16 Nov 2019 11:15:09 +0800 From: Alex Shi To: alex.shi@linux.alibaba.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org Cc: Vlastimil Babka , Dan Williams , Michal Hocko , Wei Yang , Johannes Weiner , Arun KS , Rong Chen Subject: [PATCH v3 2/7] mm/lruvec: add irqsave flags into lruvec struct Date: Sat, 16 Nov 2019 11:15:01 +0800 Message-Id: <1573874106-23802-3-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1573874106-23802-1-git-send-email-alex.shi@linux.alibaba.com> References: <1573874106-23802-1-git-send-email-alex.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We need a irqflags vaiable to save state when do irqsave action, declare it here would make code more clear/clean. Rong Chen reported the 'irqflags' variable need move to the tail of lruvec struct otherwise it causes 18% regressions of vm-scalability testing on his machine. So add the flags and lru_lock to both near struct tail, even I have no clue of this perf losing. Originally-from: Hugh Dickins Signed-off-by: Alex Shi Cc: Andrew Morton Cc: Vlastimil Babka Cc: Dan Williams Cc: Michal Hocko Cc: Mel Gorman Cc: Wei Yang Cc: Johannes Weiner Cc: Arun KS Cc: Tejun Heo Cc: Konstantin Khlebnikov CC: Rong Chen Cc: cgroups@vger.kernel.org Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org --- include/linux/mmzone.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index a13b8a602ee5..9b8b8daf4e03 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -269,6 +269,8 @@ struct lruvec { unsigned long flags; /* per lruvec lru_lock for memcg */ spinlock_t lru_lock; + /* flags for irqsave */ + unsigned long irqflags; #ifdef CONFIG_MEMCG struct pglist_data *pgdat; #endif -- 1.8.3.1