From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC7F7C432C3 for ; Fri, 15 Nov 2019 06:36:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 14E7C206D4 for ; Fri, 15 Nov 2019 06:36:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14E7C206D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8B4506B0005; Fri, 15 Nov 2019 01:36:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 864D96B0007; Fri, 15 Nov 2019 01:36:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 753266B026E; Fri, 15 Nov 2019 01:36:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 5DC216B0005 for ; Fri, 15 Nov 2019 01:36:11 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 0D238180AD81D for ; Fri, 15 Nov 2019 06:36:11 +0000 (UTC) X-FDA: 76157552142.02.slave52_7023867e14704 X-HE-Tag: slave52_7023867e14704 X-Filterd-Recvd-Size: 2632 Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Nov 2019 06:36:10 +0000 (UTC) Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id B10AEAB3986D6239ACFC; Fri, 15 Nov 2019 14:36:03 +0800 (CST) Received: from huawei.com (10.175.105.18) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.439.0; Fri, 15 Nov 2019 14:35:53 +0800 From: linmiaohe To: , , , , , , , , , , , CC: , , Subject: [PATCH] mm: get rid of odd jump label in find_mergeable_anon_vma Date: Fri, 15 Nov 2019 14:36:08 +0800 Message-ID: <1573799768-15650-1-git-send-email-linmiaohe@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.105.18] X-CFilter-Loop: Reflected X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Miaohe Lin The odd jump label try_prev and none is not really need in func find_mergeable_anon_vma, eliminate them to improve readability. Signed-off-by: Miaohe Lin --- mm/mmap.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index 4d4db76a07da..ab980d468a10 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -1276,25 +1276,21 @@ static struct anon_vma *reusable_anon_vma(struct vm_area_struct *old, struct vm_ */ struct anon_vma *find_mergeable_anon_vma(struct vm_area_struct *vma) { - struct anon_vma *anon_vma; + struct anon_vma *anon_vma = NULL; struct vm_area_struct *near; near = vma->vm_next; - if (!near) - goto try_prev; - - anon_vma = reusable_anon_vma(near, vma, near); + if (near) + anon_vma = reusable_anon_vma(near, vma, near); if (anon_vma) return anon_vma; -try_prev: - near = vma->vm_prev; - if (!near) - goto none; - anon_vma = reusable_anon_vma(near, near, vma); + near = vma->vm_prev; + if (near) + anon_vma = reusable_anon_vma(near, near, vma); if (anon_vma) return anon_vma; -none: + /* * There's no absolute need to look only at touching neighbours: * we could search further afield for "compatible" anon_vmas. -- 2.19.1