From: linmiaohe <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>, <richardw.yang@linux.intel.com>,
<sfr@canb.auug.org.au>, <rppt@linux.ibm.com>, <jannh@google.com>,
<steve.capper@arm.com>, <catalin.marinas@arm.com>,
<aarcange@redhat.com>, <chenjianhong2@huawei.com>,
<walken@google.com>, <dave.hansen@linux.intel.com>,
<tiny.windzz@gmail.com>
Cc: <linmiaohe@huawei.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] mm: get rid of odd jump label in find_mergeable_anon_vma
Date: Fri, 15 Nov 2019 14:36:08 +0800 [thread overview]
Message-ID: <1573799768-15650-1-git-send-email-linmiaohe@huawei.com> (raw)
From: Miaohe Lin <linmiaohe@huawei.com>
The odd jump label try_prev and none is not really need
in func find_mergeable_anon_vma, eliminate them to
improve readability.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/mmap.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index 4d4db76a07da..ab980d468a10 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -1276,25 +1276,21 @@ static struct anon_vma *reusable_anon_vma(struct vm_area_struct *old, struct vm_
*/
struct anon_vma *find_mergeable_anon_vma(struct vm_area_struct *vma)
{
- struct anon_vma *anon_vma;
+ struct anon_vma *anon_vma = NULL;
struct vm_area_struct *near;
near = vma->vm_next;
- if (!near)
- goto try_prev;
-
- anon_vma = reusable_anon_vma(near, vma, near);
+ if (near)
+ anon_vma = reusable_anon_vma(near, vma, near);
if (anon_vma)
return anon_vma;
-try_prev:
- near = vma->vm_prev;
- if (!near)
- goto none;
- anon_vma = reusable_anon_vma(near, near, vma);
+ near = vma->vm_prev;
+ if (near)
+ anon_vma = reusable_anon_vma(near, near, vma);
if (anon_vma)
return anon_vma;
-none:
+
/*
* There's no absolute need to look only at touching neighbours:
* we could search further afield for "compatible" anon_vmas.
--
2.19.1
next reply other threads:[~2019-11-15 6:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 6:36 linmiaohe [this message]
2019-11-15 11:49 ` Qian Cai
2019-11-15 12:58 ` David Hildenbrand
2019-11-15 23:38 ` John Hubbard
2019-11-16 0:37 ` Wei Yang
2019-11-18 3:14 linmiaohe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573799768-15650-1-git-send-email-linmiaohe@huawei.com \
--to=linmiaohe@huawei.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=chenjianhong2@huawei.com \
--cc=dave.hansen@linux.intel.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richardw.yang@linux.intel.com \
--cc=rppt@linux.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=steve.capper@arm.com \
--cc=tiny.windzz@gmail.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox