linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Alex Shi <alex.shi@linux.alibaba.com>
To: alex.shi@linux.alibaba.com, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	akpm@linux-foundation.org, mgorman@techsingularity.net,
	tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru,
	daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com
Subject: [PATCH v2 0/8] per lruvec lru_lock for memcg
Date: Tue, 12 Nov 2019 22:06:20 +0800	[thread overview]
Message-ID: <1573567588-47048-1-git-send-email-alex.shi@linux.alibaba.com> (raw)

Hi all,

This patchset move lru_lock into lruvec, give a lru_lock for each of
lruvec, thus bring a lru_lock for each of memcg per node.

According to Daniel Jordan's suggestion, I run 64 'dd' with on 32
containers on my 2s* 8 core * HT box with the modefied case:
  https://git.kernel.org/pub/scm/linux/kernel/git/wfg/vm-scalability.git/tree/case-lru-file-readtwice

With this change above lru_lock censitive testing improved 17% with multiple
containers scenario. And no performance lose w/o mem_cgroup.

Thanks Hugh Dickins and Konstantin Khlebnikov, they both bring the same idea
7 years ago. I don't know why they didn't go further, but according to my 
testing, and google internal usage. This feathre is clearly benefit
multi-container user.

So I like to introduce it here.

v2: bypass a performance regression bug and fix some function issues

---
 Documentation/admin-guide/cgroup-v1/memcg_test.rst | 15 +++------------
 Documentation/admin-guide/cgroup-v1/memory.rst     |  6 +++---
 Documentation/trace/events-kmem.rst                |  2 +-
 Documentation/vm/unevictable-lru.rst               | 22 ++++++++--------------
 include/linux/memcontrol.h                         | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 include/linux/mm_types.h                           |  2 +-
 include/linux/mmzone.h                             |  7 +++++--
 mm/compaction.c                                    | 62 ++++++++++++++++++++++++++++++++++++++++++--------------------
 mm/filemap.c                                       |  4 ++--
 mm/huge_memory.c                                   | 16 ++++++----------
 mm/memcontrol.c                                    | 64 +++++++++++++++++++++++++++++++++++++++++++++++++++-------------
 mm/mlock.c                                         | 27 ++++++++++++++-------------
 mm/mmzone.c                                        |  1 +
 mm/page_alloc.c                                    |  1 -
 mm/page_idle.c                                     |  5 +++--
 mm/rmap.c                                          |  2 +-
 mm/swap.c                                          | 77 +++++++++++++++++++++++++++++++----------------------------------------------
 mm/vmscan.c                                        | 74 ++++++++++++++++++++++++++++++++++++++------------------------------------
 18 files changed, 277 insertions(+), 177 deletions(-)


[PATCH v2 1/8] mm/lru: add per lruvec lock for memcg
[PATCH v2 2/8] mm/lruvec: add irqsave flags into lruvec struct
[PATCH v2 3/8] mm/lru: replace pgdat lru_lock with lruvec lock
[PATCH v2 4/8] mm/lru: only change the lru_lock iff page's lruvec is
[PATCH v2 5/8] mm/pgdat: remove pgdat lru_lock
[PATCH v2 6/8] mm/lru: remove rcu_read_lock to fix performance
[PATCH v2 7/8] mm/lru: likely enhancement
[PATCH v2 8/8] mm/lru: revise the comments of lru_lock


             reply	other threads:[~2019-11-12 14:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12 14:06 Alex Shi [this message]
2019-11-12 14:06 ` [PATCH v2 1/8] mm/lru: add per lruvec lock " Alex Shi
2019-11-12 14:06 ` [PATCH v2 2/8] mm/lruvec: add irqsave flags into lruvec struct Alex Shi
2019-11-12 14:06 ` [PATCH v2 3/8] mm/lru: replace pgdat lru_lock with lruvec lock Alex Shi
2019-11-12 14:06 ` [PATCH v2 4/8] mm/lru: only change the lru_lock iff page's lruvec is different Alex Shi
2019-11-12 14:36   ` Matthew Wilcox
2019-11-13  2:26     ` Alex Shi
2019-11-13 13:45       ` Matthew Wilcox
2019-11-14  6:01         ` Alex Shi
2019-11-12 14:06 ` [PATCH v2 5/8] mm/pgdat: remove pgdat lru_lock Alex Shi
2019-11-12 14:06 ` [PATCH v2 6/8] mm/lru: remove rcu_read_lock to fix performance regression Alex Shi
2019-11-12 14:38   ` Matthew Wilcox
2019-11-13  2:40     ` Alex Shi
2019-11-13 11:40       ` Mel Gorman
2019-11-14  6:02         ` Alex Shi
2019-11-12 14:06 ` [PATCH v2 7/8] mm/lru: likely enhancement Alex Shi
2019-11-12 14:06 ` [PATCH v2 8/8] mm/lru: revise the comments of lru_lock Alex Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1573567588-47048-1-git-send-email-alex.shi@linux.alibaba.com \
    --to=alex.shi@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=daniel.m.jordan@oracle.com \
    --cc=hughd@google.com \
    --cc=khlebnikov@yandex-team.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=tj@kernel.org \
    --cc=yang.shi@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox