From: Qian Cai <cai@lca.pw>
To: akpm@linux-foundation.org
Cc: steven.price@arm.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Qian Cai <cai@lca.pw>
Subject: [PATCH -next] mm/ptdump: fix a -Wold-style-declaration warning
Date: Mon, 4 Nov 2019 14:23:05 -0500 [thread overview]
Message-ID: <1572895385-29194-1-git-send-email-cai@lca.pw> (raw)
The -next commit "mm: add generic ptdump" [1] introduced a GCC
compilation warning,
mm/ptdump.c:123:1: warning: 'static' is not at beginning of declaration
[-Wold-style-declaration]
const static struct mm_walk_ops ptdump_ops = {
^~~~~
[1] http://lkml.kernel.org/r/20191028135910.33253-20-steven.price@arm.com
Signed-off-by: Qian Cai <cai@lca.pw>
---
mm/ptdump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/ptdump.c b/mm/ptdump.c
index 5d349311e77e..a30ea0cf6c5f 100644
--- a/mm/ptdump.c
+++ b/mm/ptdump.c
@@ -120,7 +120,7 @@ static int ptdump_hole(unsigned long addr, unsigned long next,
return 0;
}
-const static struct mm_walk_ops ptdump_ops = {
+static const struct mm_walk_ops ptdump_ops = {
.pgd_entry = ptdump_pgd_entry,
.p4d_entry = ptdump_p4d_entry,
.pud_entry = ptdump_pud_entry,
--
1.8.3.1
reply other threads:[~2019-11-04 19:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1572895385-29194-1-git-send-email-cai@lca.pw \
--to=cai@lca.pw \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox