From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27170CA9EC7 for ; Wed, 30 Oct 2019 18:34:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DEBED208C0 for ; Wed, 30 Oct 2019 18:34:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="RTBhB+dV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEBED208C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7745C6B0005; Wed, 30 Oct 2019 14:34:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7268D6B0007; Wed, 30 Oct 2019 14:34:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63AB06B0008; Wed, 30 Oct 2019 14:34:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 428FA6B0005 for ; Wed, 30 Oct 2019 14:34:44 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 97DC38249980 for ; Wed, 30 Oct 2019 18:34:43 +0000 (UTC) X-FDA: 76101302046.07.mass63_464ef769e3928 X-HE-Tag: mass63_464ef769e3928 X-Filterd-Recvd-Size: 5041 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Wed, 30 Oct 2019 18:34:43 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id o3so4608212qtj.8 for ; Wed, 30 Oct 2019 11:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=OsDBDDNNwNVk1HpNMJ12vRi0lwWKIJwrDacqqrUqTjQ=; b=RTBhB+dV2WzXWBhflaJmPXdXqu2W7uM17qg7vysJH/Ru6ZlnTK7SAIH2Q4txGecZw3 4uCSmn8xgzmUEREam6ZaE0gUGshvY6fb6uuj4RACu213oXWsraskau9I+VYaqhRdJBqb RbeuSog1yEqNie2TCj2Q4Gqn9pyVNnNMridzUN+CDvSSqUh829shisSd5XMadmJ1yKeW UosRRZ6GJkr6hK/tkCdch2PgHrEdf823q3DtKhUMTiFV2EDduyvyZCT4ETPRU1xlYe48 Zyc55GYN6jU9mC6AgJqXRqipoc1jDTQXp5dJZno8tzjhE4qJkgPg7I2FshsrTBMq5+r0 0qxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=OsDBDDNNwNVk1HpNMJ12vRi0lwWKIJwrDacqqrUqTjQ=; b=BARtFlZO1dXT0T3PemjNer75Y1ru9pxEi8PcDG2O35HZ24Q0x26u0yzKqibDzdYNr0 vDlcBiN9zLIneRqTChiV85HwRM94iQfN201WpFBclFFxkzoRM4y+traHVTaKsv1gih0/ xfRBNomjezflFm6KsHC79S6HzFJKFSHJROH1copW/LEV+az8GMoOcCWRmsvNkF8oF1om pUzlqvolq0KlvmWI/dVNfOLO7/oZno6QwzpFxQDYLXY1lnYGdhzu0HVQ8i+hLpUzVCC9 Ul4TYSUChK6Ml8LE1RAK/b4JmfhLxK3fM/EXIzzFGa8JssTrJNkPeOVmJ/7zQ+OB1fdS pQHA== X-Gm-Message-State: APjAAAUt0Dk5hFebK6Ue0sypnWX9WFd71i54gGf3dYKF2CbRmzdURnHq E49ACYX/K3lRfyPLIZd43rK5qQ== X-Google-Smtp-Source: APXvYqyjmgurV53BEYc4MsqVwfjA+33pu7DYugrs7ywxGjX6h1LZ+4/W7RrbokAPumRx5hYqHyiAvA== X-Received: by 2002:ac8:1194:: with SMTP id d20mr1554203qtj.275.1572460482169; Wed, 30 Oct 2019 11:34:42 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id q8sm758906qta.31.2019.10.30.11.34.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Oct 2019 11:34:41 -0700 (PDT) Message-ID: <1572460479.5937.102.camel@lca.pw> Subject: Re: [PATCH v3 3/3] mm/hmm/test: add self tests for HMM From: Qian Cai To: Jason Gunthorpe , Ralph Campbell Cc: Jerome Glisse , John Hubbard , Christoph Hellwig , "linux-rdma@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Date: Wed, 30 Oct 2019 14:34:39 -0400 In-Reply-To: <20191029175837.GS22766@mellanox.com> References: <20191023195515.13168-1-rcampbell@nvidia.com> <20191023195515.13168-4-rcampbell@nvidia.com> <20191029175837.GS22766@mellanox.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2019-10-29 at 17:58 +0000, Jason Gunthorpe wrote: > On Wed, Oct 23, 2019 at 12:55:15PM -0700, Ralph Campbell wrote: > > Add self tests for HMM. > > > > Signed-off-by: Ralph Campbell > > --- > > MAINTAINERS | 3 + > > drivers/char/Kconfig | 11 + > > drivers/char/Makefile | 1 + > > drivers/char/hmm_dmirror.c | 1566 ++++++++++++++++++++++++ > > include/Kbuild | 1 + > > include/uapi/linux/hmm_dmirror.h | 74 ++ > > tools/testing/selftests/vm/.gitignore | 1 + > > tools/testing/selftests/vm/Makefile | 3 + > > tools/testing/selftests/vm/config | 3 + > > tools/testing/selftests/vm/hmm-tests.c | 1311 ++++++++++++++++++++ > > tools/testing/selftests/vm/run_vmtests | 16 + > > tools/testing/selftests/vm/test_hmm.sh | 97 ++ > > 12 files changed, 3087 insertions(+) > > create mode 100644 drivers/char/hmm_dmirror.c > > create mode 100644 include/uapi/linux/hmm_dmirror.h > > create mode 100644 tools/testing/selftests/vm/hmm-tests.c > > create mode 100755 tools/testing/selftests/vm/test_hmm.sh > > This is really big, it would be nice to get a comment from the various > kernel testing folks if this approach makes sense with the test > frameworks. Do we have other drivers that are only intended to be used > by selftests? > > Frankly, I'm not super excited about the idea of a 'test driver', it > seems more logical for testing to have some way for a test harness to > call hmm_range_fault() under various conditions and check the results? Not a big fan of those selftests either. Could it be saner to use the new KUnit framework for those instead?