From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E40C47404 for ; Wed, 9 Oct 2019 13:43:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 42811218AC for ; Wed, 9 Oct 2019 13:43:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="jEaNuP3r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42811218AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D18948E0005; Wed, 9 Oct 2019 09:43:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA1408E0003; Wed, 9 Oct 2019 09:43:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B90018E0005; Wed, 9 Oct 2019 09:43:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0239.hostedemail.com [216.40.44.239]) by kanga.kvack.org (Postfix) with ESMTP id 90C228E0003 for ; Wed, 9 Oct 2019 09:43:17 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 35A48180AD801 for ; Wed, 9 Oct 2019 13:43:17 +0000 (UTC) X-FDA: 76024362834.09.bag09_56cc708a76105 X-HE-Tag: bag09_56cc708a76105 X-Filterd-Recvd-Size: 5921 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Oct 2019 13:43:16 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id m61so3453337qte.7 for ; Wed, 09 Oct 2019 06:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=GbmW8oMNpcfaVBYTBCBL+jTjm9GV5hpZALa8v3HrwBI=; b=jEaNuP3rdCVFGZxQzP6IhXiwIvWzYOR2BOnjGW/ZS/MZDjw4lhUkTbFwedoTYx7O8s O2oViWttfCcTpn/JPLgmoylmDFj0c3QJtiwW181yaxlV1ZrQCOCiSUe87N4rAIi/2GFS hczkgK9kOA5i24jZ5RqZhw4PEsqR2QQTcnb+17TRWPfgHI2x5RA4i6LkQX5Wr2/dzAKO WLxa7Azghv0uV36wRLw7JBKD5DWWdWbz/wvm73wvc0M73yHflabvhFxKxxnyQP+jmKPC lApfCuu5ddOQyatXSzIyqkDQz/TBf2fjiGSm6mvVzfxgYWg6Y5k7T8TyGT8q5li4Mbyi ebYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=GbmW8oMNpcfaVBYTBCBL+jTjm9GV5hpZALa8v3HrwBI=; b=YgMKamNafdW7T/bJxXqTYCoXYxkX1Foqc7AV+A0nYDv2MT/7hq/wBmVjj+WEJ+ltxh U0rjiMyTAiIxD1AaeaRGbxOlDOS9FO3afedGSCsfZ7jmwucQoz1fcqvknHe5FZyDqAed l+cnm/W493fe88kmzAtlwn+ovDGaaRaHHOdLcnr4xX3QBM76F9szebPSFEGg19fiFpU8 Ge/xv6iN0JSobAE+/SsJO+isspC1uPTuRF6/aCDgJ5q+fJW2IvgOJKiq4/jA15GkqsIc mc6BbBhuoJqG5u1lXQ+/W1EkreUETQ+c+PJxM+nQwWkRJ0ns1n/aVJtH7BE1gdW1IuFD bioA== X-Gm-Message-State: APjAAAXt/QnPhr08VssFwq96mkbuqG7APBVTz4hqk5p2m9hrry0gGYru Fg/9/GduTtSOP3eJ9A0m8UsiOg== X-Google-Smtp-Source: APXvYqwqYbj/zGNpmimC3/YGl2R7OxFdKZ71uQmOs9/bcaIv7w/W7Ed5fVY8a+QSBxB1jax1AN+JWA== X-Received: by 2002:a0c:c10d:: with SMTP id f13mr3745220qvh.88.1570628595720; Wed, 09 Oct 2019 06:43:15 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id o14sm1321995qtk.52.2019.10.09.06.43.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Oct 2019 06:43:15 -0700 (PDT) Message-ID: <1570628593.5937.3.camel@lca.pw> Subject: Re: [PATCH v2] mm/page_isolation: fix a deadlock with printk() From: Qian Cai To: Michal Hocko Cc: Petr Mladek , Christian Borntraeger , Heiko Carstens , sergey.senozhatsky.work@gmail.com, rostedt@goodmis.org, peterz@infradead.org, linux-mm@kvack.org, john.ogness@linutronix.de, akpm@linux-foundation.org, Vasily Gorbik , Peter Oberparleiter , david@redhat.com, linux-kernel@vger.kernel.org Date: Wed, 09 Oct 2019 09:43:13 -0400 In-Reply-To: <20191009132746.GA6681@dhcp22.suse.cz> References: <20191008074357.f33f6pbs4cw5majk@pathway.suse.cz> <20191008082752.GB6681@dhcp22.suse.cz> <1570550917.5576.303.camel@lca.pw> <20191008183525.GQ6681@dhcp22.suse.cz> <1570561573.5576.307.camel@lca.pw> <20191008191728.GS6681@dhcp22.suse.cz> <1570563324.5576.309.camel@lca.pw> <20191009114903.aa6j6sa56z2cssom@pathway.suse.cz> <1570626402.5937.1.camel@lca.pw> <20191009132746.GA6681@dhcp22.suse.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.016922, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2019-10-09 at 15:27 +0200, Michal Hocko wrote: > On Wed 09-10-19 09:06:42, Qian Cai wrote: > [...] > > https://lore.kernel.org/linux-mm/1570460350.5576.290.camel@lca.pw/ > >=20 > > [=C2=A0=C2=A0297.425964] -> #1 (&port_lock_key){-.-.}: > > [=C2=A0=C2=A0297.425967]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0__lock_acquire+0x5b3/0xb40 > > [=C2=A0=C2=A0297.425967]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0lock_acquire+0x126/0x280 > > [=C2=A0=C2=A0297.425968]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0_raw_spin_lock_irqsave+0x3a/0x50 > > [=C2=A0=C2=A0297.425969]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0serial8250_console_write+0x3e4/0x450 > > [=C2=A0=C2=A0297.425970]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0univ8250_console_write+0x4b/0x60 > > [=C2=A0=C2=A0297.425970]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0console_unlock+0x501/0x750 > > [=C2=A0=C2=A0297.425971]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0vprintk_emit+0x10d/0x340 > > [=C2=A0=C2=A0297.425972]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0vprintk_default+0x1f/0x30 > > [=C2=A0=C2=A0297.425972]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0vprintk_func+0x44/0xd4 > > [=C2=A0=C2=A0297.425973]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0printk+0x9f/0xc5 > > [=C2=A0=C2=A0297.425974]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0register_console+0x39c/0x520 > > [=C2=A0=C2=A0297.425975]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0univ8250_console_init+0x23/0x2d > > [=C2=A0=C2=A0297.425975]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0console_init+0x338/0x4cd > > [=C2=A0=C2=A0297.425976]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0start_kernel+0x534/0x724 > > [=C2=A0=C2=A0297.425977]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0x86_64_start_reservations+0x24/0x26 > > [=C2=A0=C2=A0297.425977]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0x86_64_start_kernel+0xf4/0xfb > > [=C2=A0=C2=A0297.425978]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0secondary_startup_64+0xb6/0xc0 > >=20 > > where=C2=A0the report again show the early boot call trace for the lo= cking > > dependency, > >=20 > > console_owner --> port_lock_key > >=20 > > but that dependency clearly not only happen in the early boot. >=20 > Can you provide an example of the runtime dependency without any early > boot artifacts? Because this discussion really doens't make much sense > without a clear example of a _real_ lockdep report that is not a false > possitive. All of them so far have been concluded to be false possitive > AFAIU. An obvious one is in the above link. Just replace the trace in #1 above w= ith printk() from anywhere, i.e., just ignore the early boot calls there as t= hey are not important. printk() console_unlock() console_lock_spinning_enable() --> console_owner_lock call_console_drivers() serial8250_console_write() --> port->lock