From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCF2FC4360C for ; Fri, 27 Sep 2019 21:15:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5D949205F4 for ; Fri, 27 Sep 2019 21:15:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="b96I+dEe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D949205F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ECA878E0005; Fri, 27 Sep 2019 17:15:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7AF18E0001; Fri, 27 Sep 2019 17:15:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D90A18E0005; Fri, 27 Sep 2019 17:15:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id B777B8E0001 for ; Fri, 27 Sep 2019 17:15:12 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 5E9BF87CB for ; Fri, 27 Sep 2019 21:15:12 +0000 (UTC) X-FDA: 75981956064.28.beam53_84b31b369040f X-HE-Tag: beam53_84b31b369040f X-Filterd-Recvd-Size: 6127 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Fri, 27 Sep 2019 21:15:11 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id 201so3121952qkd.13 for ; Fri, 27 Sep 2019 14:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=yZvVoBveDHCzVEJK+p90IwmjpCpkjwFeGPj8F1DecnI=; b=b96I+dEegI+bTtnIMW2dZB0EVGBeMQFrsYW4vJo2dABzohHk6+KA7B0wh47x5ji38q P7Eh0LBknV3w6EGrNr9ERxAkkjn34riEPlr5wX9H3Rp/VtO4TM7KRHpU9keJZhroFDh7 3eEyRKgeVoJ2Jh9QpXiJ5bp63HtssSmsQhIu3e22PHjMpI8Hg0BqbxJB25OxDHvvinXp ujz6NCHIeUNvMoszgYsqH1gr69YmIATvPQq4PT5LC0z/zolzMLwxg7LC/VgeC6wEMfcZ 5pxyo7rqGwiKnEvT2v3KsBGMf1CSGCEn5BSqsBhCN/wzdLX9Asc+np0K5pamUxV7iy5x xVWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=yZvVoBveDHCzVEJK+p90IwmjpCpkjwFeGPj8F1DecnI=; b=kxn4FSk2XrG7rIxdESVJiBA5JS9dSjVqY9arqcrQMpiSRHJQT2/X5xACNUA37h4t6Z cqIRUWd8+XZdzVwku99UiaVDy2J0xJbPRDi4wvoCX2n1U0jJ5zwzCGaLZZhBRjmmvpXW Fq7n9LdoaXV86h7byqxzo0m+vq3I12h9FCevro+MngXEfCcOVSPJCs7L9EkKs9Rf5iaF fg1ZDgjUbyLL5jElioU8oVARjblJO6ntN80wO+41/C1xX0CkV01hrAztUlpe673nIqRT /ymZ39SnUS5Z91gIOoiyefgB0xD5jmfh5xJRYdsrC9Z2sv1R9Fna+fJ0Hj3Vvk56rf7P qZ4w== X-Gm-Message-State: APjAAAV5RQ4Q006R0A9D1moqBDVHAIcwcTQBD595XmoH0PhqloVdsH3O E2HnKSV0YN7BIJa+6ei4eR30CA== X-Google-Smtp-Source: APXvYqwoSvssjY8WGFuqLcE7gxDEJB65YBJZQmbWHTvr9KiCjOXZ5gujAFBo80Z/hTActJBvMK6Frg== X-Received: by 2002:a05:620a:1335:: with SMTP id p21mr6640821qkj.321.1569618911147; Fri, 27 Sep 2019 14:15:11 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id r1sm3282922qti.4.2019.09.27.14.15.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Sep 2019 14:15:10 -0700 (PDT) Message-ID: <1569618908.5576.240.camel@lca.pw> Subject: Re: [PATCH] mm/page_alloc: fix a crash in free_pages_prepare() From: Qian Cai To: Andrew Morton Cc: heiko.carstens@de.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, linux-s390@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Fri, 27 Sep 2019 17:15:08 -0400 In-Reply-To: <20190927134859.95a2f4908bdcea30df0184ed@linux-foundation.org> References: <1569613623-16820-1-git-send-email-cai@lca.pw> <20190927134859.95a2f4908bdcea30df0184ed@linux-foundation.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.001089, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2019-09-27 at 13:48 -0700, Andrew Morton wrote: > On Fri, 27 Sep 2019 15:47:03 -0400 Qian Cai wrote: > > > On architectures like s390, arch_free_page() could mark the page unused > > (set_page_unused()) and any access later would trigger a kernel panic. > > Fix it by moving arch_free_page() after all possible accessing calls. > > > > Hardware name: IBM 2964 N96 400 (z/VM 6.4.0) > > Krnl PSW : 0404e00180000000 0000000026c2b96e > > (__free_pages_ok+0x34e/0x5d8) > > R:0 T:1 IO:0 EX:0 Key:0 M:1 W:0 P:0 AS:3 CC:2 PM:0 RI:0 EA:3 > > Krnl GPRS: 0000000088d43af7 0000000000484000 000000000000007c > > 000000000000000f > > 000003d080012100 000003d080013fc0 0000000000000000 > > 0000000000100000 > > 00000000275cca48 0000000000000100 0000000000000008 > > 000003d080010000 > > 00000000000001d0 000003d000000000 0000000026c2b78a > > 000000002717fdb0 > > Krnl Code: 0000000026c2b95c: ec1100b30659 risbgn %r1,%r1,0,179,6 > > 0000000026c2b962: e32014000036 pfd 2,1024(%r1) > > #0000000026c2b968: d7ff10001000 xc 0(256,%r1),0(%r1) > > >0000000026c2b96e: 41101100 la %r1,256(%r1) > > 0000000026c2b972: a737fff8 brctg %r3,26c2b962 > > 0000000026c2b976: d7ff10001000 xc 0(256,%r1),0(%r1) > > 0000000026c2b97c: e31003400004 lg %r1,832 > > 0000000026c2b982: ebff1430016a asi 5168(%r1),-1 > > Call Trace: > > __free_pages_ok+0x16a/0x5d8) > > memblock_free_all+0x206/0x290 > > mem_init+0x58/0x120 > > start_kernel+0x2b0/0x570 > > startup_continue+0x6a/0xc0 > > INFO: lockdep is turned off. > > Last Breaking-Event-Address: > > __free_pages_ok+0x372/0x5d8 > > Kernel panic - not syncing: Fatal exception: panic_on_oops > > 00: HCPGIR450W CP entered; disabled wait PSW 00020001 80000000 00000000 > > 26A2379C > > > > ... > > > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -1175,11 +1175,11 @@ static __always_inline bool free_pages_prepare(struct page *page, > > debug_check_no_obj_freed(page_address(page), > > PAGE_SIZE << order); > > } > > - arch_free_page(page, order); > > if (want_init_on_free()) > > kernel_init_free_pages(page, 1 << order); > > > > kernel_poison_pages(page, 1 << order, 0); > > + arch_free_page(page, order); > > if (debug_pagealloc_enabled()) > > kernel_map_pages(page, 1 << order, 0); > > This is all fairly mature code, isn't it? What happened to make this > problem pop up now? In the past, there is only kernel_poison_pages() would trigger it but it needs "page_poison=on" kernel cmdline, and I suspect nobody tested that on s390 in the past. Recently, kernel_init_free_pages() (the commit 6471384af2a6) was added to the kernel and could trigger it as well. > > IOW, is a -stable backport needed? Since kernel_init_free_pages() was added in v5.3, I think it does not hurt to backport to -stable there.