From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7749C10F1A for ; Thu, 9 May 2024 21:33:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B89F6B009E; Thu, 9 May 2024 17:33:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 468EA6B009F; Thu, 9 May 2024 17:33:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 331276B00A0; Thu, 9 May 2024 17:33:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0ED416B009E for ; Thu, 9 May 2024 17:33:51 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7D574A2692 for ; Thu, 9 May 2024 21:33:50 +0000 (UTC) X-FDA: 82100159820.21.E03EDE0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id A446F100006 for ; Thu, 9 May 2024 21:33:48 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Ija/fl61"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715290428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IcaQVOny0rQHUK0pL7eF7lEuZY7XrpmUt/qtfJiKS4s=; b=IXfLJ+Ekeov+1Zyif+WktOOrazAApBGVPvDnjI44lB1DW3gqd67OiopMe7HvakeFBqdB+c 1iCEVi+qpGsIpA9VCIb2s1QBCnyzNnij4/8PIGm+vW8cJSdOHkvuXspq3Qujrd7PHYjxwA Nvz56T7EdvGKCQ1ZaNs9ESZqJfrvtP0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Ija/fl61"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715290428; a=rsa-sha256; cv=none; b=KfEDZmhFgye4XuYqIHUrbOaToN5YbtLW9gngpolwVrjfE4EyQUJAdjWOyhR0sF8JdBrIS7 TRFupPAGpYPbukw+VdKN/ZPL6cGWhTpmTP55GUgEV/SqSfEjICTIIm63VJF3bdgpHxA5y7 rP6bxGIwuUDiigdHe/a2UTYdg44SLUU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715290426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IcaQVOny0rQHUK0pL7eF7lEuZY7XrpmUt/qtfJiKS4s=; b=Ija/fl61EQLZSiq338Weocqjqz0pwGyeBRbAufp0RDa27x7SqISjBA8S1oa5DClQ3PSGrQ 3idD7y33wuqm531tQFQ1jOsmG/NdYXHvgsMU3oiFy9yoHujUCMqREidwenzb5NIxZSG95I HIVkbvA9qd52fjz/JmKfpYjL5qLX8t8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-84-SXXJHLiOO2OSZBwSwPH1GA-1; Thu, 09 May 2024 17:33:43 -0400 X-MC-Unique: SXXJHLiOO2OSZBwSwPH1GA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 046A38030A4; Thu, 9 May 2024 21:33:42 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id 12FA0116F842; Thu, 9 May 2024 21:33:37 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20231221132400.1601991-1-dhowells@redhat.com> <20231221132400.1601991-41-dhowells@redhat.com> To: Andrea Righi Cc: dhowells@redhat.com, Jeff Layton , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Eric Van Hensbergen , Ilya Dryomov , Christian Brauner , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Latchesar Ionkov , Christian Schoenebeck Subject: Re: [PATCH v5 40/40] 9p: Use netfslib read/write_iter MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1567251.1715290417.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Thu, 09 May 2024 22:33:37 +0100 Message-ID: <1567252.1715290417@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Rspamd-Server: rspam01 X-Stat-Signature: yifjoximyypieee8mrp34kanawbofftr X-Rspam-User: X-Rspamd-Queue-Id: A446F100006 X-HE-Tag: 1715290428-233662 X-HE-Meta: U2FsdGVkX1+njzRJIKeDmsEikJFzdpbGRGK23zFk/CsYnZZa9RxTpzmkcc+wqb2EzdL6MkvWNePA2gQF7FTeXNe8OvK7LgHikC7a8urzAGJRBYMdL7F5eZc8akMuG2wygK6hPEt51w48Z3czubRdpmWxJ72IX5pfhYDTMYI9gmuUthXfaJaH8arJXX+hBGoBGW2bbt8+ExKbaAyvyyECW8bYDqare7ts3nCUNeY+2bCPAzmA7pAUM0wV0bQ9M1Zxe+RRZxFSxjl6VQQy3MSxw+reN7wrLcx1IcjFpQTNdUPpCTmsJowA+eqinEY196+0SWa3gKHWyuAKNAB/ZWryowPxKc3FKcV/he5FbLwvkTZYOJemUz6TtbZlE9OH8l+qRu5DM2u0uTw4bhBM4m6TaFuh3adyzuot/G38QjBcC2SEqtkWvZMb1Mu8wBXxv7PeBW1lq8+bziJsEHKOH58guploW0VncLbTSWdmxEq7Mmtx9C29Q/Pk7p/3Qohd3fFSBK8yCr/EgbKePSOkGaKwuWF1FWN8/REOZ5OTQJEo8NP0+LEKIcjJrskYTglhf8HszGMZPlrNDogeH9pjb3wTMe799+eAq3Ge+uUVdf/b03MXo91g5LoCPoB8zqtPbqlWKix9aBDuyCak4gx1lrU799eNLjOuGWdR6proqR9JPPHpmWtjs/0v+J9qgBJRfpMX9Rb8xrIMrNwq/eSN2BKRLHtx/k+5CRDnw4+PoGK3A+cTNyiVrhvPUGNOH5vUFmVtwi71pe06b/Br0WHkVywEyvsnhd3f00P9agZ5RU68RQWF/jtj53ZyVDzWrD/7IXxkQmQ1GWjaztxbMxTbbGP05owDCbd4ods0b+EjrOq/apwmJ3lZovdw/7HzxVbPngzr/Hm9vqRvh89QJjJey1ExdUKxYD2Rwb+s4XKCGVHFL5k9knEgNFq78H9ubB0Ek/n8AMnT+vmwoScIpPjpXX3 27yeDGsN 6WIaNEAOYwz33GjfCqkJ+QnO61jFvbEstKsu/iyMLbTk9O6UDixEGB3n2ebpNo9W4yMJcfB0xN7MYmR3NEw24hNB9NfMLpSlxWzdce/Sg5TxgkCnEanMewJYTTgr0XIwgxNQxpGsNG0boKmwllzouIYe+95IL2Vy6bk3eaUwBjNsGLiZnWrVFDcNsByqHsOIbgxajlHV+djfHHIaUEahc5T1sNzStjz8YtI7JCFcbxNGPume/CXGiUE375i9ZLDX85KB8yEXmTV8ufkUx2bO7w8XTBcUQre7KSCYUj1eQOpPUcoORM3YCRDgcBxUKceBkP6A2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Andrea Righi wrote: > On Thu, Dec 21, 2023 at 01:23:35PM +0000, David Howells wrote: > > Use netfslib's read and write iteration helpers, allowing netfslib to = take > > over the management of the page cache for 9p files and to manage local= disk > > caching. In particular, this eliminates write_begin, write_end, write= page > > and all mentions of struct page and struct folio from 9p. > > = > > Note that netfslib now offers the possibility of write-through caching= if > > that is desirable for 9p: just set the NETFS_ICTX_WRITETHROUGH flag in > > v9inode->netfs.flags in v9fs_set_netfs_context(). > > = > > Note also this is untested as I can't get ganesha.nfsd to correctly pa= rse > > the config to turn on 9p support. > = > It looks like this patch has introduced a regression with autopkgtest, > see: https://bugs.launchpad.net/bugs/2056461 > = > I haven't looked at the details yet, I just did some bisecting and > apparently reverting this one seems to fix the problem. > = > Let me know if you want me to test something in particular or if you > already have a potential fix. Otherwise I'll take a look. Do you have a reproducer? I'll be at LSF next week, so if I can't fix it tomorrow, I won't be able t= o poke at it until after that. David