* [PATCH v2] mm, memory-failure: clarify error message
@ 2019-05-21 1:52 Jane Chu
2019-05-21 2:00 ` Naoya Horiguchi
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jane Chu @ 2019-05-21 1:52 UTC (permalink / raw)
To: n-horiguchi, linux-mm, linux-kernel; +Cc: linux-nvdimm
Some user who install SIGBUS handler that does longjmp out
therefore keeping the process alive is confused by the error
message
"[188988.765862] Memory failure: 0x1840200: Killing
cellsrv:33395 due to hardware memory corruption"
Slightly modify the error message to improve clarity.
Signed-off-by: Jane Chu <jane.chu@oracle.com>
---
mm/memory-failure.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index fc8b517..c4f4bcd 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -216,7 +216,7 @@ static int kill_proc(struct to_kill *tk, unsigned long pfn, int flags)
short addr_lsb = tk->size_shift;
int ret;
- pr_err("Memory failure: %#lx: Killing %s:%d due to hardware memory corruption\n",
+ pr_err("Memory failure: %#lx: Sending SIGBUS to %s:%d due to hardware memory corruption\n",
pfn, t->comm, t->pid);
if ((flags & MF_ACTION_REQUIRED) && t->mm == current->mm) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mm, memory-failure: clarify error message
2019-05-21 1:52 [PATCH v2] mm, memory-failure: clarify error message Jane Chu
@ 2019-05-21 2:00 ` Naoya Horiguchi
2019-05-21 2:17 ` Anshuman Khandual
2019-05-21 4:14 ` Pankaj Gupta
2 siblings, 0 replies; 4+ messages in thread
From: Naoya Horiguchi @ 2019-05-21 2:00 UTC (permalink / raw)
To: Jane Chu; +Cc: linux-mm, linux-kernel, linux-nvdimm
On Mon, May 20, 2019 at 07:52:03PM -0600, Jane Chu wrote:
> Some user who install SIGBUS handler that does longjmp out
> therefore keeping the process alive is confused by the error
> message
> "[188988.765862] Memory failure: 0x1840200: Killing
> cellsrv:33395 due to hardware memory corruption"
> Slightly modify the error message to improve clarity.
>
> Signed-off-by: Jane Chu <jane.chu@oracle.com>
Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mm, memory-failure: clarify error message
2019-05-21 1:52 [PATCH v2] mm, memory-failure: clarify error message Jane Chu
2019-05-21 2:00 ` Naoya Horiguchi
@ 2019-05-21 2:17 ` Anshuman Khandual
2019-05-21 4:14 ` Pankaj Gupta
2 siblings, 0 replies; 4+ messages in thread
From: Anshuman Khandual @ 2019-05-21 2:17 UTC (permalink / raw)
To: Jane Chu, n-horiguchi, linux-mm, linux-kernel; +Cc: linux-nvdimm
On 05/21/2019 07:22 AM, Jane Chu wrote:
> Some user who install SIGBUS handler that does longjmp out
> therefore keeping the process alive is confused by the error
> message
> "[188988.765862] Memory failure: 0x1840200: Killing
> cellsrv:33395 due to hardware memory corruption"
> Slightly modify the error message to improve clarity.
>
> Signed-off-by: Jane Chu <jane.chu@oracle.com>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mm, memory-failure: clarify error message
2019-05-21 1:52 [PATCH v2] mm, memory-failure: clarify error message Jane Chu
2019-05-21 2:00 ` Naoya Horiguchi
2019-05-21 2:17 ` Anshuman Khandual
@ 2019-05-21 4:14 ` Pankaj Gupta
2 siblings, 0 replies; 4+ messages in thread
From: Pankaj Gupta @ 2019-05-21 4:14 UTC (permalink / raw)
To: Jane Chu; +Cc: n-horiguchi, linux-mm, linux-kernel, linux-nvdimm
> Some user who install SIGBUS handler that does longjmp out
> therefore keeping the process alive is confused by the error
> message
> "[188988.765862] Memory failure: 0x1840200: Killing
> cellsrv:33395 due to hardware memory corruption"
> Slightly modify the error message to improve clarity.
>
> Signed-off-by: Jane Chu <jane.chu@oracle.com>
> ---
> mm/memory-failure.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index fc8b517..c4f4bcd 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -216,7 +216,7 @@ static int kill_proc(struct to_kill *tk, unsigned long
> pfn, int flags)
> short addr_lsb = tk->size_shift;
> int ret;
>
> - pr_err("Memory failure: %#lx: Killing %s:%d due to hardware memory
> corruption\n",
> + pr_err("Memory failure: %#lx: Sending SIGBUS to %s:%d due to hardware
> memory corruption\n",
> pfn, t->comm, t->pid);
>
> if ((flags & MF_ACTION_REQUIRED) && t->mm == current->mm) {
> --
> 1.8.3.1
This error message is helpful.
Acked-by: Pankaj Gupta <pagupta@redhat.com>
>
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-21 4:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-21 1:52 [PATCH v2] mm, memory-failure: clarify error message Jane Chu
2019-05-21 2:00 ` Naoya Horiguchi
2019-05-21 2:17 ` Anshuman Khandual
2019-05-21 4:14 ` Pankaj Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox