From: Oscar Salvador <osalvador@suse.de>
To: Yang Shi <yang.shi@linux.alibaba.com>
Cc: chrubis@suse.cz, vbabka@suse.cz, kirill@shutemov.name,
akpm@linux-foundation.org, stable@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: mempolicy: make mbind() return -EIO when MPOL_MF_STRICT is specified
Date: Wed, 20 Mar 2019 19:48:34 +0100 [thread overview]
Message-ID: <1553107714.2927.2.camel@suse.de> (raw)
In-Reply-To: <3c880e88-6eb7-cd6d-fbf3-394b89355e10@linux.alibaba.com>
On Wed, 2019-03-20 at 11:31 -0700, Yang Shi wrote:
> No, this is not correct. queue_pages_pmd() may return 0, which means
> THP
> gets split. If it returns 0 the code should just fall through instead
> of
> returning.
Right, I overlooked that.
> It sounds not correct to me. We need check if there is existing page
> on
> the node which is not allowed by the policy. This is what
> queue_pages_required() does.
Bleh, I guess it was too early in the morning.
That is the whole point of it actually, so that was quite wrong.
Sorry for trying to mislead you ;-)
Reviewed-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2019-03-20 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 18:35 Yang Shi
2019-03-20 0:49 ` David Rientjes
2019-03-20 1:06 ` Yang Shi
2019-03-20 5:53 ` Souptick Joarder
2019-03-20 22:16 ` Andrew Morton
2019-03-20 23:06 ` Yang Shi
2019-03-20 8:16 ` Oscar Salvador
2019-03-20 18:31 ` Yang Shi
2019-03-20 18:48 ` Oscar Salvador [this message]
2019-03-20 15:44 ` Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553107714.2927.2.camel@suse.de \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=chrubis@suse.cz \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox