From: Yafang Shao <laoar.shao@gmail.com>
To: akpm@linux-foundation.org, mhocko@suse.com, ktkhai@virtuozzo.com,
broonie@kernel.org, hannes@cmpxchg.org
Cc: linux-mm@kvack.org, shaoyafang@didiglobal.com,
Yafang Shao <laoar.shao@gmail.com>
Subject: [PATCH] mm: vmscan: add tracepoints for node reclaim
Date: Thu, 28 Feb 2019 16:14:24 +0800 [thread overview]
Message-ID: <1551341664-13912-1-git-send-email-laoar.shao@gmail.com> (raw)
In the page alloc fast path, it may do node reclaim, which may cause
latency spike.
We should add tracepoint for this event, and also mesure the latency
it causes.
So bellow two tracepoints are introduced,
mm_vmscan_node_reclaim_begin
mm_vmscan_node_reclaim_end
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
---
include/trace/events/vmscan.h | 48 +++++++++++++++++++++++++++++++++++++++++++
mm/vmscan.c | 13 +++++++++++-
2 files changed, 60 insertions(+), 1 deletion(-)
diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h
index a1cb913..9310d5b 100644
--- a/include/trace/events/vmscan.h
+++ b/include/trace/events/vmscan.h
@@ -465,6 +465,54 @@
__entry->ratio,
show_reclaim_flags(__entry->reclaim_flags))
);
+
+TRACE_EVENT(mm_vmscan_node_reclaim_begin,
+
+ TP_PROTO(int nid, int order, int may_writepage,
+ gfp_t gfp_flags, int zid),
+
+ TP_ARGS(nid, order, may_writepage, gfp_flags, zid),
+
+ TP_STRUCT__entry(
+ __field(int, nid)
+ __field(int, order)
+ __field(int, may_writepage)
+ __field(gfp_t, gfp_flags)
+ __field(int, zid)
+ ),
+
+ TP_fast_assign(
+ __entry->nid = nid;
+ __entry->order = order;
+ __entry->may_writepage = may_writepage;
+ __entry->gfp_flags = gfp_flags;
+ __entry->zid = zid;
+ ),
+
+ TP_printk("nid=%d zid=%d order=%d may_writepage=%d gfp_flags=%s",
+ __entry->nid,
+ __entry->zid,
+ __entry->order,
+ __entry->may_writepage,
+ show_gfp_flags(__entry->gfp_flags))
+);
+
+TRACE_EVENT(mm_vmscan_node_reclaim_end,
+
+ TP_PROTO(int result),
+
+ TP_ARGS(result),
+
+ TP_STRUCT__entry(
+ __field(int, result)
+ ),
+
+ TP_fast_assign(
+ __entry->result = result;
+ ),
+
+ TP_printk("result=%d", __entry->result)
+);
#endif /* _TRACE_VMSCAN_H */
/* This part must be outside protection */
diff --git a/mm/vmscan.c b/mm/vmscan.c
index ac4806f..01a0401 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -4240,6 +4240,12 @@ static int __node_reclaim(struct pglist_data *pgdat, gfp_t gfp_mask, unsigned in
.may_swap = 1,
.reclaim_idx = gfp_zone(gfp_mask),
};
+ int result;
+
+ trace_mm_vmscan_node_reclaim_begin(pgdat->node_id, order,
+ sc.may_writepage,
+ sc.gfp_mask,
+ sc.reclaim_idx);
cond_resched();
fs_reclaim_acquire(sc.gfp_mask);
@@ -4267,7 +4273,12 @@ static int __node_reclaim(struct pglist_data *pgdat, gfp_t gfp_mask, unsigned in
current->flags &= ~PF_SWAPWRITE;
memalloc_noreclaim_restore(noreclaim_flag);
fs_reclaim_release(sc.gfp_mask);
- return sc.nr_reclaimed >= nr_pages;
+
+ result = sc.nr_reclaimed >= nr_pages;
+
+ trace_mm_vmscan_node_reclaim_end(result);
+
+ return result;
}
int node_reclaim(struct pglist_data *pgdat, gfp_t gfp_mask, unsigned int order)
--
1.8.3.1
next reply other threads:[~2019-02-28 8:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 8:14 Yafang Shao [this message]
2019-02-28 8:59 ` Souptick Joarder
2019-02-28 9:35 ` Yafang Shao
2019-02-28 10:17 ` Michal Hocko
2019-02-28 10:20 ` Yafang Shao
2019-02-28 10:28 ` Michal Hocko
2019-02-28 10:21 ` Vlastimil Babka
2019-02-28 10:34 ` Yafang Shao
2019-02-28 10:44 ` Vlastimil Babka
2019-02-28 10:48 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551341664-13912-1-git-send-email-laoar.shao@gmail.com \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=shaoyafang@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox