From: Jing Xiangfeng <jingxiangfeng@huawei.com>
To: <mike.kravetz@oracle.com>, <mhocko@kernel.org>
Cc: <akpm@linux-foundation.org>, <hughd@google.com>,
<linux-mm@kvack.org>, <n-horiguchi@ah.jp.nec.com>,
<aarcange@redhat.com>, <kirill.shutemov@linux.intel.com>,
<linux-kernel@vger.kernel.org>,
"Jing Xiangfeng" <jingxiangfeng@huawei.com>
Subject: [PATCH v4] mm/hugetlb: Fix unsigned overflow in __nr_hugepages_store_common()
Date: Sat, 23 Feb 2019 09:32:09 +0800 [thread overview]
Message-ID: <1550885529-125561-1-git-send-email-jingxiangfeng@huawei.com> (raw)
User can change a node specific hugetlb count. i.e.
/sys/devices/system/node/node1/hugepages/hugepages-2048kB/nr_hugepages
the calculated value of count is a total number of huge pages. It could
be overflow when a user entering a crazy high value. If so, the total
number of huge pages could be a small value which is not user expect.
We can simply fix it by setting count to ULONG_MAX, then it goes on. This
may be more in line with user's intention of allocating as many huge pages
as possible.
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
mm/hugetlb.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index afef616..6688894 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -2423,7 +2423,14 @@ static ssize_t __nr_hugepages_store_common(bool obey_mempolicy,
* per node hstate attribute: adjust count to global,
* but restrict alloc/free to the specified node.
*/
+ unsigned long old_count = count;
count += h->nr_huge_pages - h->nr_huge_pages_node[nid];
+ /*
+ * If user specified count causes overflow, set to
+ * largest possible value.
+ */
+ if (count < old_count)
+ count = ULONG_MAX;
init_nodemask_of_node(nodes_allowed, nid);
} else
nodes_allowed = &node_states[N_MEMORY];
--
2.7.4
next reply other threads:[~2019-02-23 1:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 1:32 Jing Xiangfeng [this message]
2019-02-25 0:45 ` Mike Kravetz
2019-02-25 3:17 ` David Rientjes
2019-02-25 16:49 ` Mike Kravetz
2019-02-25 18:19 ` Mike Kravetz
2019-02-25 19:17 ` David Rientjes
2019-02-26 2:22 ` Jing Xiangfeng
2019-02-26 6:21 ` David Rientjes
2019-02-26 19:32 ` Mike Kravetz
2019-02-26 22:36 ` Andrew Morton
2019-02-27 0:03 ` Mike Kravetz
2019-03-04 13:48 ` Oscar Salvador
2019-03-05 0:03 ` Naoya Horiguchi
2019-03-05 4:15 ` Mike Kravetz
2019-03-05 21:16 ` Andrew Morton
2019-03-05 21:35 ` Mike Kravetz
2019-03-05 21:41 ` Alex Ghiti
2019-03-06 9:41 ` Oscar Salvador
2019-03-07 0:17 ` Mike Kravetz
2019-03-04 6:00 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550885529-125561-1-git-send-email-jingxiangfeng@huawei.com \
--to=jingxiangfeng@huawei.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox