From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by kanga.kvack.org (Postfix) with ESMTP id EB4AE8E0038 for ; Wed, 9 Jan 2019 07:20:37 -0500 (EST) Received: by mail-lf1-f72.google.com with SMTP id m19so561225lfj.17 for ; Wed, 09 Jan 2019 04:20:37 -0800 (PST) Received: from relay.sw.ru (relay.sw.ru. [185.231.240.75]) by mx.google.com with ESMTPS id p11-v6si61579253ljc.73.2019.01.09.04.20.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Jan 2019 04:20:36 -0800 (PST) Subject: [PATCH 2/3] mm: Recharge page memcg on first get from pagecache From: Kirill Tkhai Date: Wed, 09 Jan 2019 15:20:30 +0300 Message-ID: <154703642996.32690.7131436841852687919.stgit@localhost.localdomain> In-Reply-To: <154703479840.32690.6504699919905946726.stgit@localhost.localdomain> References: <154703479840.32690.6504699919905946726.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: akpm@linux-foundation.org, hannes@cmpxchg.org, josef@toxicpanda.com, jack@suse.cz, hughd@google.com, ktkhai@virtuozzo.com, darrick.wong@oracle.com, mhocko@suse.com, aryabinin@virtuozzo.com, guro@fb.com, mgorman@techsingularity.net, shakeelb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org This patch makes pagecache_get_page() to charge uncharged page into memcg of process, which accesses the page first. Page will be returned in case of it's charged only, so memcg tasks can't use pages, which was left by __remove_mapping(), without accounting them. In case of accounting is not possible, pages remain in pagecache, and further global reclaim will remove them (and this will be easily, since pages are not mapped by any task). Also, note that uncharged page can't be dirty or under writeback, since it was able to be isolated in __remove_mapping() earlier. Signed-off-by: Kirill Tkhai --- mm/filemap.c | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/mm/filemap.c b/mm/filemap.c index 65c85c47bdb1..2603c44fc74a 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1576,15 +1576,18 @@ EXPORT_SYMBOL(find_lock_entry); struct page *pagecache_get_page(struct address_space *mapping, pgoff_t offset, int fgp_flags, gfp_t gfp_mask) { + struct mem_cgroup *memcg; struct page *page; + bool drop_lock; repeat: + drop_lock = false; page = find_get_entry(mapping, offset); if (xa_is_value(page)) page = NULL; if (!page) goto no_page; - +lock: if (fgp_flags & FGP_LOCK) { if (fgp_flags & FGP_NOWAIT) { if (!trylock_page(page)) { @@ -1604,6 +1607,31 @@ struct page *pagecache_get_page(struct address_space *mapping, pgoff_t offset, VM_BUG_ON_PAGE(page->index != offset, page); } + if (!mem_cgroup_disabled() && !PageHuge(page) && + !page_memcg(page) && !page_mapped(page) && + test_bit(AS_KEEP_MEMCG_RECLAIM, &mapping->flags)) { + if (!(fgp_flags & FGP_LOCK)) { + drop_lock = true; + fgp_flags |= FGP_LOCK; + goto lock; + } + + if (!WARN_ON(PageDirty(page) || PageWriteback(page))) { + if (mem_cgroup_try_charge(page, current->mm, + gfp_mask, &memcg, false)) { + unlock_page(page); + put_page(page); + return NULL; + } + mem_cgroup_commit_charge(page, memcg, true, false); + if (!isolate_lru_page(page)) + putback_lru_page(page); + } + } + + if (drop_lock) + unlock_page(page); + if (fgp_flags & FGP_ACCESSED) mark_page_accessed(page);