From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AD2CC3DA7A for ; Fri, 6 Jan 2023 15:49:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68ED18E0002; Fri, 6 Jan 2023 10:49:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63D638E0001; Fri, 6 Jan 2023 10:49:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DE2C8E0002; Fri, 6 Jan 2023 10:49:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3C04D8E0001 for ; Fri, 6 Jan 2023 10:49:21 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0D13C8082C for ; Fri, 6 Jan 2023 15:49:21 +0000 (UTC) X-FDA: 80324808522.05.9E8A26F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id F0EC8A0015 for ; Fri, 6 Jan 2023 15:49:18 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BhQ2Aa5z; spf=pass (imf15.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673020159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lph/2wsjDRNRXrE8+YsS+8Yp4KSw6iLMLjz/fi7DRbI=; b=AmH2+sxa0e0jCb0C+R55JOkmmQBxWZnelrlrHhCwKLkE/Phu1PQ/XeYcVHRHXO2f+H1o2X kmj6Wv85BaoIGkPzfaqbTEDWr+NAV0RvGwN6RMTAH8S9xhSIFpfnF0J6DcDIf8WJNqXTtz JKs1gBxLVOraJP6zkQBP4NzHg9P63pQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BhQ2Aa5z; spf=pass (imf15.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673020159; a=rsa-sha256; cv=none; b=DMT+sJaBkuLcBXFAztSSRL4bUS0ZRLJtlqaYi1hYMyS7megWmY8whakywViFtAtKQfyC8m 0LR22kwNxZmrQXd45iKlVemfjIPBSMGdfjl+++OZwa5vFdiIlqwJMGbzW5mCcPZipbEByI fzVRGz+3OyCW2BwboAeDBM/0nxxBIns= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673020158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lph/2wsjDRNRXrE8+YsS+8Yp4KSw6iLMLjz/fi7DRbI=; b=BhQ2Aa5zkJ2CmvqsxeSDII4tspEnDd72RP0L7UIRtrx8Fer4eft8DS1vZTQ72Ml3Dxd0st HziAtdE8c3tYdz+MdRqbJAlLIXEN6m81Ax2Blsin6ZZkQ+QbCKGnCF7snm2AwJiwoJdSxV 89IPOk3VhTnkqvSl8P/B2varUsCinNY= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-169-O09ElhTaPj-LOFx75DShWg-1; Fri, 06 Jan 2023 10:49:15 -0500 X-MC-Unique: O09ElhTaPj-LOFx75DShWg-1 Received: by mail-ej1-f72.google.com with SMTP id sc9-20020a1709078a0900b0084c4e8dc14eso1379833ejc.4 for ; Fri, 06 Jan 2023 07:49:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lph/2wsjDRNRXrE8+YsS+8Yp4KSw6iLMLjz/fi7DRbI=; b=6PYhEpm7KlqNd3BICgFVdNYXmZ6iaEGUBM3Dg3PMCT//0RrNJELmnf82Zg/8sJMdMT o7V+vUc/TcQZKIrqcPsSFwMbvMRhlYD1mj15cbAAOS7vgJg8nJ/ZXi5o8EdKZbrVrqm4 4MdYiWffsGLBL82Ie849XxkIeJQSJ7LmZjmpUeHJqLL7UPOd+oVRr3jtfmMQ2hVmLRSr gAa5zf/kraE6X1Sqyuz5XNYMwzTeZ11niTbGpMsW7ETeofPCj0ZY0g+w1QFOXkjz5oBs Dkp5J56f4UntSITXD6NguPBfHEKJzJkuaxa+ceNAzHgVJ9beeqSghhcrINXrcYeRpyFk RcnQ== X-Gm-Message-State: AFqh2kp3T8xHGqSjk4saeho2ASoIhdAwFrZ1FbQdp5l0YcX/WT7NvDTg y2z2O6A5j2V5NG9pX/LFLDSElmbyfzuVtNVMwUJ8WfFlgSSgc3f2ufbweXdP4xdeXfYCMMvqPob NlXyXiVtanZA= X-Received: by 2002:a17:907:93d5:b0:83c:cca7:64a7 with SMTP id cp21-20020a17090793d500b0083ccca764a7mr43083837ejc.73.1673020154026; Fri, 06 Jan 2023 07:49:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXtFhILVowoAPgDM9eOXXnIu0iYLSGX2Jdz4LjUL/Xlzhf+9fa98zmq4soh027TXtbOfrhRx3g== X-Received: by 2002:a17:907:93d5:b0:83c:cca7:64a7 with SMTP id cp21-20020a17090793d500b0083ccca764a7mr43083822ejc.73.1673020153797; Fri, 06 Jan 2023 07:49:13 -0800 (PST) Received: from [192.168.42.222] (nat-cgn9-185-107-15-52.static.kviknet.net. [185.107.15.52]) by smtp.gmail.com with ESMTPSA id a23-20020aa7d757000000b0046f77031d40sm602537eds.10.2023.01.06.07.49.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 07:49:13 -0800 (PST) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: <1545f7e7-3c2c-435a-b597-0824decf571c@redhat.com> Date: Fri, 6 Jan 2023 16:49:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Cc: brouer@redhat.com, netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Subject: Re: [PATCH v2 17/24] page_pool: Convert page_pool_return_skb_page() to use netmem To: "Matthew Wilcox (Oracle)" , Jesper Dangaard Brouer , Ilias Apalodimas References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-18-willy@infradead.org> In-Reply-To: <20230105214631.3939268-18-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F0EC8A0015 X-Rspam-User: X-Stat-Signature: qppi3m835fd5da7pgopaahoun5nshkcx X-HE-Tag: 1673020158-813101 X-HE-Meta: U2FsdGVkX18bGgGaYLum119krJUrGY2oqHemA8GhUuT58aCsri/L/raf2WoS/Hppz4Y+eK1dXJS3kXtHB+wpym16nHofZt0D/2v4xtlaNFB1DeA5H2UOW6CnUUFoEDf3FPSxZsrV2+/bv4YBs4k8Sr5cxe37AGUrRNTvxfOyKkGeZIz2WBXH7/iIt/1XOpUx3Y3QeURuL6CQsa8i/4R1VvvEx/5h81A4vrJvli84Sw1lXJojUcnvp+4MV0n1fzAcPRRYS9tanaKgzrQJ4kIi2Yoai9+f/0+FBP4azFTiG+LJDwHluvPO4PwWS+GiCXF403kiLxBTDXwIrs/y6iX/p81RUX7VqZT0TpifxuG6v7tYxznEJTUZpGFwELhavhIuGr4bXsgrVnlM7HCn+auaKoptp51oMeD3nzBP3Hk5BBiP5CiqyCuT1xZOBR18z9XezEm8nLAFNo5ngP91rfCm7bVFEYr5y5ep6Oe5tKb3TFNIw/2al9TQ7RO7yXfHYhFjr6r4qz98qBq6UPHfBx2aHTssdOFy6MxXtNMZYalgxiLsf3h6feMcLDgPGAnyPhIAAW5H7qTel91ThJPQoP/fIw0fvLHb4VufNd06rMW1zryh3IIobvRMxqYF5+HgbdwjA2Vd3jgOo7m00jQ+jzXQw5iaaKFFeI50th4ySQz1Q4dyRDS6r814PCa1qzsE4OHwSmRlRO3JBO/AEUtzn9FvAAHb6AvofpgOY/n/WWG5b4kskIE4QyZBVp5EMip5A2HUwXStaDiaDKJu9W5DER0DdPmPQknfGi31DMU8Vp4vmIxRQEeaaHWH7qqPAYNO9bdIYa4w5RBjs9/CUwdC5r3/IKLcgW8FZob9Eq+5j4ukM7YzwNVPKtEw0wibe02orkT9htciGyveWUREFE/Dy9mFpTk9UyAMiVqihs86uLLBDdbHmcVUiu0YfOVg6dOl0CaGJwWGuIWZGf0tcpMI5uy Qo7xl+1A /NAbtHZdAP1tHauwmE/zjP5h4b7T/f9Mwihf9JC0ecBk48sw4Gie0zFPSgiLzb0W+iNTO4pNDOoEASBSX8gMc70svd4ryk/6jWE5FgfLTOHZvbEzBitmMrtw3crTzcggzDsvweN/dUbnawbJrlqkTZ3YrdA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05/01/2023 22.46, Matthew Wilcox (Oracle) wrote: > This function accesses the pagepool members of struct page directly, > so it needs to become netmem. Add page_pool_put_full_netmem() and > page_pool_recycle_netmem(). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/net/page_pool.h | 14 +++++++++++++- > net/core/page_pool.c | 13 ++++++------- > 2 files changed, 19 insertions(+), 8 deletions(-) > > diff --git a/include/net/page_pool.h b/include/net/page_pool.h > index fbb653c9f1da..126c04315929 100644 > --- a/include/net/page_pool.h > +++ b/include/net/page_pool.h > @@ -464,10 +464,16 @@ static inline void page_pool_put_page(struct page_pool *pool, > } > > /* Same as above but will try to sync the entire area pool->max_len */ > +static inline void page_pool_put_full_netmem(struct page_pool *pool, > + struct netmem *nmem, bool allow_direct) > +{ > + page_pool_put_netmem(pool, nmem, -1, allow_direct); > +} > + > static inline void page_pool_put_full_page(struct page_pool *pool, > struct page *page, bool allow_direct) > { > - page_pool_put_page(pool, page, -1, allow_direct); > + page_pool_put_full_netmem(pool, page_netmem(page), allow_direct); > } > > /* Same as above but the caller must guarantee safe context. e.g NAPI */ > @@ -477,6 +483,12 @@ static inline void page_pool_recycle_direct(struct page_pool *pool, > page_pool_put_full_page(pool, page, true); > } > > +static inline void page_pool_recycle_netmem(struct page_pool *pool, > + struct netmem *nmem) > +{ > + page_pool_put_full_netmem(pool, nmem, true); ^^^^ It is not clear in what context page_pool_recycle_netmem() will be used, but I think the 'true' (allow_direct=true) might be wrong here. It is only in limited special cases (RX-NAPI context) we can allow direct return to the RX-alloc-cache. --Jesper (cut rest of patch which looked fine)