From: Qian Cai <cai@lca.pw>
To: William Kucharski <william.kucharski@oracle.com>
Cc: akpm@linux-foundation.org, mhocko@suse.com,
Pavel.Tatashin@microsoft.com, mingo@kernel.org, hpa@zytor.com,
mgorman@techsingularity.net, iamjoonsoo.kim@lge.com,
tglx@linutronix.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm/page_owner: fix for deferred struct page init
Date: Thu, 20 Dec 2018 16:04:46 -0500 [thread overview]
Message-ID: <1545339886.18411.31.camel@lca.pw> (raw)
In-Reply-To: <E084FF0A-88CD-4E61-88F2-7D542D67DDF1@oracle.com>
On Thu, 2018-12-20 at 14:00 -0700, William Kucharski wrote:
> > On Dec 20, 2018, at 1:31 PM, Qian Cai <cai@lca.pw> wrote:
> >
> > diff --git a/mm/page_ext.c b/mm/page_ext.c
> > index ae44f7adbe07..d76fd51e312a 100644
> > --- a/mm/page_ext.c
> > +++ b/mm/page_ext.c
> > @@ -399,9 +399,8 @@ void __init page_ext_init(void)
> > * -------------pfn-------------->
> > * N0 | N1 | N2 | N0 | N1 | N2|....
> > *
> > - * Take into account DEFERRED_STRUCT_PAGE_INIT.
> > */
> > - if (early_pfn_to_nid(pfn) != nid)
> > + if (pfn_to_nid(pfn) != nid)
> > continue;
> > if (init_section_page_ext(pfn, nid))
> > goto oom;
> > --
> > 2.17.2 (Apple Git-113)
> >
>
> Is there any danger in the fact that in the CONFIG_NUMA case in mmzone.h
> (around line 1261), pfn_to_nid() calls page_to_nid(), possibly causing the
> same issue seen in v2?
>
No. If CONFIG_DEFERRED_STRUCT_PAGE_INIT=y, page_ext_init() is called after
page_alloc_init_late() where all the memory has already been initialized,
so page_to_nid() will work then.
next prev parent reply other threads:[~2018-12-20 21:04 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 22:31 kernel panic with page_owner=on Qian Cai
2018-12-19 1:57 ` [PATCH] mm: skip checking poison pattern for page_to_nid() Qian Cai
2018-12-19 10:20 ` Michal Hocko
2018-12-19 12:46 ` Qian Cai
2018-12-20 6:03 ` [PATCH] mm/page_owner: fix for deferred struct page init Qian Cai
2018-12-20 9:22 ` Michal Hocko
2018-12-20 18:50 ` [PATCH v2] " Qian Cai
2018-12-20 20:31 ` [PATCH v3] " Qian Cai
2018-12-20 21:00 ` William Kucharski
2018-12-20 21:04 ` Qian Cai [this message]
2018-12-20 21:04 ` Qian Cai
2019-01-03 11:51 ` Michal Hocko
2019-01-03 16:38 ` Qian Cai
2019-01-03 16:59 ` Michal Hocko
2019-01-03 17:38 ` Qian Cai
2019-01-03 19:07 ` Michal Hocko
2019-01-03 19:53 ` Qian Cai
2019-01-03 20:22 ` Michal Hocko
2019-01-03 22:22 ` Qian Cai
2019-01-04 13:09 ` Michal Hocko
2019-01-04 15:01 ` Qian Cai
2019-01-04 15:17 ` Michal Hocko
2019-01-04 15:25 ` Qian Cai
2019-01-04 15:32 ` Michal Hocko
2019-01-04 20:18 ` Qian Cai
2019-01-07 18:43 ` Michal Hocko
2019-01-08 1:53 ` Qian Cai
2019-01-08 8:20 ` Michal Hocko
2019-01-08 13:19 ` Qian Cai
2019-01-08 13:19 ` Qian Cai
2019-01-08 22:02 ` Andrew Morton
2019-01-08 22:13 ` Qian Cai
2019-01-08 22:40 ` Michal Hocko
2019-01-09 7:34 ` [PATCH v2] " Michal Hocko
2019-01-15 20:28 ` [PATCH] Revert "mm: use early_pfn_to_nid in page_ext_init" Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545339886.18411.31.camel@lca.pw \
--to=cai@lca.pw \
--cc=Pavel.Tatashin@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox