From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by kanga.kvack.org (Postfix) with ESMTP id 0AF8B8E00C9 for ; Tue, 11 Dec 2018 16:52:42 -0500 (EST) Received: by mail-qt1-f200.google.com with SMTP id j5so15907144qtk.11 for ; Tue, 11 Dec 2018 13:52:42 -0800 (PST) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id l11sor17299337qvr.48.2018.12.11.13.52.41 for (Google Transport Security); Tue, 11 Dec 2018 13:52:41 -0800 (PST) Message-ID: <1544565158.18411.5.camel@lca.pw> Subject: Re: [PATCH] arm64: increase stack size for KASAN_EXTRA From: Qian Cai Date: Tue, 11 Dec 2018 16:52:38 -0500 In-Reply-To: References: <721E7B42-2D55-4866-9C1A-3E8D64F33F9C@gmx.us> <20181207223449.38808-1-cai@lca.pw> <1544548707.18411.3.camel@lca.pw> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Arnd Bergmann Cc: Catalin Marinas , Will Deacon , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , kasan-dev , Linux-MM , Linux ARM , Linux Kernel Mailing List On Tue, 2018-12-11 at 22:43 +0100, Arnd Bergmann wrote: > On Tue, Dec 11, 2018 at 6:18 PM Qian Cai wrote: > > > > On Tue, 2018-12-11 at 13:42 +0100, Arnd Bergmann wrote: > > > On Fri, Dec 7, 2018 at 11:35 PM Qian Cai wrote: > > > > > > > > If the kernel is configured with KASAN_EXTRA, the stack size is > > > > increasted significantly due to enable this option will set > > > > -fstack-reuse to "none" in GCC [1]. As the results, it could trigger > > > > stack overrun quite often with 32k stack size compiled using GCC 8. For > > > > example, this reproducer > > > > > > > > size > > > > 7536 shrink_inactive_list > > > > 7440 shrink_page_list > > > > 6560 fscache_stats_show > > > > 3920 jbd2_journal_commit_transaction > > > > 3216 try_to_unmap_one > > > > 3072 migrate_page_move_mapping > > > > 3584 migrate_misplaced_transhuge_page > > > > 3920 ip_vs_lblcr_schedule > > > > 4304 lpfc_nvme_info_show > > > > 3888 lpfc_debugfs_nvmestat_data.constprop > > > > > > > > There are other 49 functions are over 2k in size while compiling kernel > > > > with "-Wframe-larger-than=" on this machine. Hence, it is too much work > > > > to change Makefiles for each object to compile without > > > > -fsanitize-address-use-after-scope individually. > > > > > > > > [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715#c23 > > > > > > Could you clarify: are the numbers you see with or without the bugfix > > > from that bugzilla? > > > > > > > The numbers were from GCC8 which does NOT contain this patch [1]. > > > > GCC9 is awesome which reduced the numbers in half even for KASAN_EXTRA. Only > > thing is that GCC9 has not been officially released yet, so it is a bit > > inconvenient for users need to compile the compiler by themselves first. > > > > I am fine either way to drop this patch or keep it until GCC9 is GA. > > > > [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715#c35 > > Maybe we can make the constant depend on the compiler version? I am not too keen to do the version-check considering some LTS versions could just back-port those patches and the render the version-check incorrectly. > It may also be possible to reduce the KASAN_THREAD_SHIFT > constant for the normal case with gcc-9 and go back to the > default frame size then.