From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
To: dan.j.williams@intel.com, pbonzini@redhat.com,
yi.z.zhang@linux.intel.com, brho@google.com, kvm@vger.kernel.org,
linux-nvdimm@lists.01.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
dave.jiang@intel.com, yu.c.zhang@intel.com, pagupta@redhat.com,
david@redhat.com, jack@suse.cz, hch@lst.de, rkrcmar@redhat.com,
jglisse@redhat.com
Subject: [PATCH RFC 3/3] kvm: Add additional check to determine if a page is refcounted
Date: Mon, 03 Dec 2018 11:25:36 -0800 [thread overview]
Message-ID: <154386513636.27193.9038916677163713072.stgit@ahduyck-desk1.amr.corp.intel.com> (raw)
In-Reply-To: <154386493754.27193.1300965403157243427.stgit@ahduyck-desk1.amr.corp.intel.com>
The function kvm_is_refcounted_page is used primarily to determine if KVM
is allowed to take a reference on the page. It was using the PG_reserved
flag to determine this previously, however in the case of DAX the page has
the PG_reserved flag set, but supports pinning by taking a reference on
the page. As such I have updated the check to add a special case for
ZONE_DEVICE pages that have the new support_refcount_pinning flag set.
Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
---
virt/kvm/kvm_main.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 5e666df5666d..2e7e9fbb67bf 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -148,8 +148,20 @@ __weak int kvm_arch_mmu_notifier_invalidate_range(struct kvm *kvm,
bool kvm_is_refcounted_pfn(kvm_pfn_t pfn)
{
- if (pfn_valid(pfn))
- return !PageReserved(pfn_to_page(pfn));
+ if (pfn_valid(pfn)) {
+ struct page *page = pfn_to_page(pfn);
+
+ /*
+ * The reference count for MMIO pages are not updated.
+ * Previously this was being tested for with just the
+ * PageReserved check, however now ZONE_DEVICE pages may
+ * also allow for the refcount to be updated for the sake
+ * of pinning the pages so use the additional check provided
+ * to determine if the reference count on the page can be
+ * used to pin it.
+ */
+ return !PageReserved(page) || is_device_pinnable_page(page);
+ }
return false;
}
next prev parent reply other threads:[~2018-12-03 19:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 19:25 [PATCH RFC 0/3] Fix KVM misinterpreting Reserved page as an MMIO page Alexander Duyck
2018-12-03 19:25 ` [PATCH RFC 1/3] kvm: Split use cases for kvm_is_reserved_pfn to kvm_is_refcounted_pfn Alexander Duyck
2018-12-03 19:25 ` [PATCH RFC 2/3] mm: Add support for exposing if dev_pagemap supports refcount pinning Alexander Duyck
2018-12-03 19:47 ` Dan Williams
2018-12-03 20:21 ` Alexander Duyck
2018-12-03 20:31 ` Dan Williams
2018-12-03 20:53 ` Alexander Duyck
2018-12-03 21:05 ` Dan Williams
2018-12-03 21:50 ` Alexander Duyck
2018-12-04 19:08 ` Dan Williams
2018-12-04 22:51 ` Alexander Duyck
2018-12-04 23:24 ` Barret Rhoden
2018-12-05 0:01 ` Alexander Duyck
2018-12-05 0:26 ` Dan Williams
2018-12-05 8:13 ` David Hildenbrand
2018-12-03 19:25 ` Alexander Duyck [this message]
2018-12-04 6:59 ` [PATCH RFC 0/3] Fix KVM misinterpreting Reserved page as an MMIO page Yi Zhang
2018-12-04 18:45 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154386513636.27193.9038916677163713072.stgit@ahduyck-desk1.amr.corp.intel.com \
--to=alexander.h.duyck@linux.intel.com \
--cc=brho@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=yi.z.zhang@linux.intel.com \
--cc=yu.c.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox