From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A332BC5479D for ; Mon, 9 Jan 2023 20:02:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21F488E0002; Mon, 9 Jan 2023 15:02:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D0278E0001; Mon, 9 Jan 2023 15:02:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 048D48E0002; Mon, 9 Jan 2023 15:02:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E65428E0001 for ; Mon, 9 Jan 2023 15:02:11 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AFFFC80C34 for ; Mon, 9 Jan 2023 20:02:11 +0000 (UTC) X-FDA: 80336332062.23.75DB58C Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2079.outbound.protection.outlook.com [40.107.102.79]) by imf23.hostedemail.com (Postfix) with ESMTP id 2C5B9140018 for ; Mon, 9 Jan 2023 20:02:06 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=GKPjc7oi; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf23.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.102.79 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673294527; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eua6IuiQN9ebrh7DxAte4XVPL1CdeGvpKwPACydzqkk=; b=jYfr27U0xwpoPglUekM2egzQOSg+/TGLcTidUxN5Npv+lZtrPt5ry8p+cF3NT0JFa1g2Bo N8+n++5WkURMwMHRaMkQ+Vv4X+4zUqhSF0qLbFULrcV5/WCE3KSVI93XyGmFkJD2yQO89K cCEMTp3iloQjrarC4opQWgGrPXIKs0w= ARC-Authentication-Results: i=2; imf23.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=GKPjc7oi; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf23.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.102.79 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1673294527; a=rsa-sha256; cv=pass; b=mPyfTOuL2p/A3E62AtpVZqnvVddm1LaFmTvEwes/LPuZxVmDhnj8nc1WpUkro7bOHFaHDb gV2n3z63vhdt+/50WaEiNmXHVM6v3QmvoDq/Z56P61OTCZruDH2f/p31qBayESv0282lYV WHCE1ruRlIlkHCqVc13l/gxGJ4R0GG4= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=luB2wgl2VPk1+uJ1Dp1N/QirJALcy6WrkOTiix/5aFM2l49ZPnTYe2TpdxxfqEEnVRSMWScNHhE6YQhPP3a7WZuZp11BVpRg+Ky54L9raorVLLqJgIBh0xnm7R2cMFFVsSGlVhN43qBsKJ+cifhOHqikEAAV0+VbQmzY32lhPgJfU90eYoFw2UvD0E7XUNNu8TWhSVWDw7lK7K55s7sLIeNTmGUhltleQFWHpxFOlWuzyr1ESW9qjxeOI2HEOQfmjTgXc2/xRFhM7hAqzVRljvSON4szh3bn0IjazQNTb2PrWVgCEycH2tuYqZayAL6imEhEW5vjnE/1mB4Dbmvp5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eua6IuiQN9ebrh7DxAte4XVPL1CdeGvpKwPACydzqkk=; b=WDzo3nGa7rv7ZN6+R3o7gLbaDi88YPiqwooG9S8sGj+eMsKPhPxMp5m2zrTBur1h5q+BcgdUyAkalA2KWCLvSCtM4HbWOooGjunKfCDsx6g0ixZLNubxxKlLAg4FCbd3CeN3mKcKtpJLoGio73rR03Jazyt8cGUt5qDQ0Qb7QcVX3aZkYgYLzCs3jgdPvxoDrBO6Se1k2vhpFi+TYYXlze5I3d6byhlPYfvG3hiDmrEADtykOUSOEMOkPDfZ4HlzsM0CwInH23FYzCRMSOLBqUn/I1xqlX57PeW4vSOPn/kciLS8f/XSEITAo/t2A6cQjAuug2UiTFqK2vS7hPNRVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=oracle.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eua6IuiQN9ebrh7DxAte4XVPL1CdeGvpKwPACydzqkk=; b=GKPjc7oiFNF0g4CiTKsk+V4EnH68ad6JR0IeQvFBwVGqZhXbT+WbvxqIR73loLwDnLSiZVIGiwefVWbcoU8EecXQM70rl8ELWnqUKDyBgVTUlwPC6cEfy0Yna7BC2Gnh1/+bpNP/LTuhDk/EZQZhhL1cLbipftLdUJpzuZb7R0E+//vaEh9uxXFL++6zcGTCI6eJ1fjnIZSZUXJPMzkRUWUX2HR++elMkE+xuysmvvtUozP9p4SmlQewfO/wv7cSXsASzEFTS2F+ZFjl8aCytx1T481xfEwr3uNHE2NuTzQWI3p0qeQf7DL9kldov2tPVrncPkmOCSHJ6oaBFoPVGw== Received: from MW4PR03CA0235.namprd03.prod.outlook.com (2603:10b6:303:b9::30) by SA3PR12MB8439.namprd12.prod.outlook.com (2603:10b6:806:2f7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 20:02:04 +0000 Received: from CO1NAM11FT052.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b9:cafe::14) by MW4PR03CA0235.outlook.office365.com (2603:10b6:303:b9::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 20:02:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT052.mail.protection.outlook.com (10.13.174.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 20:02:03 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 9 Jan 2023 12:01:46 -0800 Received: from [10.110.48.28] (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 9 Jan 2023 12:01:46 -0800 Message-ID: <153c451a-029f-ef03-7a57-7ff0394ac3d8@nvidia.com> Date: Mon, 9 Jan 2023 12:01:45 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH mm-unstable 8/8] mm/hugetlb: convert demote_free_huge_page to folios To: Mike Kravetz , Sidhartha Kumar CC: Matthew Wilcox , , , , , References: <20230103191340.116536-1-sidhartha.kumar@oracle.com> <20230103191340.116536-9-sidhartha.kumar@oracle.com> <0b711878-71b0-4a4b-4f0b-af157d6cac42@oracle.com> Content-Language: en-US From: John Hubbard In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT052:EE_|SA3PR12MB8439:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b21ad05-c5e7-4224-173c-08daf27c6076 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6R57fEAWkPh8sJoCKUm9M6NEplX/8Il4ZBnDdkgJktE17qvBOUwn+TvWC9BrbubNOuXHes361R2BTxa519PyAoIxz2CumNNg6XB8XlEPKz1FqEKZtWNMv1JHxM3P2M24UOAh6oAOSH9TfzyZMiocFZ81lRSpdIz7nFBmrrjOOFCJEeFGLVJIKn4+qY+2oEJzOj2A9eJ+NW86akI2cirKgNxhRDbZPRT8sIdEQVnRT8dwQio3R2H/cqUCxS2N3341L7BZO3b1DKp38B2fIvseGZS2lom4lMNK/mfNMo0TLXDYnTi4/hz/bVwb1bDf4929u/sjpF0Q3bepvi+ZdyDlOlDvBwDEvkEdd6TN7cE6qpub4yKa1McbLYQ40QPCq/rSJWuDFkJvJqPduEOOeInacEAUnHVx0T4hFsJsiKvOMmW4FgaKcYrNrxpSr0yfMVv7lYii+Xycr1ffPAhjddZwMH5yMOP1tNBgx1DVLa0Tp8qirrYXmlqys/sR7TV3wQVldugtNtoAgO3JI1gC3Vyis07/gX+RsV+tNNu+/fh2gCgBrgiVs8Un+H0FO57f5g/aJhOZuay7fsC7mmgdGEJ2I4hYPs5YtHjqvQrJobfsgF1q2aEkc0lfS6SJnam4aUgNM4uq72iv50HzOm1qJDJhoD1chr+eIVWD3qqxMm/igD1pbePWPdmykYTsFXnEU/BPaL3oJb9QwfyEldEdZCfVCvyhc8pImqBHK7CXi7VLtwr2ToGDi8A7votcE5Y7hz+CG2jbE+H7MBO2KWH8/1BzIQ== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(39860400002)(376002)(346002)(451199015)(40470700004)(36840700001)(46966006)(31686004)(2906002)(5660300002)(8936002)(53546011)(186003)(16526019)(36860700001)(31696002)(40460700003)(41300700001)(36756003)(26005)(40480700001)(356005)(4326008)(70586007)(8676002)(70206006)(86362001)(7636003)(82740400003)(2616005)(83380400001)(478600001)(336012)(316002)(16576012)(110136005)(426003)(47076005)(82310400005)(54906003)(14583001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 20:02:03.3627 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b21ad05-c5e7-4224-173c-08daf27c6076 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT052.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB8439 X-Rspamd-Queue-Id: 2C5B9140018 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: ny8bzr9ffuzm7ocbiwhshnp6xrypiofc X-HE-Tag: 1673294526-443591 X-HE-Meta: U2FsdGVkX1+SmiqzfkBA8Lx4v07XiF8Q4G1lDfYDCz3nPKmOuJDwysLzyWTPpVj6If7mjuezqFw46aElExaSf11iggYdqvV0nlsB2+StwkH3mayr/CwhTv3pqVjPZ0TauGfYwEdHkDzQewYFBCc5rd3v61vXSIRdf9PZXA/b67DvieGXn5AMuHmgtHnb0A5Ft0ZVrgIbxU/xL+dOZ8EQvN824T09DcpaJRHYfYYDt0stqIcvvHemJJsuqVBhxLyJZCks1UwbmAj7WOQ5tLrG8Xm+WNocjyliGC2yOY48uzpGhJzroZI8VVTmSlV/I2xLKgCQ8ajHsBf4QY+Z655B6TMHKoK1nZowlaQrEcTqbKhTk4Ye0lbveHR0ZIvmRu3guZOhCf86xkCa/UghB97KM/tvVv3bLlpj1ridu2J5lg92FezKMCl50TtmjJrOBt21SYMnew3sCU9do0fo7BkcLt8EolZc02mFWd+VPlzFnGe/o+gGWIBH7zmj+9L+41o5gOkdtPr3A62X5whg6cuV9lP882oAR5bZj22dpK+4n7tIsTUDleSnYB4bgv9wJZJ+z4aDlsHe45/GIx2lE6DF/09zF76luJiGauU1zoIRgOmFP2Q3qn4qeOkyT99q5XJmKb8uqKdT7fjLNm2qH0cXoTjRWX1DKb74+qhYC8SdIyro2Ywfw14O4jARXvNaMJKjsBKpj6tOiz6yqRac3DZeWqFSXcgC8deXI0IHfzU8YZ7fMmCV0k0SxFHDj7C9HWMv/Wso/OQl62LjjhRtsNas8BHQXxxwes6HZz1iwnQ6s5A1ZFdUQyuT/rsKC7D74uNgXkvZgVKZlpak5LDIvAdoeP83zL22vuSwmFYpcgIlwIU8l/IMUG8wbxIjpSrsQSO+G3bNnczmgZZ0xZnqlNb4A59Ea5hbM90LY3TvbiJZq2tFjiM4tcB1oPsWNQVh46b8sT3SZP+SsUc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/9/23 10:23, Mike Kravetz wrote: >>>>> No problems with the code, but I am not in love with the name subfolio. >>>>> I know it is patterned after 'subpage'. For better or worse, the term >>>>> subpage is used throughout the kernel. This would be the first usage of >>>>> the term 'subfolio'. >>>>> >>>>> Matthew do you have any comments on the naming? It is local to hugetlb, >>>>> but I would hate to see use of the term subfolio based on its introduction >>>>> here. >>>> >>>> I'm really not a fan of it either. I intended to dive into this patch >>>> and understand the function it's modifying, in the hopes of suggesting >>>> a better name and/or method. >>> >>> At a high level, this routine is splitting a very large folio (1G for >>> example) into multiple large folios of a smaller size (512 2M folios for >>> example). The loop is iterating through the very large folio at >>> increments of the smaller large folio. subfolio (previously subpage) is >>> used to point to the smaller large folio within the loop. >>> >> If folio does not need to be part of the variable name, how about something >> like 'demote_target'? The prep call inside the loop would then look like: >> >> prep_new_hugetlb_folio(target_hstate, demote_target, nid); >> >> so it is still clear that demote_target is a folio. A more concise version >> could also be 'demote_dst' but that seems more ambiguous than target. > > I am OK with that naming. Primary concern was the introduction of the > term subfolio. How about one of these: smaller_folio inner_folio Those are more self-explanatory, while still avoiding "subfolio". thanks, -- John Hubbard NVIDIA