From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20A26C7115C for ; Fri, 20 Jun 2025 15:34:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAE9C6B007B; Fri, 20 Jun 2025 11:34:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B86686B0098; Fri, 20 Jun 2025 11:34:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A75566B009E; Fri, 20 Jun 2025 11:34:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 987976B007B for ; Fri, 20 Jun 2025 11:34:03 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5F7101A0D78 for ; Fri, 20 Jun 2025 15:34:03 +0000 (UTC) X-FDA: 83576174766.29.C81352D Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by imf07.hostedemail.com (Postfix) with ESMTP id ADDCA40008 for ; Fri, 20 Jun 2025 15:34:00 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nqyiARFa; spf=pass (imf07.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.13 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750433640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bSzfXqRjJzCY7kNkSKLRg4EqVcLjR79GrU9m54Alyk8=; b=hu30ObjIkAKeO0OdKAq5C/bzJ7Qp7u4FspVp6DsdXVqy5/2lJhSFRTP36IL+A6ZMtqPKv+ Iby/VvgWYhm20kgzt6W9G/RvvfX4k01UCfdZM6pfKIQu5Cm+paz1iOmmKsFnYMAfdaXGvY 1qoy7zUnTAmNjjWueNp6xzr3/jr8h1o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750433641; a=rsa-sha256; cv=none; b=SGL8upAqiVClvHBulomuCc4/QpZhZuJOYPWIIJ93JVMKB+sIhf7p4OacxbJKWuQ68gk+J6 sOSX7ViRA1gJZbwls8eXjfThyTgZKlMrppwqLrJtS1D+oqlDZO9gXXOURK8deMLVWjZnhL wy+2A3Jq3bgRFoZp3cdZFzXLlVubYbI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nqyiARFa; spf=pass (imf07.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.13 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750433640; x=1781969640; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Bo5R8XrrGgmfF8KfOIvrit9oecdow83nPJ5PYV6L3ik=; b=nqyiARFaLyNBnoxEe1eIpwae2LK7tnEIT3cRsEPEbmEXZ2w/P+GIIfdr piscVXQtEcaCAg1J9OJ+l47yoH7oXyo6zQwjk9sxC/BWeElT58pZMdNgK sOZub8SGYpta7zI1mT/3iLLpgO+hoNG90cSJUty/uXRrV+y5NHsDT7VJs 3VyGnHn0ysVQkaM8rlE6IvrJrvDsn5yGYIkZJxWlIJf8xLHU/zDEmZoz+ ZVUXmQbiIBmmv0rYb7ftaLvS1uQ/u1gOlJU8R+cwrV8JVoMOaCKIeuKOg Sbwe6gZ4pcUw0rtqOeSFK593OppWVTZ8EmkiCrc7t0jK+rTrIWQ7N46Fa w==; X-CSE-ConnectionGUID: TOD8T5BHRP6hMZ/tSyL5vw== X-CSE-MsgGUID: fu1yAVvpRiGvq/jEIrf5Mw== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="55335353" X-IronPort-AV: E=Sophos;i="6.16,251,1744095600"; d="scan'208";a="55335353" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2025 08:33:59 -0700 X-CSE-ConnectionGUID: VxEFVi4JQL6me5azSpTp3Q== X-CSE-MsgGUID: cRL62tvsRneZWDk6CFi8xg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,251,1744095600"; d="scan'208";a="151155458" Received: from aschofie-mobl2.amr.corp.intel.com (HELO [10.125.108.136]) ([10.125.108.136]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2025 08:33:58 -0700 Message-ID: <15335559-bbb2-4da1-bbb9-878edf05437c@intel.com> Date: Fri, 20 Jun 2025 08:33:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv6 03/16] x86/alternatives: Disable LASS when patching kernel alternatives To: "Kirill A. Shutemov" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Ard Biesheuvel , "Paul E. McKenney" , Josh Poimboeuf , Xiongwei Song , Xin Li , "Mike Rapoport (IBM)" , Brijesh Singh , Michael Roth , Tony Luck , Alexey Kardashevskiy , Alexander Shishkin Cc: Jonathan Corbet , Sohil Mehta , Ingo Molnar , Pawan Gupta , Daniel Sneddon , Kai Huang , Sandipan Das , Breno Leitao , Rick Edgecombe , Alexei Starovoitov , Hou Tao , Juergen Gross , Vegard Nossum , Kees Cook , Eric Biggers , Jason Gunthorpe , "Masami Hiramatsu (Google)" , Andrew Morton , Luis Chamberlain , Yuntao Wang , Rasmus Villemoes , Christophe Leroy , Tejun Heo , Changbin Du , Huang Shijie , Geert Uytterhoeven , Namhyung Kim , Arnaldo Carvalho de Melo , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org References: <20250620135325.3300848-1-kirill.shutemov@linux.intel.com> <20250620135325.3300848-4-kirill.shutemov@linux.intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250620135325.3300848-4-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: ADDCA40008 X-Stat-Signature: 381uikc18fjsb4r1sc331c8dspz4scky X-Rspam-User: X-HE-Tag: 1750433640-310872 X-HE-Meta: U2FsdGVkX19be6tjuH0Mzf6mhYuM1OBIuyDIsLGR1ZtK05dSo90QrDHEz6TUeM9nwVOMPmIS+kwjwdss650IQKdE7yhf5CaA3iO2Yt5x4vdzTKuTTpedlcbMvW+XvN6BpYb9K3n+Ev6b+ifufOdjqK/yHnbDz5V/b6j0CUrpTBXY8yPBLa1GnpL4C430h9cbbLXVj9R306A8Hw5sUq3DsvnhQVgJjAIhLdyjwJCyBkiQvW59CN/chBGd+IJLl5Rot6aOcwlW8z6PsMAIDSdJSwa1dpwhoIMJA0TTPq4xXcV8j7Ibzo7E06zgueySTmu3w48WR5WCnFaSbvp+y+g3Am2toYO2IahR3Zgj4UL+q8h3ZN7gO9rZOAQqRsZUi4c+X+8sXK1etywO5EfV///2z0jhh9E8fa0ofWJHaapXts6OHUEwGhQKBaL4PpFhf5rAZl/F/bbvfTmGPkAmDVlRKK5sLrBbrc7gZzInR/O7jlr/mv19iRZHxF6nKeOyVSV5lHaGUKXcc4zH0DoYUvcmiTgF/6/+CixdtHiM/lavyYsIEp4w4ZnvMgINhjxdxp4k73cr0AjSdLyBke5Lyp4t1ffDvK0GTp94RzplteL4htIdmXboyX9CNxkYtAoB/TvM167Z2KGaFF/kTxVAcyktNfaIG3rctUNKdBBPPkgXT8NeiJfg/UOqHgbJ+DSyzBOKRRmOjHKvbpj6dVRpF36xhCofsNone2PADaGsC52QgcX8hI8+eVbJdGffjHb+LN+40LuAK6TKz+LSbGS9KRV5wswR028Zps5SF7g9EkDJGG75iLoTl2wFfPQ1lI/qzNc0+7iDFQSkAW708fbNGWKwZlJs7wqnS1ocViGpGL0A2UfTF2P5TyQO5JEEAKhmAnmGXCW2XKigcrbZ5nKcvplNzKRJe0G1KCaYf8cjh6kHZF+sBwF+tChwhUMIjKDwWyqqjSb4iJ/OSDlk+laPxAX CbpawqFO YKQLJ+tFIfJyNtHHczJm+6uTuJchT68EZ5mxEHEHKdT5E/OPp2j+gsLQ9U427HSCsFSWmd7xWJdqvu1WNX00Lb/6+dAeuK3W8n4c39wvya+dyssgsYT3iN6eXoN42iFJC1jNP7QG4wALlJQFIdAKasWLkDRL11mfifidOMvU6fmHJQEsZubT9QN7Q3IF31I3w81xy5UvvvjxU//zDO/4ALtut9Qafr9sa/g8zrUxWkGWCHUIcjvZpReCrH1sh+o3QyTtWh+bW/zhiRGZlJWfNGJp9k3R2ujAe6y15 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/20/25 06:53, Kirill A. Shutemov wrote: > +/* > + * poking_init() initializes the text poking address from the lower half of the > + * address space. Relax LASS enforcement when accessing the poking address. > + */ This does not read quite right. I think there's some unnecessary confusiuon about initializing the address versus the contents. But either way, how about: /* * Text poking creates and uses a mapping in the lower half of the * address space. Relax LASS enforcement when accessing the poking * address. */ > static void text_poke_memset(void *dst, const void *src, size_t len) > { > int c = *(const int *)src; > > - memset(dst, c, len); > + lass_stac(); > + __inline_memset(dst, c, len); > + lass_clac(); > } Yeah, this patch small enough that lass_{stac,clac}() are definitely misplaced in this series. Just move them into this patch.