From: Joerg Roedel <joro@8bytes.org>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>,
Dave Hansen <dave.hansen@intel.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Juergen Gross <jgross@suse.com>,
Peter Zijlstra <peterz@infradead.org>,
Borislav Petkov <bp@alien8.de>, Jiri Kosina <jkosina@suse.cz>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Brian Gerst <brgerst@gmail.com>,
David Laight <David.Laight@aculab.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Eduardo Valentin <eduval@amazon.com>,
Greg KH <gregkh@linuxfoundation.org>,
Will Deacon <will.deacon@arm.com>,
aliguori@amazon.com, daniel.gruss@iaik.tugraz.at,
hughd@google.com, keescook@google.com,
Andrea Arcangeli <aarcange@redhat.com>,
Waiman Long <llong@redhat.com>, Pavel Machek <pavel@ucw.cz>,
"David H . Gutteridge" <dhgutteridge@sympatico.ca>,
jroedel@suse.de, Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
joro@8bytes.org
Subject: [PATCH 0/3] PTI for x86-32 Fixes and Updates
Date: Fri, 20 Jul 2018 18:22:21 +0200 [thread overview]
Message-ID: <1532103744-31902-1-git-send-email-joro@8bytes.org> (raw)
Hi,
here are 3 patches which update the PTI-x86-32 patches recently merged
into the tip-tree. The patches are ordered by importance:
Patch 1: Very important, it fixes a vmalloc-fault in NMI context
when PTI is enabled. This is pretty unlikely to hit
when starting perf on an idle machine, which is why I
didn't find it earlier in my testing. I always started
'perf top' first :/ But when I start 'perf top' last
when the kernel-compile already runs, it hits almost
immediatly.
Patch 2: Fix the 'from-kernel-check' in SWITCH_TO_KERNEL_STACK
to also take VM86 into account. This is not strictly
necessary because the slow-path also works for VM86
mode but it is not how the code was intended to work.
And it breaks when Patch 3 is applied on-top.
Patch 3: Implement the reduced copying in the paranoid
entry/exit path as suggested by Andy Lutomirski while
reviewing version 7 of the original patches.
I have the x86/tip branch with these patches on-top running my test for
6h now, with no issues so far. So for now it looks like there are no
scheduling points or irq-enabled sections reached from the paranoid
entry/exit paths and we always return to the entry-stack we came from.
I keep the test running over the weekend at least.
Please review.
[ If Patch 1 looks good to the maintainers I suggest applying it soon,
before too many linux-next testers run into this issue. It is actually
the reason why I send out the patches _now_ and didn't wait until next
week when the other two patches got more testing from my side. ]
Thanks,
Joerg
Joerg Roedel (3):
perf/core: Make sure the ring-buffer is mapped in all page-tables
x86/entry/32: Check for VM86 mode in slow-path check
x86/entry/32: Copy only ptregs on paranoid entry/exit path
arch/x86/entry/entry_32.S | 82 ++++++++++++++++++++++++++-------------------
kernel/events/ring_buffer.c | 10 ++++++
2 files changed, 58 insertions(+), 34 deletions(-)
--
2.7.4
next reply other threads:[~2018-07-20 16:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 16:22 Joerg Roedel [this message]
2018-07-20 16:22 ` [PATCH 1/3] perf/core: Make sure the ring-buffer is mapped in all page-tables Joerg Roedel
2018-07-20 17:06 ` Andy Lutomirski
2018-07-20 17:48 ` Joerg Roedel
2018-07-20 19:32 ` Andy Lutomirski
2018-07-20 21:37 ` Joerg Roedel
2018-07-20 22:20 ` Andy Lutomirski
2018-07-21 21:06 ` Linus Torvalds
2018-07-20 19:27 ` Thomas Gleixner
2018-07-20 19:33 ` Andy Lutomirski
2018-07-20 19:43 ` Thomas Gleixner
2018-07-20 19:53 ` Thomas Gleixner
2018-07-20 16:22 ` [PATCH 2/3] x86/entry/32: Check for VM86 mode in slow-path check Joerg Roedel
2018-07-21 16:06 ` Pavel Machek
2018-07-20 16:22 ` [PATCH 3/3] x86/entry/32: Copy only ptregs on paranoid entry/exit path Joerg Roedel
2018-07-20 17:09 ` Andy Lutomirski
2018-07-20 21:42 ` Joerg Roedel
2018-07-23 3:49 ` [PATCH 0/3] PTI for x86-32 Fixes and Updates David H. Gutteridge
2018-07-23 7:29 ` Joerg Roedel
2018-07-26 3:47 ` David H. Gutteridge
2018-07-23 14:09 ` Pavel Machek
2018-07-23 19:00 ` Linus Torvalds
2018-07-23 21:38 ` Pavel Machek
2018-07-23 21:50 ` Andy Lutomirski
2018-07-23 21:55 ` Pavel Machek
2018-07-24 21:18 ` Pavel Machek
2018-07-23 21:59 ` Josh Poimboeuf
2018-07-23 22:07 ` Dave Hansen
2018-07-24 13:39 ` Pavel Machek
2018-07-24 14:39 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532103744-31902-1-git-send-email-joro@8bytes.org \
--to=joro@8bytes.org \
--cc=David.Laight@aculab.com \
--cc=aarcange@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=aliguori@amazon.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=daniel.gruss@iaik.tugraz.at \
--cc=dave.hansen@intel.com \
--cc=dhgutteridge@sympatico.ca \
--cc=dvlasenk@redhat.com \
--cc=eduval@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=hughd@google.com \
--cc=jgross@suse.com \
--cc=jkosina@suse.cz \
--cc=jolsa@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=jroedel@suse.de \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llong@redhat.com \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox