From: Benjamin Peterson <bp@benjamin.pe>
To: linux-mm@kvack.org
Subject: balance_dirty_pages ratelimiting
Date: Sun, 20 May 2018 22:53:55 -0700 [thread overview]
Message-ID: <1526882035.2651626.1378964120.19800D70@webmail.messagingengine.com> (raw)
The comment for balance_dirty_pages_ratelimited explains rate limiting is necessary because "On really big machines, get_writeback_state is expensive". This comment is stale, since get_writeback_state has not existed for more than 10 years. I gather, however, that its expense arose from aggregating vmstats over all cpus. These days, global vmstats are simply a memory load. Is there a modern reason for rate limiting balance_dirty_pages?
Thanks,
Benjamin
reply other threads:[~2018-05-21 5:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526882035.2651626.1378964120.19800D70@webmail.messagingengine.com \
--to=bp@benjamin.pe \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox