linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [mmotm:master 121/157] arch/powerpc/kernel/module_64.c:463: undefined reference to `.elf64_apply_relocate_add'
@ 2016-10-15 15:14 kbuild test robot
  2016-10-18 23:09 ` Thiago Jung Bauermann
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2016-10-15 15:14 UTC (permalink / raw)
  To: Thiago Jung Bauermann
  Cc: kbuild-all, Johannes Weiner, Andrew Morton, Linux Memory Management List

[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   fe4cd888f71ef173e0e5a0f9dccc42904c0107f3
commit: bfc91c122c791863922ddfcbfef5e0028fde908c [121/157] powerpc: factor out relocation code from module_64.c to elf_util_64.c
config: powerpc-ps3_defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout bfc91c122c791863922ddfcbfef5e0028fde908c
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   arch/powerpc/kernel/built-in.o: In function `apply_relocate_add':
>> arch/powerpc/kernel/module_64.c:463: undefined reference to `.elf64_apply_relocate_add'

vim +463 arch/powerpc/kernel/module_64.c

   457			 * .TOC. so don't fail it just for that. */
   458			if (sym)
   459				sym->st_value = my_r2(&me->arch.elf_info);
   460			me->arch.toc_fixed = true;
   461		}
   462	
 > 463		return elf64_apply_relocate_add(&me->arch.elf_info, strtab, symindex,
   464						relsec, me->name);
   465	}
   466	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 14210 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [mmotm:master 121/157] arch/powerpc/kernel/module_64.c:463: undefined reference to `.elf64_apply_relocate_add'
  2016-10-15 15:14 [mmotm:master 121/157] arch/powerpc/kernel/module_64.c:463: undefined reference to `.elf64_apply_relocate_add' kbuild test robot
@ 2016-10-18 23:09 ` Thiago Jung Bauermann
  0 siblings, 0 replies; 2+ messages in thread
From: Thiago Jung Bauermann @ 2016-10-18 23:09 UTC (permalink / raw)
  To: kbuild test robot
  Cc: kbuild-all, Johannes Weiner, Andrew Morton, Linux Memory Management List

Am Samstag, 15. Oktober 2016, 23:14:20 BRST schrieb kbuild test robot:
>    arch/powerpc/kernel/built-in.o: In function `apply_relocate_add':
> >> arch/powerpc/kernel/module_64.c:463: undefined reference to
> >> `.elf64_apply_relocate_add'

This is because my kexec_file_load patches lost a few hunks.
The patch below fixes the issue.

Many of the problems with this patch series stem from the fact that it 
conflicted with the s/CONFIG_WORD_SIZE/BITS/ change that went into v4.9-rc1.
I will post a new version rebased on top of v4.9-rc1, this should get things 
back on track. I'll have them ready by tomorrow.

Thank you for your patience.

diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile
index 3bf8dc6ccf7d..6ff8927a8a05 100644
--- a/arch/powerpc/kernel/Makefile
+++ b/arch/powerpc/kernel/Makefile
@@ -108,8 +108,14 @@ pci64-$(CONFIG_PPC64)		+= pci_dn.o pci-hotplug.o isa-bridge.o
 obj-$(CONFIG_PCI)		+= pci_$(BITS).o $(pci64-y) \
 				   pci-common.o pci_of_scan.o
 obj-$(CONFIG_PCI_MSI)		+= msi.o
-obj-$(CONFIG_KEXEC)		+= machine_kexec.o crash.o \
+obj-$(CONFIG_KEXEC_CORE)	+= machine_kexec.o crash.o \
 				   machine_kexec_$(BITS).o
+obj-$(CONFIG_KEXEC_FILE)	+= kexec_elf_$(BITS).o
+
+ifeq ($(CONFIG_HAVE_IMA_KEXEC)$(CONFIG_IMA),yy)
+obj-y				+= ima_kexec.o
+endif
+
 obj-$(CONFIG_AUDIT)		+= audit.o
 obj64-$(CONFIG_AUDIT)		+= compat_audit.o
 
@@ -125,7 +131,7 @@ obj-y				+= iomap.o
 endif
 
 ifneq ($(CONFIG_MODULES)$(CONFIG_KEXEC_FILE),)
-ifeq ($(CONFIG_WORD_SIZE),64)
+ifeq ($(BITS),64)
 obj-y				+= elf_util.o elf_util_64.o
 endif
 endif
diff --git a/arch/powerpc/kernel/machine_kexec_64.c b/arch/powerpc/kernel/machine_kexec_64.c
index 8dbaf636c95e..86322f765b58 100644
--- a/arch/powerpc/kernel/machine_kexec_64.c
+++ b/arch/powerpc/kernel/machine_kexec_64.c
@@ -33,6 +33,16 @@
 #include <asm/smp.h>
 #include <asm/hw_breakpoint.h>
 #include <asm/asm-prototypes.h>
+#include <asm/kexec_elf_64.h>
+#include <asm/ima.h>
+
+#define SLAVE_CODE_SIZE		256
+
+#ifdef CONFIG_KEXEC_FILE
+static struct kexec_file_ops *kexec_file_loaders[] = {
+	&kexec_elf64_ops,
+};
+#endif
 
 int default_machine_kexec_prepare(struct kimage *image)
 {


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-18 23:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-15 15:14 [mmotm:master 121/157] arch/powerpc/kernel/module_64.c:463: undefined reference to `.elf64_apply_relocate_add' kbuild test robot
2016-10-18 23:09 ` Thiago Jung Bauermann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox