From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CE16C47083 for ; Wed, 2 Jun 2021 14:15:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C50C2613EA for ; Wed, 2 Jun 2021 14:15:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C50C2613EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 571B08E0039; Wed, 2 Jun 2021 10:15:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FA8A8E0035; Wed, 2 Jun 2021 10:15:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 338D78E0039; Wed, 2 Jun 2021 10:15:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218]) by kanga.kvack.org (Postfix) with ESMTP id EF3BD8E0035 for ; Wed, 2 Jun 2021 10:15:18 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 98103AF6A for ; Wed, 2 Jun 2021 14:15:18 +0000 (UTC) X-FDA: 78208981116.11.BC852DF Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by imf03.hostedemail.com (Postfix) with ESMTP id DFB25C00F792 for ; Wed, 2 Jun 2021 14:15:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 678EE302DAA; Wed, 2 Jun 2021 10:15:17 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 8RvjTnc1vjOW; Wed, 2 Jun 2021 10:15:17 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 9F3AF302B63; Wed, 2 Jun 2021 10:15:16 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 9F3AF302B63 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1622643316; bh=wTS/crR/26N4BDTiNFNNZoqsETfUenagK9Jc/umukAM=; h=Date:From:To:Message-ID:MIME-Version; b=HjuuxeCx/W0ucWdgkdPe4Ltmueov6LEz9QoWVQ9n275sUH5V2BfBx2uLemee8nOgV iEPOUdYsPm3Mmmkxyd2M/xe2NzuiK0lte25kNJqF/D6aBdMudEsd6+/AvYnVI3XvQB I3eKlxdMnA/4sIrtiEyziYHBHFsURA8x1tU1usHbZhQ+Nqw4zpB4HKNzuSQ6QLswXS 8VevSWMXfGVlYdJrwg5WBPwEe4w0fAdx0pE768+FRtKKL3etA75RfRjkypdxFoVZY5 KUm3EJy+oFxv1WaIjL0MV00CLSuspl8VcSBxV1CpXr+Or5zRpRWJvt+/OT6gN/Sqjt hvtczOpS4cKPQ== X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id INsgB7HWhvRx; Wed, 2 Jun 2021 10:15:16 -0400 (EDT) Received: from mail03.efficios.com (mail03.efficios.com [167.114.26.124]) by mail.efficios.com (Postfix) with ESMTP id 702A6302A65; Wed, 2 Jun 2021 10:15:16 -0400 (EDT) Date: Wed, 2 Jun 2021 10:15:16 -0400 (EDT) From: Mathieu Desnoyers To: Peter Zijlstra Cc: Thomas Gleixner , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , rostedt , Ben Segall , Mel Gorman , bristot , Borislav Petkov , x86 , "H. Peter Anvin" , Jens Axboe , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, "David S. Miller" , Jakub Kicinski , Felipe Balbi , Greg Kroah-Hartman , Alexander Viro , Tejun Heo , Zefan Li , Johannes Weiner , Jason Wessel , Daniel Thompson , Douglas Anderson , acme , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "Rafael J. Wysocki" , Pavel Machek , Will Deacon , Waiman Long , Boqun Feng , Oleg Nesterov , Davidlohr Bueso , paulmck , Josh Triplett , Lai Jiangshan , "Joel Fernandes, Google" , John Stultz , Stephen Boyd , Andrew Morton , Paolo Bonzini , linux-kernel , linux-block@vger.kernel.org, netdev , linux-usb@vger.kernel.org, linux-fsdevel , cgroups , kgdb-bugreport@lists.sourceforge.net, linux-perf-users@vger.kernel.org, linux-pm@vger.kernel.org, rcu , linux-mm , KVM list Message-ID: <1524365960.5868.1622643316351.JavaMail.zimbra@efficios.com> In-Reply-To: <20210602133040.398289363@infradead.org> References: <20210602131225.336600299@infradead.org> <20210602133040.398289363@infradead.org> Subject: Re: [PATCH 3/6] sched,perf,kvm: Fix preemption condition MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.26.124] X-Mailer: Zimbra 8.8.15_GA_4018 (ZimbraWebClient - FF88 (Linux)/8.8.15_GA_4026) Thread-Topic: sched,perf,kvm: Fix preemption condition Thread-Index: NELkknquBPwUAC7hR8bH+DhrqDwz1A== Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=efficios.com header.s=default header.b=HjuuxeCx; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf03.hostedemail.com: domain of compudj@efficios.com designates 167.114.26.124 as permitted sender) smtp.mailfrom=compudj@efficios.com X-Stat-Signature: 34zwp1icndajgzjs1q3p7wwe1nam1tdq X-Rspamd-Queue-Id: DFB25C00F792 X-Rspamd-Server: rspam02 X-HE-Tag: 1622643304-275308 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ----- On Jun 2, 2021, at 9:12 AM, Peter Zijlstra peterz@infradead.org wrote: [...] > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -8568,13 +8568,12 @@ static void perf_event_switch(struct tas > }, > }; > > - if (!sched_in && task->state == TASK_RUNNING) > + if (!sched_in && current->on_rq) { > switch_event.event_id.header.misc |= > PERF_RECORD_MISC_SWITCH_OUT_PREEMPT; > + } > > - perf_iterate_sb(perf_event_switch_output, > - &switch_event, > - NULL); > + perf_iterate_sb(perf_event_switch_output, &switch_event, NULL); > } There is a lot of code cleanup going on here which does not seem to belong to a "Fix" patch. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com