From: "Kani, Toshi" <toshi.kani@hpe.com>
To: "tglx@linutronix.de" <tglx@linutronix.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"gratian.crisan@ni.com" <gratian.crisan@ni.com>,
"x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"luto@kernel.org" <luto@kernel.org>,
"bp@alien8.de" <bp@alien8.de>
Subject: Re: [PATCH 2/2] x86/mm: remove pointless checks in vmalloc_fault
Date: Wed, 14 Mar 2018 19:38:51 +0000 [thread overview]
Message-ID: <1521056327.2693.138.camel@hpe.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1803142024540.1946@nanos.tec.linutronix.de>
On Wed, 2018-03-14 at 20:27 +0100, Thomas Gleixner wrote:
> On Tue, 13 Mar 2018, Toshi Kani wrote:
>
> > vmalloc_fault() sets user's pgd or p4d from the kernel page table.
> > Once it's set, all tables underneath are identical. There is no point
> > of following the same page table with two separate pointers and makes
> > sure they see the same with BUG().
> >
> > Remove the pointless checks in vmalloc_fault(). Also rename the kernel
> > pgd/p4d pointers to pgd_k/p4d_k so that their names are consistent in
> > the file.
>
> I have no idea to which branch this might apply. The first patch applies
> cleanly on linus head, but this one fails in hunk #2 on everything I
> tried. Can you please check?
Sorry for the trouble. The patches are based on linus head. I just tried
and they applied clean to me...
Thanks,
-Toshi
next prev parent reply other threads:[~2018-03-14 19:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 17:03 [PATCH 0/2] x86/mm: vmalloc_fault fix for CONFIG_HUGETLBFS off Toshi Kani
2018-03-13 17:03 ` [PATCH 1/2] x86/mm: fix vmalloc_fault to use pXd_large Toshi Kani
2018-03-13 17:03 ` [PATCH 2/2] x86/mm: remove pointless checks in vmalloc_fault Toshi Kani
2018-03-14 19:27 ` Thomas Gleixner
2018-03-14 19:38 ` Kani, Toshi [this message]
2018-03-14 19:56 ` Thomas Gleixner
2018-03-14 20:07 ` Kani, Toshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521056327.2693.138.camel@hpe.com \
--to=toshi.kani@hpe.com \
--cc=bp@alien8.de \
--cc=gratian.crisan@ni.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox