From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52522CD4F4E for ; Thu, 5 Sep 2024 01:18:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5EEB6B00E6; Wed, 4 Sep 2024 21:18:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E8C66B01F3; Wed, 4 Sep 2024 21:18:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8625D6B01F2; Wed, 4 Sep 2024 21:18:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 61EE76B00E6 for ; Wed, 4 Sep 2024 21:18:42 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0DB8BAAF4B for ; Thu, 5 Sep 2024 01:18:42 +0000 (UTC) X-FDA: 82528924884.29.E9F95D7 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf17.hostedemail.com (Postfix) with ESMTP id 0197D4000B for ; Thu, 5 Sep 2024 01:18:38 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725498992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ChHm8Av3z+K6aWbN93oYWjO4JebLDOJBX50eySmUAY=; b=LW0uSVY3xMTg3iMUZ2g0tfAKPdA8sIcKEvnq7yDCQSdhpOhKb6L7tbmrRstIzKK+PzEmYc y2fW8VQjd3R8ST2JC5uiA7g/K4ILhQKpGvoXJDenmYL4dlpNQ8tghnDLgf5GuMVXL+PQ0z 5kNZavwf9MNj3AJujzn+AAdXL28hxiM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725498992; a=rsa-sha256; cv=none; b=dnawDL/mmwcb9cJBr44Gj9byMNj8qXeNdEjoMbsUiNVHrY3ZQaLUbI0CKqz/p1KUeqsORn rmRzUNbLC1UKE58p7Sv6BMLBmrXNXaE32Q70Iyw+/iA2tDZnlrttxT7qdTr1TpvZArPvcT VsCvmE5Adn98Wqa+DX+s+m/EpQh2SpY= Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4WzhLs52G3z1j86w; Thu, 5 Sep 2024 09:18:13 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id A20CE1400D2; Thu, 5 Sep 2024 09:18:34 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 5 Sep 2024 09:18:34 +0800 Message-ID: <151a4a19-552c-4e85-a4fc-897ab292a48f@huawei.com> Date: Thu, 5 Sep 2024 09:18:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: migrate: remove unused includes Content-Language: en-US To: Andrew Morton CC: References: <20240904095849.861620-1-wangkefeng.wang@huawei.com> <20240904135422.dfb9d92a998d7bb26baa5326@linux-foundation.org> From: Kefeng Wang In-Reply-To: <20240904135422.dfb9d92a998d7bb26baa5326@linux-foundation.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0197D4000B X-Stat-Signature: st5tmh9hp9gqi3hrrnx9awufm9ea8jxo X-Rspam-User: X-HE-Tag: 1725499118-408943 X-HE-Meta: U2FsdGVkX1/26xZWe85ei1DhGfPDOlYVbHLrDJU7HuVCC7hB6aFcQZ69Hcw9TXpoOY4EVzf1PmxGarYYb86CYBH7eEwaMorF+bJ36elWDo+qvp2LtksLq5RpueV290RD/WRzh0yd5lVQN2uHlUk1tQkLmUg28/oGvHoFuiBVGaWHZoB0pc+GDreraZx4xhTowUYS4ucHpC2VZ/CUCksAwydLt3JfocuZq9tIeePT7k17Ss2AbWMGWoH+nrRc429b7E7bfZxIGfgoR15Y3NbB3aR3htry+vaKhMbXVcq9y+DW0JMPnZlR7j7E/XWvnJevnTMnHFBn7/7DSheHbDswsKVPct5D3hx1dne1kxpAnEnVzaZ0GKRP8PNVBdO7uRoQ/0Ugnq94NU2XOa6YHYXDv87A8KZWB42n3eReatGnVDrXHR3A9Einpleh5aHQM1CJRcAkFr4e8o4FiVX5W/a2YQn0kw2YChsj8P7DI+CtriccUVFzMwkXT/9QH++uqjgAnENPO3t8hg8WB//EZxQJZaRu1/RaThKMZk9MfGlmufZX7qePDvQBpWjEFt0Z6UXeLfGoJHGoQDKW7mf1/y7FK6xho+cNF9zKs6vF4mIHIjmNZJfli4FcXZEGDNuHSnZrSL2FIk97pjwj2jHOpPp+TKXHIr8AkuTyKMabHHqTrwzkS7rBOSA2EltuT44X39CY/lA/iiJrDOrTizPU+8ufWIjfdDTQ7C6+ZD5DjqLWaarG5LyUquJNDGnJ2IvqS8VyRaL+iWe9nQ5qH/HK0cNGpXjLgIq09XH8UcykK6mT4HNhJEPqr+tRKbpQ6JjGy741eTP4p6VDwX+Q746D8kXHJKjtJCFXBJdE3iy15MnCR8dmg16oosIKk9EOo0KJfE9AY/GBILyLseA0uXUZU6n0fr8SY6MSGsRbcvxXxPxMISvRPsCc/JNxfua7wMUv7SfDRxinI0B+SY4bxUGklvB l/LzG/Q1 ucWyRoiYAJzs8M4C8R4HxTQwqwYoAbq+ZpeevS3LlicR2WU3EbRX3KWlzrwUVXW1L8pc2EAjfvmPJ1HDjcuNArmM0MjIjx/t5BIUp8z1LpFA/sy75nywsWahU+4VR2Fwt3JH3dyqPqwprRIQASw4Lbre6kSEU/7dKyhUJTpZXfGZLihpOOwynZ6w0mA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/9/5 4:54, Andrew Morton wrote: > On Wed, 4 Sep 2024 17:58:49 +0800 Kefeng Wang wrote: > >> Some includes are not need anymore, remove them. >> > > Please define "not needed". Does migrate.c simply not refer to Agree. > anything which these headers provide? Or does migrate.c already pick > up these headers via nested includes? > > If the latter then that can be a problem - build breakage under rare > configs, or as code generally evolves. Not a *big* problem - we detect > and fix such things quickly, but I do think general good practice is to > directly include whatever the .c file requires. Yes, I could add more infos, random.h not needed since commit 6c542ab75714 ("mm/demotion: build demotion targets based on explicit memory tiers"), all functions moved into memory-tiers. nsproxy.h not needed since commit 228ebcbe634a ("Uninline find_task_by_xxx set of functions"), no nsproxy, we only call find_task_by_vpid() now. hugetlb_cgroup.h not needed since commit ab5ac90aecf5 ("mm, hugetlb: do not rely on overcommit limit during migration"), move_hugetlb_state() is called and it belongs to hugetlb.h, which is already included. memremap.h, userfaultfd_k.h and oom.h are introduced for zone device page migration, but all functions are moved into migrate_device.c, so no needed too.