linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] slub: remove obsolete comments of put_cpu_partial()
@ 2018-01-26 12:09 miles.chen
  0 siblings, 0 replies; only message in thread
From: miles.chen @ 2018-01-26 12:09 UTC (permalink / raw)
  To: Christoph Lameter, Pekka Enberg, David Rientjes, Joonsoo Kim,
	Andrew Morton
  Cc: linux-kernel, linux-mm, wsd_upstream, linux-mediatek, Miles Chen

From: Miles Chen <miles.chen@mediatek.com>

The commit d6e0b7fa1186 ("slub: make dead caches discard free
slabs immediately") makes put_cpu_partial() run with preemption
disabled and interrupts disabled when calling unfreeze_partials().

The comment: "put_cpu_partial() is done without interrupts disabled
and without preemption disabled" looks obsolete, so remove it.

Signed-off-by: Miles Chen <miles.chen@mediatek.com>
---
 mm/slub.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index cfd56e5a35fb..70447d39de90 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2220,9 +2220,7 @@ static void unfreeze_partials(struct kmem_cache *s,
 
 /*
  * Put a page that was just frozen (in __slab_free) into a partial page
- * slot if available. This is done without interrupts disabled and without
- * preemption disabled. The cmpxchg is racy and may put the partial page
- * onto a random cpus partial slot.
+ * slot if available.
  *
  * If we did not find a slot then simply move all the partials to the
  * per node partial list.
-- 
2.12.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-01-26 12:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-26 12:09 [PATCH] slub: remove obsolete comments of put_cpu_partial() miles.chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox