From: Joe Perches <joe@perches.com>
To: "Christopher Díaz Riveros" <chrisadr@gentoo.org>,
hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH-next] MEMCG: memcontrol: make local symbol static
Date: Thu, 18 Jan 2018 07:14:06 -0800 [thread overview]
Message-ID: <1516288446.14023.0.camel@perches.com> (raw)
In-Reply-To: <20180118150805.18521-1-chrisadr@gentoo.org>
On Thu, 2018-01-18 at 10:08 -0500, Christopher Diaz Riveros wrote:
> Fixes the following sparse warning:
>
> mm/memcontrol.c:1097:14: warning:
> symbol 'memcg1_stats' was not declared. Should it be static?
>
> Signed-off-by: Christopher Diaz Riveros <chrisadr@gentoo.org>
> ---
> mm/memcontrol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
[]
> @@ -1094,7 +1094,7 @@ static bool mem_cgroup_wait_acct_move(struct mem_cgroup *memcg)
> return false;
> }
>
> -unsigned int memcg1_stats[] = {
> +static unsigned int memcg1_stats[] = {
This should almost certainly be static const
> MEMCG_CACHE,
> MEMCG_RSS,
> MEMCG_RSS_HUGE,
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-01-18 15:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 15:08 Christopher Díaz Riveros
2018-01-18 15:14 ` Joe Perches [this message]
2018-01-18 19:23 ` Joe Perches
2018-01-18 19:33 Christopher Díaz Riveros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516288446.14023.0.camel@perches.com \
--to=joe@perches.com \
--cc=cgroups@vger.kernel.org \
--cc=chrisadr@gentoo.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox