From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1E7AC88CB4 for ; Mon, 12 Jun 2023 16:14:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 043B88E0003; Mon, 12 Jun 2023 12:14:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F36198E0002; Mon, 12 Jun 2023 12:14:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4CD88E0003; Mon, 12 Jun 2023 12:14:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D69E58E0002 for ; Mon, 12 Jun 2023 12:14:20 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9AF95C0277 for ; Mon, 12 Jun 2023 16:14:20 +0000 (UTC) X-FDA: 80894593080.10.61564F0 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf14.hostedemail.com (Postfix) with ESMTP id B2992100006 for ; Mon, 12 Jun 2023 16:14:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MtzV+3QQ; spf=pass (imf14.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686586457; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YDOX0qvilhB1ysLp4ydOFwxDazVQ/jKQek++eIkaMFI=; b=e9WTfyrSy0xXfYDgN//KSZi8zZqpniBpnN/gW3CZpu5c0YL6+7aP6zvZy/zlbRcqXOVH/6 TraJ4evWHCatQaKoO4YiVVVENNaGNT3gG+OxAp4HjE7JDvhenQNR6UIiUXBBFT0skzV4Dq yZcWJ4Sj9Yt8zXAdBe2qTky/jx7+sQM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686586457; a=rsa-sha256; cv=none; b=uYffiTSCnMnOxnyQ06BQku5H2u8FFzpA84thC5Y0/pbMVyJPQZtCQ/oNxqhupst99YjtTB O3j0Wcm2lVxZB8JXKqVw1JlrhlUVsv6GWbFO7TbyHyy8guT3s0rK/Vwlo/m2D7y4Trrlnh EHuqgizr8aCVgc8lJaLifR/UxLWskmo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MtzV+3QQ; spf=pass (imf14.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686586456; x=1718122456; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nxVNBn+XWFWeEHcN8pf1WYBMgr4o1yAKNG8v2o0cHHw=; b=MtzV+3QQY4qMcG8n+ghNtsHKU1HAyb9GVGRe8NKuCxwnyMgnVf3vhkji G8MESVNwzn+0Eidk5JPBf/chPj9vm9Lb1bvZ6HThddDcrMJWWnt6zl/TN DFwuMh8y1jPoIkiVuvBmtu4UtBTQDGKCProSjnd7J1nqAHgAb7/vTSOwu kIy3EzpVB1I8HewAkL+CAPBz6e/V/Thc2m5MgQ2rCsHLarL5wAdgDpQU8 Qwnuiv92YaryzPmawVlH2hUQ4IcgMZCojCltJj/OL2lnOIEPdpqzEwFX1 ZlVQzIYalUrN6+aoboPDiokiLpo8eOJcAJ01WHCcA32pnM920wna8DpQf w==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="356976307" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="356976307" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 09:12:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="705457138" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="705457138" Received: from spmantha-mobl1.amr.corp.intel.com (HELO [10.209.43.2]) ([10.209.43.2]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 09:12:34 -0700 Message-ID: <15148682-e2fd-8176-563b-74acf9815b6d@intel.com> Date: Mon, 12 Jun 2023 09:12:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH RFC v9 10/51] x86/fault: Add helper for dumping RMP entries Content-Language: en-US To: Michael Roth , kvm@vger.kernel.org Cc: linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh References: <20230612042559.375660-1-michael.roth@amd.com> <20230612042559.375660-11-michael.roth@amd.com> From: Dave Hansen In-Reply-To: <20230612042559.375660-11-michael.roth@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: ot5bmxkntx8yppau9cczjnqgmqzz4gfx X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B2992100006 X-Rspam-User: X-HE-Tag: 1686586456-676332 X-HE-Meta: U2FsdGVkX19jd3Fp6GPVuGWxJ7fP09u9PhB66wa3/UQ8HEhgQ481SG29pEA3jj5O8x0J01WLtulqx4waFwncETCTCaAqaG54q97OwMrBTKgjl8Imbr6v2AshZvKfVVa1oafhykEHcxzO2mg9m0o6+qDErhBtqDB0OGtXO8CJEMDvMxzA2uask9cwawGj07/V6WaAeJRrOm6tpcDFGDLOUwvkxxIi6uFTIrTPZQxFH+tJ7WAbMwQEIjcVOqWxwW9DTRiuEfmdiwGQhfbPxA8OCJegKAkJvNTcvv381RgnRw9FYJ5kt9lDITshI/rAhd7ZfWOXdoOhzKJySko+aRcJt30LeQs+2fSuqf0LqrTUhw+OTiuWxUay70GVEZE9wcNTXvVLPTQp51gAHlygaxt0YVBFsjC2/I2aQnylY04F+sStkmiSkHKDIUAlCLdaZgib0iCX55g/myBH82R99+gAEHBlOIA2d/PRXZfaavgJ14NNVyJ27Ez2V8BCfrsQnRrtiPsfcZY2KgHVFcEvGwWzBoWZIsCIPDZtr8PZvc1PIc4r6dEoXKmwDo4rKE+Te3VPMAN5EOMeuBdc3YRBaVrO6q3xSLNDlFLEroXfC1KQSTu2EQpK/7tU2NFu0hrW2Ic0aAfm3gg/nsmFsJXha5edlnp28WTrTtEkEeXBeZn3bctUsZnJWgq+OJfAtY8bkNgeHTMRQToZyR70+WYp0WO48A0xE6bv7N9tX4T1s+H89XbKS7QxC5+WLDm3Wdw63+RQKusP+RoGjdAQBZOKbd4OPVEuOAyoUMTMjgB6GsMMor8TeCO5dpXWhLnKmui5IP2jSIX1JVa+RcXuGYxN/MabA4PRjxv1aBnnDW8tu4ci6KcC6TfSs24ttjl6EB66ily52YTOqSeMK5PFy1V5lANAqyRZPC/yWamT8fjDq9RKT6AL3f2LxF+TlmRWOooUbps0GFlriHImqwBu1ZuQWWH L2+NKEud 4RzKdetxxLw4zIag2XxT1ei6av1mk4TJRzXJA3VUKCafO2xJUDRXmQHW/Xeis+J6lt8wy6yr5LADwgFUQRowsBNCpcgXN4Ug2qZiIDhWl3jaZGmwrEJ4w+0WAAU51s2UVauaTrypyNiDbHIXiZ55B9yFBpQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/11/23 21:25, Michael Roth wrote: > + /* > + * If the RMP entry at the faulting pfn was not assigned, then not sure > + * what caused the RMP violation. To get some useful debug information, > + * iterate through the entire 2MB region, and dump the RMP entries if > + * one of the bit in the RMP entry is set. > + */ > + pfn = pfn & ~(PTRS_PER_PMD - 1); > + pfn_end = pfn + PTRS_PER_PMD; > + > + while (pfn < pfn_end) { > + ret = __snp_lookup_rmpentry(pfn, &e, &level); > + if (ret) { > + pr_info("Failed to read RMP entry for PFN 0x%llx\n", pfn); > + pfn++; > + continue; > + } > + > + if (e.low || e.high) > + pr_info("RMPEntry paddr 0x%llx: [high=0x%016llx low=0x%016llx]\n", > + pfn << PAGE_SHIFT, e.high, e.low); > + pfn++; > + } > +} Dumping 511 lines of (possible) junk into the dmesg buffer seems a _bit_ rude here. I can see dumping out the 2M RMP entry, but not the other 510. This also destroys the information about which pfn was being targeted for the dump in the first place. That seems unfortunate.