* [PATCH 26/45] mm: remove duplicate includes
@ 2017-12-06 17:22 Pravin Shedge
2017-12-06 17:43 ` Michal Hocko
0 siblings, 1 reply; 2+ messages in thread
From: Pravin Shedge @ 2017-12-06 17:22 UTC (permalink / raw)
To: linux-mm, akpm, rppt, mhocko; +Cc: linux-kernel, pravin.shedge4linux
These duplicate includes have been found with scripts/checkincludes.pl but
they have been removed manually to avoid removing false positives.
Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
---
mm/userfaultfd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c
index 8119270..39791b8 100644
--- a/mm/userfaultfd.c
+++ b/mm/userfaultfd.c
@@ -16,7 +16,6 @@
#include <linux/userfaultfd_k.h>
#include <linux/mmu_notifier.h>
#include <linux/hugetlb.h>
-#include <linux/pagemap.h>
#include <linux/shmem_fs.h>
#include <asm/tlbflush.h>
#include "internal.h"
--
2.7.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 26/45] mm: remove duplicate includes
2017-12-06 17:22 [PATCH 26/45] mm: remove duplicate includes Pravin Shedge
@ 2017-12-06 17:43 ` Michal Hocko
0 siblings, 0 replies; 2+ messages in thread
From: Michal Hocko @ 2017-12-06 17:43 UTC (permalink / raw)
To: Pravin Shedge; +Cc: linux-mm, akpm, rppt, linux-kernel
On Wed 06-12-17 22:52:37, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
I only see this one but I can see this is a series of 45 patches. Is
this really the best way to apply a change like this? Why not do it in a
single patch?
Other than that the patch looks correct.
> Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
> ---
> mm/userfaultfd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c
> index 8119270..39791b8 100644
> --- a/mm/userfaultfd.c
> +++ b/mm/userfaultfd.c
> @@ -16,7 +16,6 @@
> #include <linux/userfaultfd_k.h>
> #include <linux/mmu_notifier.h>
> #include <linux/hugetlb.h>
> -#include <linux/pagemap.h>
> #include <linux/shmem_fs.h>
> #include <asm/tlbflush.h>
> #include "internal.h"
> --
> 2.7.4
>
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-06 17:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-06 17:22 [PATCH 26/45] mm: remove duplicate includes Pravin Shedge
2017-12-06 17:43 ` Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox