linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm: update comment describing tlb_gather_mmu
@ 2017-12-04 13:35 Mike Rapoport
  0 siblings, 0 replies; only message in thread
From: Mike Rapoport @ 2017-12-04 13:35 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-mm, Mike Rapoport

The comment describes @fullmm argument, but the function have no such
parameter.

Update the comment to match the code and convert it to kernel-doc markup.

Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
---

When I tried to see the result of the markup conversion, I've found that
most of the mm documentation is marked as :export: in kernel-api.rst.
Is this intentional?

 mm/memory.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/mm/memory.c b/mm/memory.c
index 5eb3d2524bdc..3b445f2062d5 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -400,10 +400,17 @@ void tlb_remove_table(struct mmu_gather *tlb, void *table)
 
 #endif /* CONFIG_HAVE_RCU_TABLE_FREE */
 
-/* tlb_gather_mmu
- *	Called to initialize an (on-stack) mmu_gather structure for page-table
- *	tear-down from @mm. The @fullmm argument is used when @mm is without
- *	users and we're going to destroy the full address space (exit/execve).
+/**
+ * tlb_gather_mmu - initialize an mmu_gather structure for page-table tear-down
+ * @tlb: the mmu_gather structure to initialize
+ * @mm: the mm_struct of the target address space
+ * @start: start of the region that will be removed from the page-table
+ * @end: end of the region that will be removed from the page-table
+ *
+ * Called to initialize an (on-stack) mmu_gather structure for page-table
+ * tear-down from @mm. The @start and @end are set to 0 and -1
+ * respectively when @mm is without users and we're going to destroy
+ * the full address space (exit/execve).
  */
 void tlb_gather_mmu(struct mmu_gather *tlb, struct mm_struct *mm,
 			unsigned long start, unsigned long end)
-- 
2.7.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-12-04 13:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-04 13:35 [PATCH] mm: update comment describing tlb_gather_mmu Mike Rapoport

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox