From: JianKang Chen <chenjiankang1@huawei.com>
To: akpm@linux-foundation.org, mhocko@suse.com,
mgorman@techsingularity.net, hillf.zj@alibaba-inc.com
Cc: hannes@cmpxchg.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, xieyisheng1@huawei.com,
guohanjun@huawei.com, wangkefeng.wang@huawei.com
Subject: [PATCH] mm/page_alloc: fix comment is __get_free_pages
Date: Sat, 25 Nov 2017 14:29:19 +0800 [thread overview]
Message-ID: <1511591359-11448-1-git-send-email-chenjiankang1@huawei.com> (raw)
From: c00426987 <c00426987@huawei.com>
__get_free_pages will return an 64bit address in 64bit System
like arm64 or x86_64. And this comment really
confuse new bigenner of mm.
reported-by: Hanjun Guo <guohanjun@huawei.com>
Signed-off-by: Chen Jiankang <chenjiankang1@huawei.com>
---
mm/page_alloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 77e4d3c..b847b24 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -4240,8 +4240,8 @@ unsigned long __get_free_pages(gfp_t gfp_mask, unsigned int order)
struct page *page;
/*
- * __get_free_pages() returns a 32-bit address, which cannot represent
- * a highmem page
+ * __get_free_pages() returns a virtual address, which
+ * cannot represent a highmem page
*/
VM_BUG_ON((gfp_mask & __GFP_HIGHMEM) != 0);
--
1.7.12.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
reply other threads:[~2017-11-25 6:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511591359-11448-1-git-send-email-chenjiankang1@huawei.com \
--to=chenjiankang1@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=guohanjun@huawei.com \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=wangkefeng.wang@huawei.com \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox