From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: linux-mm@kvack.org, akpm@linux-foundation.org
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Subject: [PATCH] mm,vmscan: Mark register_shrinker() as __must_check
Date: Tue, 21 Nov 2017 21:02:37 +0900 [thread overview]
Message-ID: <1511265757-15563-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> (raw)
There are users not checking for register_shrinker() failure.
Continuing with ignoring failure can lead to later oops at
unregister_shrinker().
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
---
include/linux/shrinker.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h
index 388ff29..a389491 100644
--- a/include/linux/shrinker.h
+++ b/include/linux/shrinker.h
@@ -75,6 +75,6 @@ struct shrinker {
#define SHRINKER_NUMA_AWARE (1 << 0)
#define SHRINKER_MEMCG_AWARE (1 << 1)
-extern int register_shrinker(struct shrinker *);
+extern __must_check int register_shrinker(struct shrinker *);
extern void unregister_shrinker(struct shrinker *);
#endif
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2017-11-21 12:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 12:02 Tetsuo Handa [this message]
2017-11-21 21:40 ` Andrew Morton
2017-11-21 22:09 ` Tetsuo Handa
2017-11-22 10:53 ` Tetsuo Handa
2017-11-22 12:45 ` Michal Hocko
2017-11-22 13:06 ` Tetsuo Handa
2017-11-22 14:31 ` Paolo Bonzini
2017-11-22 14:36 ` Michal Hocko
2017-11-22 20:39 ` Dave Chinner
2017-11-23 6:34 ` Tetsuo Handa
2017-11-23 8:02 ` Michal Hocko
2017-11-23 9:21 ` Paolo Bonzini
2017-11-23 9:56 ` Tetsuo Handa
2017-11-23 10:02 ` Michal Hocko
2017-11-23 10:38 ` Tetsuo Handa
2017-11-23 10:43 ` Paolo Bonzini
2017-11-23 11:03 ` Tetsuo Handa
2017-11-22 12:33 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511265757-15563-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox