From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE1A5C7EE2E for ; Mon, 12 Jun 2023 09:15:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C2926B0075; Mon, 12 Jun 2023 05:15:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 573AA8E0003; Mon, 12 Jun 2023 05:15:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43B5D8E0002; Mon, 12 Jun 2023 05:15:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 34EAE6B0075 for ; Mon, 12 Jun 2023 05:15:47 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0A93A16015C for ; Mon, 12 Jun 2023 09:15:47 +0000 (UTC) X-FDA: 80893538334.15.A231D68 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id DAC1DA001F for ; Mon, 12 Jun 2023 09:15:44 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CNV1vhB+; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686561344; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=czIpL4TLoK5D3eKZvmop6buHX7NGH22btauuZM6tsDY=; b=Ipi4e8lOsPwQv4BtDIDdaBh2G0yBUH84aGyZ8gzYt+4lhPiXAddnrH87YeTzVdV8Z3jmcV B0jHhmLbKPQP5Il2aTb5PKlfwVGHb2ZPMP6CCAszCvDOrwkTDiYC+ZYKULsEvNJlgpqE8T y69FLQzVUfPyRdEVml5YjEy+k75+xD8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CNV1vhB+; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686561344; a=rsa-sha256; cv=none; b=tws8fGc7rZt9VftuN8mi6KzcOdzYM9cRNMKklOKeeUdJC1cPcM0Ctl1rTx/x6/Ldy46jw3 4P7y6pkfc6GpLjLjendSIoFHgQeKPSM+9yulY+WS2XlhnrKUX4vSCRrhGszJGjYK5GiFR8 kXmAZyvUljRvyjGP1ObxODqpWiWk/18= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686561344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=czIpL4TLoK5D3eKZvmop6buHX7NGH22btauuZM6tsDY=; b=CNV1vhB+iD6Qv2DS1ARgwVTw8f07Vr/SyHbvWDxL8MkS8s3TyBPTzRuawd1wudxjUN7XWg dfvMnXLkmusqxAPgCMm9ten4GXaAj9Z1HqvDpjkeeWKMnKJaufOUzfUJP9qu+TzlOwZtd8 QHUISOCqfxqEZN7CKPFCXrm3LKrG61s= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-576-tK8DL_92NvqL1z-DhWCE7g-1; Mon, 12 Jun 2023 05:15:41 -0400 X-MC-Unique: tK8DL_92NvqL1z-DhWCE7g-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-4f621c76606so2554467e87.0 for ; Mon, 12 Jun 2023 02:15:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686561340; x=1689153340; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=czIpL4TLoK5D3eKZvmop6buHX7NGH22btauuZM6tsDY=; b=dD6QgM0ljEY15KL1adZ4Fuqw1uHZd8G1+texMKMrMllKYtOmDofmfRoHvnMPZ7ZQIg 1XyRXMjHCsF2BP7oaTsyrE3Kk4qWwQRTxfg2KN3F9+auC36rll+AZZu+mV5aUK3gakZf /iJxcpoZn/27hdS14Ny2wepRxkuMEGEy9PhUnmEOwV0bdlI1mu5rtZ9PM/HUtqzjiOAN dMSOcY2xJnBskNgubBspeDHpGQVcoWlD46FSd7wqe1vVmjLj+xZ+cufEKkbAD6lgnte0 1k9lFJG8sAyEFhxnaCVsHJGb+dAnPHxOf/rNUdl6TP0eulB7Vw/GddW2A+pU0MjQCOvb cXLw== X-Gm-Message-State: AC+VfDxnamALW1bDkkh2Ali3xKpfHHIAy4bft9l+7uae5CNvLEjewrON WO/xPqfrfWFTZYxm4nxlKwFE07+tdKM2v6CVTojq9r2SBUKGzyFAoIfwzi9eRSsT32zaaT9xHZ1 GRuRM6bRaoXI= X-Received: by 2002:a19:4f18:0:b0:4f3:a87f:a87b with SMTP id d24-20020a194f18000000b004f3a87fa87bmr3504051lfb.39.1686561339851; Mon, 12 Jun 2023 02:15:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ692EK075LkrM2aK7Sk6hg48xxbKzREkGNPfKmmEece5RfX1J3soc0tEyP1ciiAPpRBlBrJbQ== X-Received: by 2002:a19:4f18:0:b0:4f3:a87f:a87b with SMTP id d24-20020a194f18000000b004f3a87fa87bmr3504044lfb.39.1686561339637; Mon, 12 Jun 2023 02:15:39 -0700 (PDT) Received: from ?IPV6:2003:cb:c74e:1600:4f67:25b2:3e8c:2a4e? (p200300cbc74e16004f6725b23e8c2a4e.dip0.t-ipconnect.de. [2003:cb:c74e:1600:4f67:25b2:3e8c:2a4e]) by smtp.gmail.com with ESMTPSA id l19-20020a7bc453000000b003f42328b5d9sm10745958wmi.39.2023.06.12.02.15.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jun 2023 02:15:39 -0700 (PDT) Message-ID: <15095aec-4ed3-c16b-55b3-e7122652a897@redhat.com> Date: Mon, 12 Jun 2023 11:15:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] memory tier: remove unneeded !IS_ENABLED(CONFIG_MIGRATION) check To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230610034114.981861-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230610034114.981861-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DAC1DA001F X-Rspam-User: X-Stat-Signature: bdpzqkt5nmf7n638puh316s5fwbuijkj X-Rspamd-Server: rspam01 X-HE-Tag: 1686561344-301396 X-HE-Meta: U2FsdGVkX18t19GjcQkI4MIltpfNL/yaiN52hU/eQTZCq9hhJJcnuRf2H6iVImSZo8qJveoCuutkrOxdZV+mzJtb+anRHTmMAlIsUkDuMPKM+vGVT+MW6whxkaGtXasD9RBT4n49SRHdkcYT7pRpAd/+031hYOiCMnUAtme4nZl0yjc9mCCSSCI3vDx+J5lbVhXHmIjtxDrPA7MLG4rJCOY1L6WAZ/MVjk7q0tSAKV08GVWiyTynO7x1RgV40sIKlU+h6CmyXkCkWwkvbEwmEyCkb3nU6+RRUpiQGJRhsizsS6Tkdii+JAp8Az3tY4Jo+2yeZAGkCVYO7wMiIGMuZ9I0q08L2TnnGRgWYxY17zFxeO37iwAVkNrBgbWKEiPTk18HbP6auZBWmmarTTci3a83BB1LNosPg4gNkllPZrJlv59BaNdHtfrxN8BYe4LydVVw5CUpk3P92q4B9Vu8NrFkc2beEiyQ1/9qLGYLLmHdDQoVfvam+PhkWzBJvHFfoRQoNKm+SLlXzX6BgxXg84nzZBTLBs1bULtnt5qpyeHdhgmlEN/CylK8ICwRlJY9nUoPWOpmPDXb1fGjGj1sf14m42z3ewxqUektTr3MfcjFDS/39ChDhgsDYJFl3xp9CAEr72cl2TMXAXN5i8yr3nP3WMknz2IvhFOT/URXeOFvUo+/HE8YFMi89x3LOjLdRBUJbJVyye7w9qdiWsx6gNr1/q3Tqd/tkLmv/EyYMlA30iKZpQug0Gfw5FyL1JOghl1BnkJfeXDTX18rth2iKm8TlAQEIVM0/WdATXy3qZR7p+/nM/1b6gLkHFkFYdwlArYAXkqATG/q0W3e6HUz1oqTch52UKqvM/3fCmmOY80z7wfYUtfqIBLop6tdLZvlDBGcuVN35fso1+pvpR0mS/HlKfL+ApP77UqWBnzaHFKreCf3+M0GuZBReS1R/uyaYLjDJpUY8Juq6luUqdo WD1K8vt4 8O+7y1OwsCb0n5D6y2/hQOZqUtDB3Tr0bliVuisv0WF6BVgxebd6rjdvnYNB710oNw+Bdk+nLglsoWyHKhW4nh9y9MgsiwY1XPDaVkiHxrGTVgFcDTIlT0lALK6+mdPDSO7+O1/b/9KJFRoaifz0PEfpuY/yd17Us9cP3AWQHTrgt9ZtXshgg5F+UdaUgue4D2OMptrt+UY8laBZACn7kKNhd568gX6vX0/K7EPrklyhVrCEYwoCV4YSpgkeS8l44TBqz+T3/vBWZkwxyvYerjuxNNze8YWJiophJ3UiAoGBgk60KOxPrRs69vsXrMKulcbKK56clNiuv1z8y9zdXrZepfAb3NQWdNFPeATYhZHjgrRjPquYpzp+l+loUpRBuR0qUTnjPnhIgHA0elAEOn0wdrAbrdiClXLAN9FpQfm7DjeZ+QyB32Pjxek+LIRg81vYxbp2IBeZ+cB6QxCamKWJRZ9ThBp4kThEHJlpGCwFXWT3ghobE/KBFwDxy7/Z/MYg+KOqZdnNylhk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10.06.23 05:41, Miaohe Lin wrote: > establish_demotion_targets() is defined while CONFIG_MIGRATION is > enabled. There's no need to check it again. > > Signed-off-by: Miaohe Lin > --- > mm/memory-tiers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index dd04f0ce5277..a516e303e304 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -366,7 +366,7 @@ static void establish_demotion_targets(void) > > lockdep_assert_held_once(&memory_tier_lock); > > - if (!node_demotion || !IS_ENABLED(CONFIG_MIGRATION)) > + if (!node_demotion) > return; > > disable_all_demotion_targets(); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb