From: Trond Myklebust <trondmy@primarydata.com>
To: "jack@suse.cz" <jack@suse.cz>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Cc: "anna.schumaker@netapp.com" <anna.schumaker@netapp.com>
Subject: Re: Why is NFS using a_ops->freepage?
Date: Thu, 5 Oct 2017 13:39:23 +0000 [thread overview]
Message-ID: <1507210761.20822.2.camel@primarydata.com> (raw)
In-Reply-To: <20171005083657.GA28132@quack2.suse.cz>
Hi Jan,
On Thu, 2017-10-05 at 10:36 +0200, Jan Kara wrote:
> Hello,
>
> I'm doing some work in page cache handling and I have noticed that
> NFS is
> the only user of mapping->a_ops->freepage callback. From a quick look
> I
> don't see why isn't NFS using ->releasepage / ->invalidatepage
> callback as
> all other filesystems do? I agree you would have to set PagePrivate
> bit for
> those to get called for the directory mapping however that would seem
> like
> a cleaner thing to do anyway - in fact you do have private data in
> the
> page. Just they are not pointed to by page->private but instead are
> stored
> as page data... Am I missing something?
>
> Honza
I'm not understanding your point. delete_from_page_cache() doesn't call
releasepage AFAICS.
The point of freepage is that it is called after the page has been
removed from the page cache.
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
next prev parent reply other threads:[~2017-10-05 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 8:36 Jan Kara
2017-10-05 13:39 ` Trond Myklebust [this message]
2017-10-05 14:50 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507210761.20822.2.camel@primarydata.com \
--to=trondmy@primarydata.com \
--cc=anna.schumaker@netapp.com \
--cc=jack@suse.cz \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox