From: Chris Wilson <chris@chris-wilson.co.uk>
To: Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Dave Hansen <dave.hansen@intel.com>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 02/21] drm/i915: introduce simple gemfs
Date: Sat, 23 Sep 2017 09:36:19 +0100 [thread overview]
Message-ID: <150615577925.24071.17558835162953494919@mail.alporthouse.com> (raw)
In-Reply-To: <20170922173252.10137-3-matthew.auld@intel.com>
Quoting Matthew Auld (2017-09-22 18:32:33)
> +static int i915_gem_object_create_shmem(struct drm_device *dev,
> + struct drm_gem_object *obj,
> + size_t size)
> +{
> + struct drm_i915_private *i915 = to_i915(dev);
> + struct file *filp;
> +
> + drm_gem_private_object_init(dev, obj, size);
> +
> + if (i915->mm.gemfs)
> + filp = shmem_file_setup_with_mnt(i915->mm.gemfs, "i915", size,
> + VM_NORESERVE);
> + else
> + filp = shmem_file_setup("i915", size, VM_NORESERVE);
Smells like the shmem_file_setup() is fishy.
This supports my argument that you should just expand shmem_file_setup()
to always take the vfsmount, passing #define TMPFS_MNT NULL.
-Chris
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-23 8:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170922173252.10137-1-matthew.auld@intel.com>
2017-09-22 17:32 ` [PATCH 01/21] mm/shmem: introduce shmem_file_setup_with_mnt Matthew Auld
2017-09-22 17:32 ` [PATCH 02/21] drm/i915: introduce simple gemfs Matthew Auld
2017-09-23 8:36 ` Chris Wilson [this message]
2017-09-25 18:06 ` Chris Wilson
[not found] <20171006145041.21673-1-matthew.auld@intel.com>
2017-10-06 14:50 ` Matthew Auld
[not found] <20171005151915.11151-1-matthew.auld@intel.com>
2017-10-05 15:18 ` Matthew Auld
[not found] <20170929161032.24394-1-matthew.auld@intel.com>
2017-09-29 16:10 ` Matthew Auld
2017-10-02 11:55 ` Joonas Lahtinen
[not found] <20170725192133.2012-1-matthew.auld@intel.com>
2017-07-25 19:21 ` Matthew Auld
[not found] <20170703141503.12609-1-matthew.auld@intel.com>
2017-07-03 14:14 ` Matthew Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150615577925.24071.17558835162953494919@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=dave.hansen@intel.com \
--cc=hughd@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox