From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BADDEC021BC for ; Wed, 26 Feb 2025 08:30:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E274280002; Wed, 26 Feb 2025 03:30:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 49380280001; Wed, 26 Feb 2025 03:30:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35A71280002; Wed, 26 Feb 2025 03:30:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 186F9280001 for ; Wed, 26 Feb 2025 03:30:57 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D5E6CB35E1 for ; Wed, 26 Feb 2025 08:30:56 +0000 (UTC) X-FDA: 83161425312.15.D128C9A Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf20.hostedemail.com (Postfix) with ESMTP id 1DAA41C0010 for ; Wed, 26 Feb 2025 08:30:54 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740558655; a=rsa-sha256; cv=none; b=TfTX9zuKcUZzW6dEf884tsK9yXt6u27z/kZbACO5ZOtG4sNKACLmrEEwiOv+Lvt64aZ5Iy Ua26G+njRCWILWgX1UQo/NgztacRE6XKBuTOZxKV7NH9WTLIFgKu3DAzBW0MmnMoyXzrbV /ohsP35kIAJMQBZKvrR0TizbILwfT2A= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740558655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8W1YS7kw1UYuPTog9vP2KQU1oV+SEgE+lxrN/xiMMxk=; b=2aJhyzNWSNk6+aNPTf2cNkeuShndrvpnEwCZM/Guaz4CPH4yKVV2ahjcUNKMygxQwCGXxK pYPKBpJ6p6CzlhkPGNI+7cHnKUd00m3yDh3TMHogHu0l2O3JRc3jKbq8uowipHVOL3v6gr TqhjigncsyT/W9Ay0ER+BGrZSIK3e80= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4719D1516; Wed, 26 Feb 2025 00:31:10 -0800 (PST) Received: from [10.57.78.248] (unknown [10.57.78.248]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CE2A83F673; Wed, 26 Feb 2025 00:30:47 -0800 (PST) Message-ID: <14fefa3a-9522-4995-8e51-662e80ae1747@arm.com> Date: Wed, 26 Feb 2025 09:30:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] mm: pgtable: make generic tlb_remove_table() use struct ptdesc To: Qi Zheng , peterz@infradead.org, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, x86@kernel.org, linux-riscv@lists.infradead.org References: <5be8c3ab7bd68510bf0db4cf84010f4dfe372917.1740454179.git.zhengqi.arch@bytedance.com> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: <5be8c3ab7bd68510bf0db4cf84010f4dfe372917.1740454179.git.zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 43isp4wywbfyifhgkqfyh3agm7g99wx7 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1DAA41C0010 X-Rspam-User: X-HE-Tag: 1740558654-425770 X-HE-Meta: U2FsdGVkX18oKeZLUOxglfVj4cfzoCla2JjonTqf9wXHWmF6p0QwwnPmFid2AejkYYoDGIGW/VaU7e3i1HYXkuuOK4oQPBgZ2HnUDJKsqTKZw/yCPvEFl/59jXZO+4eLH0jCwqdq+6FcM4pNRTf73SRCX0usBnv146JloZlyCcV2Q0w4iPfVs2U7yHTIw+Gpxmz5cEqaNBUGrvsBo97qcVJBDspSlmBjpF6pN3HZKm3tLk8BxVabkSHWnsCyLxRiZ3aJDAXqoKf1MKY/a9GakvrSqD+WcG7h68eoNgg1k4co8H4UZHFE/Xn2vjyfFJBfjycqBLwBvHWTJoXsw36Vl+roQJlPPA1VuOj1IyrUk52SJ9yjnV29OzNd1x2ZNk5Mr/doSbKaZQFBKDqo6KKf5gkIHYXQ1j95/yAYqhyUxdnKnqtzagQ/wSquNOUXk7IByKzXbv6B1lPioLOqY2Awb/rQmANjuVmkkTSAIkTEIctGb+jvA+oUAndCbwYhszgTgD1e1jB/6bAz6KzFY48h8ZMYE2I33s/zIcGHhMQ5KsQRFuZ9TVFwEgdFrsRLqAPzbBHpf6TS7e/3/5YRaYgzHgTkbRifbwcAorpO/IesAi8dD4GrEaeyxrrJG+wzG9NLg9KtFHWRA/pnXJuiEiLUuqRTMw1WGW1SRgH9QZ/OHcEGOc6x86X0Xh5WeZnaV3YWXCbQvQSsFM8cZrVbbx1YXJEi9eggVj3bf6IdHWDBE30CtQC56SWfh41ZBigUYGimmIkAlzfQVYn02ZCCp6wUY859LxKW+qyUZ7saStLkMSB0SNZkjasG/mG3/gdOjJiHBA27IFPwNusTR7xH7ah3d+wCXzo1kqXaSSw2zPTWkSxOkyQs3MbUcafN17plKKCFHS0gs79qqx+bwtEUJTeu/cwNYiWL3Paazi8797Dbalr2UblVpKu8DsWTIQB+1WSfQCVYeSd85u7135O3eHy 32xIb3Zw aAotqO3CH0Ba7iHyoOg1n3a0wzGPlj2uuzzwRFB5P4AT7x8oeGiMrQOHLp1FFSPsfG4jajWM1qj4z7/dLGMW/d4Z2Tow8NuFz/TkLA0fb/lJqihUyi2eeSgcY0Ju1D6b7PaYh3NGeyd6bRTY5RvWFq9WbWu4FRGkeTqMgkZK4KCk2BXIHiSCiZpUM/EweZFhSa9gVB/ajbzTNhmpYHz90YE2jiQOWAy0691/JoFaAVFzZKNfv2+/uDgGC/Zsa8HO9bidXCbGOcS2g6hUu49NOLibosH6WPkNxmRHuU4bmdtbt1OGdk9ruz/Xn6v4GEW6tpKl0ecdxvmtwzvEMs+0m1vRjEw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25/02/2025 04:45, Qi Zheng wrote: > Now only arm will call tlb_remove_ptdesc()/tlb_remove_table() when > CONFIG_MMU_GATHER_TABLE_FREE is disabled. In this case, the type of the > table parameter is actually struct ptdesc * instead of struct page *. > > Since struct ptdesc still overlaps with struct page and has not been > separated from it, forcing the table parameter to struct page * will not > cause any problems at this time. But this is definitely incorrect and > needs to be fixed. So just like the generic __tlb_remove_table(), let > generic tlb_remove_table() use struct ptdesc by default when > CONFIG_MMU_GATHER_TABLE_FREE is disabled. > > Signed-off-by: Qi Zheng Reviewed-by: Kevin Brodsky