From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EF2DC282EC for ; Wed, 12 Mar 2025 01:45:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8FB8280002; Tue, 11 Mar 2025 21:45:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3FDB280001; Tue, 11 Mar 2025 21:45:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C07AD280002; Tue, 11 Mar 2025 21:45:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A33E2280001 for ; Tue, 11 Mar 2025 21:45:20 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CFBA51608C4 for ; Wed, 12 Mar 2025 01:45:20 +0000 (UTC) X-FDA: 83211206400.28.43C7D57 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf21.hostedemail.com (Postfix) with ESMTP id 5A9FC1C0004 for ; Wed, 12 Mar 2025 01:45:16 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=d0swZMFO; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf21.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741743918; a=rsa-sha256; cv=none; b=lIJp7R5ZKLzB6PiE2WP/ZH5PfSy0ifr6Ig1DbKFnVlPZtJWg9avPKAuBE+RnUf9qZxDWWn Ja7vT2x4hvnbnnLJwNNOyQPrGpmPVF/jY2CV3APUqZchOfjOIIl+ehMNCFKmfwRXXXNS7j eTdRHiTpbmnUaAPOZy6WZoh12PolLEw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=d0swZMFO; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf21.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741743918; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pJsIAiBQwxxlPupaINFvaIjtvwWgE2QzMrLd5G9yQKs=; b=RJDcEfm5PwtYJGLGA0QOsVzeFeTCfhhwjo259QdFJ6YDR2pXaxLNP/+dntnRab4Hg2iAQi ISdGdtXQA/N9Ej7ghE5KPmMScT0vK34Q9W2k5HTwCHgZqli4y1XJDIMJ03GpX2G6iYwcKr MBtywv5IGpqkc/gCkNYQmlCR1DP06Ag= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1741743913; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=pJsIAiBQwxxlPupaINFvaIjtvwWgE2QzMrLd5G9yQKs=; b=d0swZMFONYndRVShHlzlIbs5BprWlukz1ndComeKgAiY5+AXJD4ZTgLDtTK9tnpr0lK/CU6CNFXneNdi1Ci+f7pDsSQZEWVveHcUABEwU8+4jak2kcGVjHVB2bvHwIaY2qJs+taMQUouYvYJxaoP6LwGI7qM7eWQqk+nA3Db9B8= Received: from 30.74.129.75(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0WRAiBpj_1741743910 cluster:ay36) by smtp.aliyun-inc.com; Wed, 12 Mar 2025 09:45:11 +0800 Message-ID: <14ef70cc-beba-4abb-b206-e9fb29381023@linux.alibaba.com> Date: Wed, 12 Mar 2025 09:45:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: alloc_pages_bulk: remove assumption of populating only NULL elements To: NeilBrown Cc: Yunsheng Lin , Yunsheng Lin , Dave Chinner , Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , Alex Williamson , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Carlos Maiolino , "Darrick J. Wong" , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Olga Kornievskaia , Dai Ngo , Tom Talpey , Luiz Capitulino , Mel Gorman , kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-nfs@vger.kernel.org References: <> <316d62c1-0e56-4b11-aacf-86235fba808d@linux.alibaba.com> <174173371062.33508.12685894810362310394@noble.neil.brown.name> From: Gao Xiang In-Reply-To: <174173371062.33508.12685894810362310394@noble.neil.brown.name> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 5A9FC1C0004 X-Stat-Signature: mdabdsfma3rurpf1inpezdqc5f5nzzw1 X-Rspamd-Server: rspam06 X-HE-Tag: 1741743916-686793 X-HE-Meta: U2FsdGVkX1+N8g6Vv/FUiuY+0JQw3x7472Nk2DHVj6Xs8nlF41Np8EXRCoUEHgSwGKgMUjV03fx37LyBc4YiypT9vZAGY8e5Bgt62ubAH/TKp3YzZZolSHmM+4CN+2DTYFsFV+xcTvk7bEtWUMeVCXJBDUxf/5mqqV6Od/tD0j2nAF6dZ+3K6yTYqSSddlWSa1u275m11wac1+edqCsyC4kPyyZloZNn5DbBX7Wj+8UYwq8vfhWEJbMcbZ+AlLlhNum5YNmvUbvD4QJaLaY5wP33vL0T0/fBufa4T4izwzzL0g/IVXm8lHR8SguQOwSJfkgDfqXqsVr0pNV2t+V3EceponHuf2Nd4BOGAyb6RgZgaazVKbn832IXGYaubTfprJDlgEigQoDMk9zu6grraM0R6tnMf+wXSLecFXyXAcPVCyvnsCwT0Qtrjc07Tt0C+Wi4OnF6RDCk0sJhZ62uBGzlhqHgMTojhliS0j4oCvoM6MEn4Z16qoy3Orb5WPDI45VMyoUeMxxm9HECwt3/M80LkcYJbLGZpzejtC+FjTJp1ZR7i7dcVmuTlGMmXJbW+D/lcCbF0C8E/GAhslBMegJxQRXDFVQQQKTJGPMEP2xENLXVAKY01FZmDqqxQP4DZV6foRJuDmV7P3Rhf/EPJT8g0kTZlUvxjj7+62yASAjhyXFo0w5T8//Yly59pBpWmsw0pWhTkbfLHlZ4CRfYXsb2trVR18Xm8i9FJmHmH70NHQySh87Jiyp4lP2GUjMVvy5HHMkhVfLIHAgOj8ftcpNaSIIOtgT23XccFMJW1RC0e/LRb3VbFWPAe+rdAu0BpLXX0ec1kFzil6I7jCpAGFOM3/sUuvB9mz5CH06qlas+bsEuyZl++EwCVzJBnVjjd586oLkCeLxCwXciyNlR2pIkmzDlazOydUxhsfmofrZE1m7GbkweJAxub4icWegj4BM2va8CzdwWv69SAUf RFAsW0tV KWvRh1qpUJIbvJPS6fXVwgVuVyWeBIZuqgfKu4wfj3JEnIaQynd6s6C5c5KFDBeerudbu2fi/er2X6uttcuaUPnGgeTa8oeAy6sSvLOC9Nmd6v/izBbP2aupLbsDjQ5S4Fq6++s1sf8Lc7xaSE9jhCEloHhWBgqX41ckAocwEesVn6P9/lU6GWawoWkFOVMXnTVSN7e8X0e3W456lzySpJrtyB6fINMi1zwfiQ1qWwbsk/yw9nPDU6bcPCchqa/OlO3zInjYS9INeySCnMLYiheI3ijtDq6pw7uYj4gntctLmn+w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/3/12 06:55, NeilBrown wrote: > On Mon, 10 Mar 2025, Gao Xiang wrote: >> >> - Your new api covers narrow cases compared to the existing >> api, although all in-tree callers may be converted >> properly, but it increases mental burden of all users. >> And maybe complicate future potential users again which >> really have to "check NULL elements in the middle of page >> bulk allocating" again. > > I think that the current API adds a mental burden for most users. For > most users, their code would be much cleaner if the interface accepted > an uninitialised array with length, and were told how many pages had > been stored in that array.> > A (very) few users benefit from the complexity. So having two > interfaces, one simple and one full-featured, makes sense. Ok, I think for this part, diferrent people has different perference on API since there is no absolutely right and wrong in the API design area. But I have no interest to follow this for now. Thanks, Gao Xiang