From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CE0ED5B156 for ; Mon, 28 Oct 2024 21:28:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8743A6B00AD; Mon, 28 Oct 2024 17:28:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 821E06B00AE; Mon, 28 Oct 2024 17:28:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 625D56B00AF; Mon, 28 Oct 2024 17:28:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 422976B00AD for ; Mon, 28 Oct 2024 17:28:34 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B39178020D for ; Mon, 28 Oct 2024 21:28:33 +0000 (UTC) X-FDA: 82724299392.30.B1ED812 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf02.hostedemail.com (Postfix) with ESMTP id 3DC7980006 for ; Mon, 28 Oct 2024 21:27:45 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=HAKBBP9J; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=GV96HfFF; spf=pass (imf02.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730150856; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f/SIYhufACABXuN202P6QTnajwjlgK4L0bX3mB+7hRs=; b=yc98OqaQn9wM3hzG2/8K/rC8494WOLmgDr7Jeb6zkl8R1ZgZ42dqYfnOvYuWeGNftbeuRP hYKyS02ysH1KuVm03q2M7TSntIiqu0C4z3h/MjW7y1qUx8ZJGNNZrNqW/aSJiMDC9nBB+J /3ozqL2Rp1REuM+dXgMP41Y/XFb1TI4= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=HAKBBP9J; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=GV96HfFF; spf=pass (imf02.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1730150856; a=rsa-sha256; cv=pass; b=FaXjqfEyQ0lL8YgEmIcrW3a/xzu9ydZRMTzDgXkVLtWiKmBdba8oH0WBzE895YLlfGNJbv BszgtWomcxJHwmqBFjcXlgtPkSAqt07a98Gg0roD7y6t7nL9+KRMZefFWbq4FBauHUes5d WDD+R+tz1Ut4AlDbkv9YtKdh8IyF5I8= Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49SKtb1Y031947; Mon, 28 Oct 2024 21:28:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=f/SIYhufACABXuN202 P6QTnajwjlgK4L0bX3mB+7hRs=; b=HAKBBP9JHusIP/jb30hfZgFNLyXXaUZAMj 9yNDRRL5upba4HO9DFKYs6kbQJLRoH5hX93lcVice9DcSfDsa4IlTdErW4tmeNTB p15+D8+PFC/xU+dLc9xQBz2tHyPEUwqRWZmWCm+rmytcnWCAn+eK23BOqDhkPtnW Y1k4JqVH6OlbkU31AsvJWmGo5Ge7uAnbSKj4bU0V8LczwVdMAsJKK0yGqEafxJH9 tMl1riaOvuXujJDSwHOBHEb8KZ8ZjVCAm3fBVHtIyOAky80wURLgFGhB1FtESlVz YZY+KQDl95AoGXeUNfy4hO6NgyQM10XFBlUJD5Zu92J8g6Sek6Gw== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42grc8v1bd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Oct 2024 21:28:23 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49SJvUWQ004866; Mon, 28 Oct 2024 21:28:22 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2041.outbound.protection.outlook.com [104.47.70.41]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 42jb2t7v4c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Oct 2024 21:28:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DSsCaW6xyWhMzGK6j/asJAcwHx6ULPnBebzh45fliTZIzUOKhlQkp7j7PGWXhGmiViuyItU+mB+tHSXqJ/6h4miTzR7kGJdCy2rbELc4gVCudBcxoBY6RmPaRuprRbldI3BUBTNTNppk39oJv0ZROObQlpu5VvMT2VlbZHUtbEgwv2SB0ZuaAyB6HktsIpYRg4QVy+ELdVW9pj1479Qedu30VfjIFnBDFDD1zbzSZs1F+wsY2tWgpJAMauz+5gskTzAfACH+cc/+ZmYdHjvRcdPbXh+vTkOkEldcu+JiXIgg4jmHdi7QzAcgqFkjYXKltVm+1Jc9lbufBG27sJeWoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f/SIYhufACABXuN202P6QTnajwjlgK4L0bX3mB+7hRs=; b=duEWSdrcYQmOUz+G+V+B8rsASDsEIFrcCRs4uZl146+y7qORfWHPfDfbCtsuySuCN9oxi/assiJk0EKJ4wPSO6kl1bWwbs8SZlEtxcNEv7jmO+JZzNgs8zBiuOmgzS/bcS4qKzFJ/Q+P+uVlMm3Fteq/PknL1fRBrucgYFNs7KUnNtU2Jd51vBgRb9Zlo5m2ffm77vyWy/5wlNVQRg8g+soruzdBlReamOjsa4D/oXZm7lTO+OadVwkGEd9UknwJYwM2L4nBZ6AoreiDHyZwjKtUaW3Fr3Rr9kVUK4T+ZDCimeS0Dnd4Jz44dKcVmmfX0OuLJFBLh0jbi5zpIRg8qQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f/SIYhufACABXuN202P6QTnajwjlgK4L0bX3mB+7hRs=; b=GV96HfFF8HrYefRKqvAtkx85khV5aa7mnt28UnWOkzkiRUFtHaiP1JqPi7r8+wTYp1kNW07dzj5H70wolJE8QnEbyIGoOH4yR18ukUuhLBZUJAPBAs7QGgg5kN74t7zuwb+ZsZYSbidudCOHcg9GIBqUiyOETOHFW0DVo6ux3Mo= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by PH8PR10MB6597.namprd10.prod.outlook.com (2603:10b6:510:226::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.27; Mon, 28 Oct 2024 21:28:19 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8093.024; Mon, 28 Oct 2024 21:28:19 +0000 Date: Mon, 28 Oct 2024 21:28:14 +0000 From: Lorenzo Stoakes To: Mark Brown Cc: Linus Torvalds , "Liam R. Howlett" , Andrew Morton , Vlastimil Babka , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Peter Xu , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Aishwarya TCV Subject: Re: [PATCH hotfix 6.12 v2 4/8] mm: resolve faulty mmap_region() error path behaviour Message-ID: <14cb2815-a5a4-4336-887a-01b305e6289f@lucifer.local> References: <61461dcc-e455-450d-9c01-5465003fc31c@sirena.org.uk> <438f50c5-8b8c-444f-ae85-10e5151f3f24@lucifer.local> <57mgmdx7wgfwci3yo3ggkmcnm3ujamgkwcccm77ypvmer5tegn@opiq3ceh2uvy> <91d9f81c-b971-4764-8f21-4011023628c0@sirena.org.uk> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <91d9f81c-b971-4764-8f21-4011023628c0@sirena.org.uk> X-ClientProxiedBy: LO4P123CA0089.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::22) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|PH8PR10MB6597:EE_ X-MS-Office365-Filtering-Correlation-Id: 48d318b4-eaac-453c-d368-08dcf7977123 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?POXlVIjyZA7El4gka9AyJ+Aa69huGMnbJEjLghb5VNQho6ySFcEHt41uXQzL?= =?us-ascii?Q?al6RO+HQqXEGTLNolo5HF1ma4r8Qow2K0BP/tYiKeQl/JTm5V5E6aFk1s0Ts?= =?us-ascii?Q?Ex1po9WMI3flqiywZ0ole5+TZLUX9xpxvCYblnBbhMSqSqvTNuVzVW8syaJ6?= =?us-ascii?Q?sEUwJr5GaDYUNG4nVXgtk3tOn0AQxdHv3AE6F8EUlMnqj9PlZI/xFuyeAi0S?= =?us-ascii?Q?3EkfiIDR4Di8iXS1G1IEuTbDmFD1rhC5jjwrF6kUhmfRhfSsqM8F+r8fM7QL?= =?us-ascii?Q?vay6/KfjSu74+c8RKR4Qxia3SkmNOy13NDzCZUsFD+xixhbiVojoTL2hgubF?= =?us-ascii?Q?UDMIyEcgYyJeZtUOSHCgg/rVzWM5s/jn3L9Qh4fdSvFViHTnPhrllpK185cC?= =?us-ascii?Q?plHOGc2kyxJJGepo87UW3utt6agdpI+6idw2YibMbzdpKlUWm1Kd6V0dYNXL?= =?us-ascii?Q?zUjoFdif1Xzg6HY2XcNfLDHRZcGBH2aXuyB9xug7C+R5/C84RrsiTa09tbID?= =?us-ascii?Q?Ml9LiaqPfS6LbL/4l16w4+F60I1o58X2ogxWbBpifSJBIARaaWsqRu2K1WY5?= =?us-ascii?Q?ByeUshZ4Fd2nHGJvuiSAH6WcV6RVJudWoJTj/4vPMmOrV4HO+NOz/mMJ7GpT?= =?us-ascii?Q?mnm5q4kgounvh+wZDEJAmNZ03C0SXFFbA4eolcy6Moy4UFKS8XrpnPBI5H8u?= =?us-ascii?Q?xBxL2GNVGrxv1aYHjchGKMITRs5MaROTOtXz11qWdv2z+MpwhtZkC0NP5e1I?= =?us-ascii?Q?njOBjhkUBEC4LsxGyfcsZHV21zxW0E/Y42kKtuKb1I1N1xTM2+s/zKk460/I?= =?us-ascii?Q?atKXUBe288tkbx4wthXbM9D0ptyLJqttWEZH5MUkfb3HjIebxswxf02tDdZa?= =?us-ascii?Q?scq+VCEpc+3RnQngPjmr4K0ERY1g7Kj8pIlO9zfcYIGWmnJNJdqJy5DXzPxG?= =?us-ascii?Q?b/VGK5v3mnr3nZ58ib2GS6eNo1Y5Bdg7eGeNpQOlkXPHvUrtiKnVNbVAFZOi?= =?us-ascii?Q?0nGqzC3rK3XFtTn0J7tok06ho3zMWmTZf+qENRXxnVKWhkeVZN6DpIdwuu/r?= =?us-ascii?Q?rMnQDVFjBUw79+psaFEOJpVNkEtSqQIXX+N4gughTa0vsbhAjzs/PTvudoFJ?= =?us-ascii?Q?L79sn3wvw1oRq4IzwfHt4izWNQEoTiSh0d9r1F2BgWj73oLncAa9kEwCC8zd?= =?us-ascii?Q?DlznUxAaBd9RP/0LfEFkkSuFdobIVSvR3X9yzS91tinTr38LFxNsJj/Fua2r?= =?us-ascii?Q?YMStlMwqyG2eyLASTCcqdE18ld0YneV4DMsrNK7EwRe65ZTyrkbW+oLzQrj1?= =?us-ascii?Q?JJ3JzJQBSfs1q0c2VlCE+4w1?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jdyCMO0IJ5udt4YIVGL95IcMWjcJg2O1WgBJbMfVgmPPlovTda+3K71+xJO/?= =?us-ascii?Q?Ndtinl0ThHCfKQot+W/12J8IF+bnmFLx4iwxK3+6LlKCamfpguWE2YYxmq9U?= =?us-ascii?Q?SAJZpXd0xqRKW013fDdcXONqNefz3wjS4FIS6CT2CTKwWn/Bo7ZSBmH8/X/u?= =?us-ascii?Q?EPMMSEFELNsX0YfGuCS2xE8HC44jKQ3HXQy5zQpl02wPh44JiJohogutoAp1?= =?us-ascii?Q?3sWA1nkLlFpgDXDRvWH7SAValK8R1Vx7tEwRWLwQRqDPuAFrFW4Q5NUnPYvr?= =?us-ascii?Q?bHd7PKo+66gycRQLdOQvrJiuY5SdThww47jSKKvA06euXq96BGS6eRFjnbMf?= =?us-ascii?Q?x6bQwnYr/hcTXSHfQWljXJ3aS2ypzokXmBOWbyPuEKWvr7vppI5Op6kQ+dCM?= =?us-ascii?Q?tPascATcvNEr8E3Ygcpcrkl1fBFRXJYflVi9blpieulOvxFekgqPyi0F786l?= =?us-ascii?Q?GoAqm2Ubyc+Wd/SWnPtWJnQ2PxIcR8otO6I8DluiX4lKf1CqvP05wJWup+Sv?= =?us-ascii?Q?DnWzZNfki5IhZDgTLOXPTdZ/jXrSjn3PCEqe3zzAAV/twIbvsAuxaLZwyo3I?= =?us-ascii?Q?RZUUGcK4FvLeeTWStt6DqED9+C3VeVsa+NnzoKVW+BqArBdWXtqCjanDA9K9?= =?us-ascii?Q?YCM8j4EOZ1gqUX+xW2uuI7biojelhgxznPyM6DSl3g7rgQFONgMNoo0HtCWh?= =?us-ascii?Q?cu2to9KWHYAjq+tBcNUa8SLyfMuIMJtgsk4H6lWO47zm/BJkfPOYjXiMMvUc?= =?us-ascii?Q?kULq4/mQbKbBuy/NhV2ygw/CClNkYNMnM61nKqb0yOULfNU9XuJl+MDqveiQ?= =?us-ascii?Q?CnbLD08NWXckbDg+dkLZe2yY0D8OdVtWJqvXhGIiAcFBGMtGUMIxMzvOHbXU?= =?us-ascii?Q?gwBo7b9iCvtIXUWt9Vwuvry+KBnSJmZgiI4BsXlOIOA6tnCq0ItWzx6jlXeY?= =?us-ascii?Q?SJSxOWL0QRAq/NKq4EHLQyyKB+FYU8pCAfm+AfQycbryPnNqWg3BzdQkN5ep?= =?us-ascii?Q?g1f+WCxdOMM7oRZFtppZ+Xv2igk49RnWecb98SSm99/zGgVok6WdvbFRrJ+d?= =?us-ascii?Q?+1DBMYozqWd7GV/RYraZIFRYzYTesNekJCynDl3FGKuTygRbc08x8hK5pSxv?= =?us-ascii?Q?0jc0AiRKCWcclJ/zn/fe2CL4RDJPxqwSVZ/+3AJsCIEV/xtU27lDmBwUow7j?= =?us-ascii?Q?iiNb6zmfqrMvXo9D5kPU03eZfIaOfzseXHqkB1AW2O1R3MPGSPyiz6fnkYN/?= =?us-ascii?Q?93Ga+ujAncGq7sg8fzC2fzMWNKslKFxdMEhvquEHyf7pZk1PAtnlRXg3be7w?= =?us-ascii?Q?dBz/3cx+NmqZWl+O7DDRVuf4c0AXM8VU7oFjzDBF5teipoe7xKizXZjtJIS0?= =?us-ascii?Q?QN/xooSNRj8GpDPO+9IYhR2yGayozx9cIgufN/DJF4kN7Bgok23x7vvGT2R3?= =?us-ascii?Q?Dc+bO32NiEJYqu74SJBFbPhfwITaNRpqKoWVrI8Cp9nfwzjq2rXZfF/DUpdZ?= =?us-ascii?Q?MK7ann5g52Y1giiEuNjJ2Bp83zJjgAdqiPBXrgN3EnuMlvB+TKLgebwcep4+?= =?us-ascii?Q?CEH/kwcp42LtaBvKhoPay9NL3y/XTHCcTa2QsDDdUpZcWC2FmU2hXvpiDCnH?= =?us-ascii?Q?aQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: zQ/bDy6dDQUkdXmkA+wqmuE5T/956kar6Wo8wPCrxx/F66KGYrruFj7slIyeitemgg5nkrHlPX05mr4uy1GRbMUNWjLxTvNR/U58K6hOPSSeEcxmSc9Ho6XxpdQ9GUBgr8FsN3SA/o26Jiidg4uTii3hZc3M+b8RPEMGDLYH+u3w5J5iEuUk8QV5srFGyS6UbtqXqusGM7EdpXXOLEn1PWd3PxQ5pirvN6B2hg6w90dT8YlKt8nJc0Wd24toQgpTG7jwJi/aqoSvW5ujHKfDB7WXpS9u5q/6+47qxNDHxBSs8+w3a96hzbLC00+3+WfCMkvjyTnkPmJTjcagy+9DwkEQwAauMiQ5w7UPZPAtYzPyEMglU3zJM8o6Yq8ge7vjANtIqwTM8SiFPc71ysjW9YhN7IQlQfKSMuxHuE4QywzEcEChIIhyFZL0j3tpnDIKS7/kIt6AbZuL1k88Yatdg+8EbsjuAWH/saKuSuZ3AFzEL+ArtLhidYp6JORF2nQ1tvGNvsbXxD4cxVMdaZ6OCxhODO+viQjrX1TwoN0Ho45h0SvoFPOplN3FBQg4yWt3SLdcdHSPwCiH0XOnU91RRDnbkX3wL3pQ6Ov+IsIv18A= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48d318b4-eaac-453c-d368-08dcf7977123 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2024 21:28:19.1020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1y9omqYpUbBSBySqiZgkhtOhO5BQQDMBnNxfknkqm+XetAW6cQakk2HYyRn3FNNBrNdny04TFBWR4x+XOvq/z3TIzfYHDyhbYTK+P2U5Krg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6597 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-28_10,2024-10-28_02,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410280167 X-Proofpoint-GUID: N-3Z7Iydx8ROMUqQgT0pWNLW0K0UVHrl X-Proofpoint-ORIG-GUID: N-3Z7Iydx8ROMUqQgT0pWNLW0K0UVHrl X-Rspam-User: X-Stat-Signature: mgrnmo8mh54n1mtzhmksg7qmazi93by6 X-Rspamd-Queue-Id: 3DC7980006 X-Rspamd-Server: rspam11 X-HE-Tag: 1730150865-866751 X-HE-Meta: U2FsdGVkX1/YQKTk7sjJTkFmsD8l/q6CgU1fUH36KXPGGS9JBJ4RSkXi8SGGIz96hdk4mSSVq97VAVfq3NdzdgRgBnaj3DUEXaskAHaHaegZoNt+UWKLn1YW/Ak1MKPEfo7dMzOyDsKXRs40mEHy7YCJ+xBaS6sHtjHStLX6zlDk8m1EFmooG7Kkz+dRhM+DSTYD8+5PImo3JNRkJAhsulVzzc1/+uU3SRytva4SD/x2dCzMFnrGm7RWdT4WFN5oRP9dLmx+B6PIFlGcpd94mfqbVXRV8P7RRk0pdwGwoWS/ds/IuhKCv4ovlky6NNCdrh9KmM+QE/9rEEJYILll9iko+GZb72cspR575a2IbWzyK/SOFXQ6toKyedBUlMgAaYt80MGf9+NQYE6XMyHeSKkzznKxs2Xmb0uI9x465FGMQO6tm4Jdm5NRAb9Vj871ziqQmjMxrd1OtKDgwFGU64YNvTwdrP37FU3r5enxKq6j1/LyEqS2mUDWg+f9HY0s0OX1am2wYLZGOQCp2bphAhhw6NNiya/eaLAhFLDpUvtRrJlxXWSspgyZ+neSS6R11Pqdk08CHTQtnMlXfg6X+bOZ6Ab2gYdXeaRl60skcFA241yLnnpC3kfX/OiWzqPIUEkKesdd9Z3qF02AhZXpqjNzlA/FtENxpH28oT7UJf3oYzoWghpoGi5IjSLX3/ik9aRib2YSfsWUfAeY1XXbUUYs4GdH8t/dCqSs0DWCFHfj1AghSkaAFqIN9CEIyiVYSpqypZxWUsqbknYxziXD5ynJySIEXrxuqjP7xEz7Fq4dU/EUlkZQiCisCQe2iMmJqvcmf2HxI9vrTpCtP9rMuj6MFEYiNr1cy0e6IrWtnwbRfM3P44qo1LfeRMb5HAxgBSnNS3zLrh958LE+xTqKO0GYSCC6cdEKplsY839gG1qR/cAS6UEPmxs/UbaLkynP/NXwlnyp0H++J19VQ3a n7z/OZvn ZfKTVkXzxU/WCWs/A8wxihhtxmEVyoCcD619AKre5byFPFnFpIqv5PQD+Md02gGaK+8dV9lS/m5tIRW/MA9lW7y7tLNtmnKhYSo4Nwp8PepWpV2/EXmOerGgFj5QrsCHe2AZX1YQv5h3pvBx/rKbLmdOF0PWq/qwuS6lUYD3T4el9Zt4XKCilxfRvd47Eo6c/zGer1wpkrthXpfZi2EhzVALFnlfmYCx7SLLwoFtv1ytKD1/o4YZ5O9Emx1fevDIz9w1JmZ8mnd/BkNUn68B2bb3Z1BTB08tL4fqqCITmo+LN3iAolExuIgnr7roF1mAP9+cU0B9jXGs4ReWTb1GIQAR0CWIdl+eoInk3JYa9xLZTqnjbc85YzqvwFodnAm28hlRJjoNruX+n/9T4XMLECu96lIZQo+7eAkzL1AOYg0TerYjPwPSDTpRzBYEczsRhQmSDOPP2jJHLXicKmDuylyTLaGR5QxBHcLEeEt+KrPogpfvzB4DDSSS3Mc0AkQ8+dMi/6sC9AwvRBTVM108MZwedDrdZrU55Wc23Qk1SxY+1hMktt8gZpCZQVk07gyDokw5+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 28, 2024 at 09:05:33PM +0000, Mark Brown wrote: > On Mon, Oct 28, 2024 at 08:43:08PM +0000, Lorenzo Stoakes wrote: > > > +/* > > + * We check VMA flag validity early in the mmap() process, however this can > > + * cause issues for arm64 when using MTE, which requires that it be used with > > + * shmem and in this instance and only then is VM_MTE_ALLOWED set permitting > > + * this operation. > > + * > > + * To avoid having to tear down a partially complete mapping we do this ahead of > > + * time. > > + */ > > +static vm_flags_t arch_adjust_flags(struct file *file, vm_flags_t vm_flags) > > +{ > > + if (!IS_ENABLED(CONFIG_ARM64)) > > + return vm_flags; > > + > > + if (shmem_file(file)) > > + return vm_flags | VM_MTE_ALLOWED; > > +} > > This doesn't build: > > mm/mmap.c:1595:1: error: non-void function does not return a value in all control paths [-Werror,-Wreturn-type] > 1595 | } > | ^ Doh that'll teach me for rushing this... > > with that corrected: > > diff --git a/mm/mmap.c b/mm/mmap.c > index d1ab4301c671..cea051c5fef3 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -1587,11 +1587,10 @@ static unsigned long __mmap_region(struct file *file, unsigned long addr, > */ > static vm_flags_t arch_adjust_flags(struct file *file, vm_flags_t vm_flags) > { > - if (!IS_ENABLED(CONFIG_ARM64)) > - return vm_flags; > + if (IS_ENABLED(CONFIG_ARM64) && shmem_file(file)) > + vm_flags |= VM_MTE_ALLOWED; > > - if (shmem_file(file)) > - return vm_flags | VM_MTE_ALLOWED; > + return vm_flags; > } > > unsigned long mmap_region(struct file *file, unsigned long addr, > > the relevant tests all pass for me. > > Tested-by: Mark Brown Thanks! > > I'd have expected arch_adjust_flags() to be something overridden by the > arch headers (probably like arch_calc_vm_prot_bits() and friends), but > if this is juat a short lived fix it's probably not worth the trouble. Yeah this is just a sample solution that I had put together when Linus suggested a sensible alternative which I'll code up... Good to confirm this is definitely the issue thanks for testing!