From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B7D3C54734 for ; Tue, 27 Aug 2024 10:22:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9660C6B0083; Tue, 27 Aug 2024 06:22:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EE586B0085; Tue, 27 Aug 2024 06:22:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 741C16B0088; Tue, 27 Aug 2024 06:22:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 47E286B0083 for ; Tue, 27 Aug 2024 06:22:19 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 02FCCAA385 for ; Tue, 27 Aug 2024 10:22:18 +0000 (UTC) X-FDA: 82497635598.04.25757CC Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf02.hostedemail.com (Postfix) with ESMTP id 47A7780012 for ; Tue, 27 Aug 2024 10:22:17 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="x/+2zK7k"; spf=pass (imf02.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.218.49 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724754093; a=rsa-sha256; cv=none; b=ptMdYbJrgcqJdULkDeweORXtYvFTXA7n3HYtwNcMN5vuHYIjpOuuwVAs3fX8ofSu49j9Iu kdlyIqN5/O+rA/jjQFhd1w3Ux+zd8K6aFNybSsYidgpzUV57MV1n+G9jNW31WVAAhhDZBY p5UFi19k6yjvfzIh+lTwJ+1l7XhT97c= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="x/+2zK7k"; spf=pass (imf02.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.218.49 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724754093; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=POltI72urNamcNLZJ3RWBq/EOcdy8q8cxI88mIuIRS4=; b=1r1kIdarYBtU3Ie7xSUuJfniQhySA/aN6xj1Rv7MvDYS4G9gW4uKiB+BNv9SgNpByVLLym vxoobheA+Kj9MqTLjTcDQofzlQ3mauCKNQCqRihSlML8fmPB5+5GAvilNhV9EyobYimkq6 E6X2IJcXyyMEYsU8Fv9UlezsO9a8Yo0= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a867a564911so630714166b.2 for ; Tue, 27 Aug 2024 03:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724754135; x=1725358935; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=POltI72urNamcNLZJ3RWBq/EOcdy8q8cxI88mIuIRS4=; b=x/+2zK7kIo2cD8c5Q0V/k49iTxSLw8nruOGIAHPpIQyQrMM3apDkMmFwm/ArG9uzT8 75mh9bPMGqWgMeeC4esZQ+qGZHwFOhWG49gs1A83jHUAMSer38Az9dbsbfiE1hHH+s9x qA93g2Q8Pt5t7ybhWLM1WLT1z6yZYHoRDxKli/aXdSI8vKpe5hXcTbc4e3K6uvgvpetz QyBahQDeiql1X8C+qiUTf5VWVlH1B7sRsscz73Ecvy8MK6/9Zz0Lz/gWfai+LT837kEr yrXLwhFIBRGifVTcFNEomwf37PhghbuutFpEn2dSIibo28BnmXEYm+Q6WqCtB3m8H1W/ rJ8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724754136; x=1725358936; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=POltI72urNamcNLZJ3RWBq/EOcdy8q8cxI88mIuIRS4=; b=gNo/tGPDjVJRbgX1pxZ3oufDiDoEN1TcJxTyfdW5Kds+7qOjIvfBTqyBLxlMxX/FOP W31b8YPVzRurjag1sjc9A+GVMcY+Y4f+lxw9nk+RdFYMMz9ie63zVysHHbRxBvVntZQP N0Hovx8yhlcbUbSjmRZE8N1NGlgfqUYqJmYrHlXuIR+xHojlSHzmJalkcHAO0wjukrMj g2/FMz7iEKeDOczYHyqgrXVPLQD6AcadudXIzMsgviqlM5GrvLD9mdJ8alcug/fOWiq9 PBrsaBp8g8wPQ9NskeavYPk0un0RspFdkNfK18xVHVFko0rE+Ald6BAgaM87ywIXatfk asxA== X-Gm-Message-State: AOJu0YxFKZ51zlhojYyWzpaIMYhjHEHJK2Ma+VFaD689eXqpolM62vap bq62Jf2heh5IV/fr7B4Zo8dPlsiete2TWUAOc3mKhfm7UT5biDEy8iePn+zVyBptR6SyOiBHQoj U X-Google-Smtp-Source: AGHT+IEUQnQWe2RRtDS7BSni380YuT8s02CbbGlLzvUS2nPGMW07+LXc5mGOlEyqxYdV+ytgm2bqxg== X-Received: by 2002:a17:907:d58f:b0:a7a:8876:4427 with SMTP id a640c23a62f3a-a86a5199eecmr902412766b.25.1724754135390; Tue, 27 Aug 2024 03:22:15 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a86e549cd4esm91099766b.55.2024.08.27.03.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2024 03:22:15 -0700 (PDT) Date: Tue, 27 Aug 2024 13:22:11 +0300 From: Dan Carpenter To: "Liam R. Howlett" Cc: linux-mm@kvack.org Subject: [bug report] mm: change failure of MAP_FIXED to restoring the gap on failure Message-ID: <14c0c2ff-e414-4e6d-9029-b738febd4922@stanley.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Stat-Signature: 81ybcfecotarjwoznhtedqmk3qzinamy X-Rspamd-Queue-Id: 47A7780012 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724754137-694916 X-HE-Meta: U2FsdGVkX1+wi03v4J5l8wqhiGbA0u7k3AcDJD89ipzOZwjcPbD77ZBNZpOkz1OTpIQtBRnNJJBgS1Y/yaXh+Nwr6V7uFpa+Is7HktuxlsdkJpl7hlUimZk+cDQnSaQcmP3rQLPUIYK/I8bLsfQhdCOwWxOx5VI8jNz9iVtVYv9A1Xz+uXoBHKUnQYYXRlMa84fMQesjILytf2rA9pn//Myqu8WIx9XZSgoSTWADFMGcnhSaazbZoImjBcHqjXkFVR2rO3X+mPkIE9ZLnzXb9DEi5h2l1/x5d7bCW3nN1wSIlIfCC4s3PokrlSuzBbhX3FuRSvtgpHA4EcO5k/RZrIutZugF6EaFGHQZH5MPDZXW3jiq8gNfGuXT5fNr+vX9QYk+owF3cvk15TywCi6BXxknBbQng57a893T78UMCvokRM/B8KCyGnijd4ROM1UN7uA06J06safC8YMFl4+z36IDiyXVhxBWTeP9bChtOE8XO+wXdLelsD7Utu/itenVbILRuiHKvy5Bn1r7o+3qORvfWEy8FlHrEnYdSJ0zX9WJrB3/U56Mt7jdzoqxOh/FAmmF/PoayhwbcfcDPLiIqF189KsN3mJPx4yIKhNx2EttdGc3K2XufnZ37zuAO5aRA5plgrNJVyISsCWvRYoCzLb8qW/M54EybwzLQJ226XbI0fzZXHTCdvUobZX6N4uLpFhp8DyYNFhDgOAFE2Yx7U4pD5E2aqlG/OXSeAb2533iAqCd/NZyZ/E5/+NP1wzDun+xKggGvvA+3CP/dF9ZLzippi5/umCba4FHg64aIMvXP8HTqH82I+UAjFcFaPqwMQLs7L6LPRcKlkdkiZYpQAbS1gGPj2SHtGgVuhCQPjcC+ouMYiO+w7JQlMUBzzeuOE8a1PwgJuqIkdEXNU7ycOGQGGxQGZB+DlzaiMs1LnREFnhNKg8Tts9FgG4hdyClSlCrLOH/ZK26teusKI6 /UvlWz9W 2h6HWVnNmLR8eI+UJlr4jLrAl8PKoX3QLQugiVIdYGG5UiIbCboWDmVu1Nvo3UmuvDQcMJ5lXu4JEUG58ytwaA7fO8M8S5nuxQQ53+LR03sT2xlQFCjzCRZDmalkM+w0UzQcKTp22taPq/rJ+0JAQg5bhhcr7F8smoo518JMa3ngev4XySnOcUCBQpmnV9IvuEThfnRXOdhz84UF6n18ZM1+rNupoCj+kw6lTs6yB+CWR11DsvhnJi5RiN97LXIlMI8eJxtcZJZYuPD8hls8cvN6Bd6BaZamVWY0yS/T07XLcMqlpaWdhLbVMOSvk/hKqrjBw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Liam R. Howlett, Commit 131e4ef350fa ("mm: change failure of MAP_FIXED to restoring the gap on failure") from Aug 22, 2024 (linux-next), leads to the following Smatch static checker warning: mm/vma.h:240 vms_abort_munmap_vmas() error: NULL dereference inside function mm/vma.h 226 static inline void vms_abort_munmap_vmas(struct vma_munmap_struct *vms, 227 struct ma_state *mas_detach) 228 { 229 if (!vms->nr_pages) 230 return; 231 232 if (vms->clear_ptes) 233 return reattach_vmas(mas_detach); 234 235 /* 236 * Aborting cannot just call the vm_ops open() because they are often 237 * not symmetrical and state data has been lost. Resort to the old 238 * failure method of leaving a gap where the MAP_FIXED mapping failed. 239 */ --> 240 if (unlikely(vma_iter_store_gfp(vms->vmi, NULL, GFP_KERNEL))) { ^^^^ Passing a NULL "vma" pointer will lead to a crash. 241 pr_warn_once("%s: (%d) Unable to abort munmap() operation\n", 242 current->comm, current->pid); 243 /* Leaving vmas detached and in-tree may hamper recovery */ 244 reattach_vmas(mas_detach); 245 } else { 246 /* Clean up the insertion of unfortunate the gap */ 247 vms_complete_munmap_vmas(vms, mas_detach); 248 } 249 } regards, dan carpenter