From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5BDDC5321E for ; Mon, 26 Aug 2024 14:50:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E33E6B007B; Mon, 26 Aug 2024 10:50:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4925B6B0082; Mon, 26 Aug 2024 10:50:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30C2F6B0083; Mon, 26 Aug 2024 10:50:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1379C6B007B for ; Mon, 26 Aug 2024 10:50:39 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7EB5241265 for ; Mon, 26 Aug 2024 14:50:38 +0000 (UTC) X-FDA: 82494682956.10.95A8F8A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 2A81EC0003 for ; Mon, 26 Aug 2024 14:50:35 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ETRj+j7C; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724683793; a=rsa-sha256; cv=none; b=QxJFqXuYez1e0af1giXgCmktV9gECnFJDYbGWhZq5TSLOQgKEl4wx86r9XUsTUFSjxk1E0 5us6lpupKjD+JVSzhXafogtdV/prd+ECiAEietAyE0ckxQnZ3xGgSF77YnY3YJe4iQGLF8 o3ZquuArFz2hKvoNS/8X/+QXNtyxmc0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ETRj+j7C; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724683793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kJu5OKETFSNPkbGx71lnyEUQlMvlwYCZlRPepig7SrA=; b=37nb3QmK+Lvirj/0OsRxxOFBPiKuaNN8cy58O8DzXlScbgk+3C21iANacB0wgdydMpY2HW nFF4/AeucZ5cd7K0+s97390tqxVv25tykXxu+0gFpSAIQQao+AWC9cKq5eMp+OpgnJQyjl 0CDJ+qCMeAe74GmEj+EvUZ6HBQ7CLhM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724683835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kJu5OKETFSNPkbGx71lnyEUQlMvlwYCZlRPepig7SrA=; b=ETRj+j7CGbb0u25VuwHUHYfAO1/9uU3pZYvD7FmyN3us/Fl8pjkRdVhdKgfTovxWu3fTsA 7Xxj/WQVXk7+zn73cQ7Xcv2aKXv/KJeLtIWrl5MAVDoAQzG+6rs+jp271+U5hLu7sDlzzN 0Z/yhIDcJ+XYa+ayy7LuH4PMGQy67ic= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-526-mfLVBt-DOLGLfFtF3fl3bA-1; Mon, 26 Aug 2024 10:50:34 -0400 X-MC-Unique: mfLVBt-DOLGLfFtF3fl3bA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3718ce3f6bdso3241254f8f.2 for ; Mon, 26 Aug 2024 07:50:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724683833; x=1725288633; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=kJu5OKETFSNPkbGx71lnyEUQlMvlwYCZlRPepig7SrA=; b=S9ebB0gYv2PbWrxDvjpxX39NIIdflemmd8i6grkOeTeU0lngPvu8zFPc3h6vuuHHCM VqZ3zA8vqPICoMin/4XMEeDssOILZxLAcw/6I8pcaiO4NjL+LFlamXzwWV/MxRcVPArM 7eIrsrn3DHeHMeygEy9ol1onjPz6zGF7EJPGKe+CdpY5s3mUAUmvJxaB6BugMdoh2PET 0RoQ9c6WTGOBkKT0rF5V7l55JFrmeQj4OJtuXAy+E8U53M+THrgid1jK8Y02R+LZ5XF5 O4zzheNEr4R/0zsbtppaWIihxbzGpo46r480f/09lBAZ3tSQTUQBP8w7Rxa94iChuI5u rUzQ== X-Forwarded-Encrypted: i=1; AJvYcCUk2wjTXkaxTeXN4RimDk6ULoYbQaSpIp8lPvIZMilNxSsqnLqFo1ILmEaP3t9MhwVjhzEzkfioDw==@kvack.org X-Gm-Message-State: AOJu0YyMVfIruWJzcn/rbNMU7w/ipP34hYvOO99xZdnaH7md1n0WZZCO +FU0G2htAmL5YX7gETaDLFKy+DUstmZnlPL5SZ0zPN2ALOWnOocFPVtcSjyluZLHpvt9u28wmTq pVdeSHdZoFqYNQku2LGv163zHsZp/MX3l57376Qf8im6wutGg X-Received: by 2002:a5d:67cc:0:b0:371:8283:94c1 with SMTP id ffacd0b85a97d-373117be78bmr8195085f8f.0.1724683832649; Mon, 26 Aug 2024 07:50:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGUPQkkyRhLJ4HUpi0TKNp443iF7a37UZ+SI2n2AqtHbL+xWTxI4tWjGXLa/FmbE6iQRyYx1g== X-Received: by 2002:a5d:67cc:0:b0:371:8283:94c1 with SMTP id ffacd0b85a97d-373117be78bmr8195053f8f.0.1724683831775; Mon, 26 Aug 2024 07:50:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c737:1900:16b0:8dc:77e:31af? (p200300cbc737190016b008dc077e31af.dip0.t-ipconnect.de. [2003:cb:c737:1900:16b0:8dc:77e:31af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-373081ff5b8sm10834612f8f.85.2024.08.26.07.50.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2024 07:50:31 -0700 (PDT) Message-ID: <14bb8bee-1216-4094-ac24-1630e44aa83a@redhat.com> Date: Mon, 26 Aug 2024 16:50:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/5] mm: migrate: add isolate_folio_to_list() To: Kefeng Wang , Andrew Morton Cc: Oscar Salvador , Miaohe Lin , Naoya Horiguchi , linux-mm@kvack.org References: <20240817084941.2375713-1-wangkefeng.wang@huawei.com> <20240817084941.2375713-5-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240817084941.2375713-5-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ijea989dbpydeo8xuejq7o6nospa9yko X-Rspamd-Queue-Id: 2A81EC0003 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724683835-398346 X-HE-Meta: U2FsdGVkX19T5xyVugyZS9NFQpAQQxAJhc+1hLSIOkV/VLzlIgPGbr6/s1lbQC556+6S7W7XR+g7caC+M5Nl/NQThNwEAGFc7zqqHlu7QkA3nZHsDAz6MkZ2ZTcA47Hnc7QuOls0Yb5PJiW8sZRSsZDLHd2Lc6BE7PYuiKjUKTtF8pw8UB0hdDYAlJU2f8EiqFsD/vJaX8ZbDs25rgA3vLM3A/xKNBLjUx7VWnfLkQ52g///F1hcL+1+pL11zYz+uUPeA6hefVto2xpTgAYFItt1kgXGRz8HHIkH1zvQlQzgFdv5SDLbyE5WMUABd6iRIq3SzqS5a/MWzTs16XnUkqevwpa8jmA0F1aiR+3UkOh21ndBhhcHs/3lXxcO1d5wXNbilePH4Y0wjwUyG4CBMYLQYFTZeWy+Sfuoo3jK7rslWsC3X4ZUGztZe+HMKCrR7alLVfr8bdjKDXs0zt59G+zpjn7t48iwixS3fOG1I7V77WhXejZ/Ew//oVmmBvEWeA1X5HzvA2ghQj0aGozigwfSI4yDE6BHgBFQepV2swW3j3TqMPHYlGxH1KaF7UvAzMTRhaBmiB8jmXjKIzvNhTRK3mfmW8pzr3TUUQ15vUhJUpM1Uvy0PL1pDtpozcfxuyTp+wfPF+eAUO3UBk3Wa7rOBBExa7jx6rzVBMHGIPS70KIos2xrS7aWBRJX7/zdhsyI2vVea8jgKibdKGHe1vrWnfQWR3qx+WNUokHA5khmDjEFek21itxAwZxmwfCfED5lL96Ouq0SHFFF6TtGjVAb8sof9WizESYYFG63SsT0NjQE1xqgBphlxCx5Az4z3fgD4PG/MdgYFfjc+zqowf7MrxxdtEiUKENQXGVJin8w7q/9vfovPS7WNeWUuEF0Ox8692lOAJBDmoiKHmhC28nhtxwq4ofLf9IvYRNhHgKaxV4MI/lIEEhLmaDtMvA/ebkYVaUh2tI0n1ajmJD SRnEp2AZ tEM2VYQau12ouoQrunuq2OnoZ/MzzxHQxdZVdFmuFxuy9mD8h9xI+Kdf1SrprB8qzZyIRQ1IwZz16pTId/FN84X4YecZcQt4JqpLahpbS94GEX00AyLs2rkjDHJ9z5AKUHSNpF8piwXLuN+o0PTBrxfIRVwM440TNl5QHWr6Rv9DKrzh5Dn3s36rU11TeU8sB1huNuiRCQ0rtzlAEDDTeOTlQNt6SW9oflzQ5sIVhyyNl2GYrwnvtkgHuovIez54g4pvrGKQDXgMndAodNS3XqJCripaXRdLU+kM4FcfRELdkJ04+5jUqLnr3RRag6WgN2T0wbVNT/Y+MKkWN/Ab1qtN49DmtaDEZaVDK5midLYdhZdGq8WlQfZtLCPvqAvLWMOkZpExziLMAXPeAgL+zEJcdCgmjrNaQhjeFi5yk63+Xb8G6GJFMUmVZQ8XZQNhBV84ISesXGiMn68sP4GBBDBv9r0e4OtYpZe7iYcMBtX7NHZ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > diff --git a/mm/migrate.c b/mm/migrate.c > index dbfa910ec24b..53f8429a8ebe 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -178,6 +178,33 @@ void putback_movable_pages(struct list_head *l) > } > } > > +/* Must be called with an elevated refcount on the non-hugetlb folio */ > +bool isolate_folio_to_list(struct folio *folio, struct list_head *list) > +{ > + bool isolated = false; No need to initialize this to "false". > + > + if (folio_test_hugetlb(folio)) { > + isolated = isolate_hugetlb(folio, list); > + } else { > + bool lru = !__folio_test_movable(folio); > + > + if (lru) > + isolated = folio_isolate_lru(folio); > + else > + isolated = isolate_movable_page(&folio->page, > + ISOLATE_UNEVICTABLE); > + > + if (isolated) { > + list_add(&folio->lru, list); > + if (lru) > + node_stat_add_folio(folio, NR_ISOLATED_ANON + > + folio_is_file_lru(folio)); > + } > + } > + > + return isolated; Revisiting this patch, we should likely do bool isolated, lru; if (folio_test_hugetlb(folio)) return isolate_hugetlb(folio, list); lru = !__folio_test_movable(folio); if (lru) ... if (!isolated) return false; list_add(&folio->lru, list); if (lru) node_stat_add_folio(folio, NR_ISOLATED_ANON + folio_is_file_lru(folio)); return true; to avoid one indentation level and clean up the code flow a bit. > +} > + > static bool try_to_map_unused_to_zeropage(struct page_vma_mapped_walk *pvmw, > struct folio *folio, > unsigned long idx) -- Cheers, David / dhildenb