From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D332C433F5 for ; Mon, 30 May 2022 11:26:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0858A6B0088; Mon, 30 May 2022 07:26:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 037D76B0089; Mon, 30 May 2022 07:26:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3D9B6B008A; Mon, 30 May 2022 07:26:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D4F916B0088 for ; Mon, 30 May 2022 07:26:29 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id B0A6260E38 for ; Mon, 30 May 2022 11:26:29 +0000 (UTC) X-FDA: 79522181298.25.FA60744 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf08.hostedemail.com (Postfix) with ESMTP id D2C30160047 for ; Mon, 30 May 2022 11:26:04 +0000 (UTC) Received: by mail-lj1-f174.google.com with SMTP id v9so11262871lja.12 for ; Mon, 30 May 2022 04:26:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=xFFlfL4fe1ilOdXrhQDtJsKH7Nsk6vFtTN8mntfqwUg=; b=34zCQZXlG6JFBzjyCw0P2LGetND/flm33L/Fc6uf6jHK6/jEfMO96WNnf7hXhsDOas vlwNhLfTkafo3h9lT+WD69MjpNURqriIr07F8QtefHyBUTaEmU8U483Y1ln8oOuRxbpp LR4GsOA+lHlX1CBAj+3X99k3UES9/06Fbi80YUczOu5arE7/vqr02S58TZWW8WtAQnxc YuucM1hIVCx2HLssP7y2ZKkHD0uS5v6R2fTS4ubTc1FG6IRG4hxPb/nYOG7cDQglfeiH mC930GXFgsHBQqKKrjUzfs6TUJacEj78xhRipAbhjT0duobsK209zKxFbdiBs/Dxk7hO dPFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=xFFlfL4fe1ilOdXrhQDtJsKH7Nsk6vFtTN8mntfqwUg=; b=etoUuyA37nn87MvRj/vDts0sKNSgVVvbX4HgokOKCDJjUEJODHSEuq9QS+cnlgT0g+ umxw4UDdvuBaRE3eBv5uDhvZL6/9xwvpXuOLSJuBvzgJp2tOGsDELjr6hHCGDfD09lHW UYOneUrCKBwaHzv0oawcIzaE/PZ/+gUsGcYhzMiJDLxnv1zsRKVcVSmRk/wUUnCEAuj5 xR7Jy/cJR2PUuuVKdu7bOTgXprCCNXZmDCJq+WDtiTv/zha5o+1eQ3w9jG27vkUUvur4 Eco80LTgKkqYujDQ19PwRlnI7bdn2g+wPtYcxpPff8qC4nCOZ4ES+w6ZkqQQrVehNr/0 n04g== X-Gm-Message-State: AOAM533yj1dLdBgvAc7IMENC0ngaJuZWl/RTtGl1oRc3/TQnxga2r/np pBfBd0lGV1p4YmFKkOKZjyQ1cA== X-Google-Smtp-Source: ABdhPJxCJ6sTGconlZ2JSDy56+27tW1S0trFz6oyj8F6Kf0ZuWKb+glnsL7hOcGAu4nGq2JRmyyVxg== X-Received: by 2002:a05:651c:98c:b0:253:cc50:4374 with SMTP id b12-20020a05651c098c00b00253cc504374mr32878860ljq.274.1653909987912; Mon, 30 May 2022 04:26:27 -0700 (PDT) Received: from [192.168.1.65] ([46.188.121.129]) by smtp.gmail.com with ESMTPSA id e28-20020a19501c000000b0047255d21130sm2259269lfb.95.2022.05.30.04.26.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 May 2022 04:26:27 -0700 (PDT) Message-ID: <14a70615-1240-9538-8be9-b2aedcb0fc11@openvz.org> Date: Mon, 30 May 2022 14:26:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 From: Vasily Averin Subject: [PATCH mm v3 5/9] memcg: enable accounting for percpu allocation of struct psi_group_cpu To: Andrew Morton Cc: kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Vlastimil Babka , Michal Hocko , Muchun Song , cgroups@vger.kernel.org References: <06505918-3b8a-0ad5-5951-89ecb510138e@openvz.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D2C30160047 X-Stat-Signature: kxq7xk73bjmhd3q64zfsuk4xkx51eh8c Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=openvz-org.20210112.gappssmtp.com header.s=20210112 header.b=34zCQZXl; dmarc=pass (policy=none) header.from=openvz.org; spf=pass (imf08.hostedemail.com: domain of vvs@openvz.org designates 209.85.208.174 as permitted sender) smtp.mailfrom=vvs@openvz.org X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1653909964-361531 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: struct pci_group_cpu is percpu allocated for each new cgroup and can consume a significant portion of all allocated memory on nodes with a large number of CPUs. Common part of the cgroup creation: Allocs Alloc $1*$2 Sum Allocation number size -------------------------------------------- 16 ~ 352 5632 5632 KERNFS 1 + 4096 4096 9728 (cgroup_mkdir+0xe4) 1 584 584 10312 (radix_tree_node_alloc.constprop.0+0x89) 1 192 192 10504 (__d_alloc+0x29) 2 72 144 10648 (avc_alloc_node+0x27) 2 64 128 10776 (percpu_ref_init+0x6a) 1 64 64 10840 (memcg_list_lru_alloc+0x21a) percpu: 1 + 192 192 192 call_site=psi_cgroup_alloc+0x1e 1 + 96 96 288 call_site=cgroup_rstat_init+0x5f 2 12 24 312 call_site=percpu_ref_init+0x23 1 6 6 318 call_site=__percpu_counter_init+0x22 '+' -- to be accounted, '~' -- partially accounted Signed-off-by: Vasily Averin Acked-by: Shakeel Butt Reviewed-by: Muchun Song Acked-by: Roman Gushchin --- kernel/sched/psi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c index a337f3e35997..f3ec8553283e 100644 --- a/kernel/sched/psi.c +++ b/kernel/sched/psi.c @@ -957,7 +957,8 @@ int psi_cgroup_alloc(struct cgroup *cgroup) if (static_branch_likely(&psi_disabled)) return 0; - cgroup->psi.pcpu = alloc_percpu(struct psi_group_cpu); + cgroup->psi.pcpu = alloc_percpu_gfp(struct psi_group_cpu, + GFP_KERNEL_ACCOUNT); if (!cgroup->psi.pcpu) return -ENOMEM; group_init(&cgroup->psi); -- 2.36.1