From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B944C761A6 for ; Wed, 29 Mar 2023 23:35:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D34A16B0078; Wed, 29 Mar 2023 19:35:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE5336B007B; Wed, 29 Mar 2023 19:35:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B86916B007D; Wed, 29 Mar 2023 19:35:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AB9F46B0078 for ; Wed, 29 Mar 2023 19:35:02 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 87175407FC for ; Wed, 29 Mar 2023 23:35:02 +0000 (UTC) X-FDA: 80623543644.02.F3DD90B Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by imf03.hostedemail.com (Postfix) with ESMTP id 0E8CF2001C for ; Wed, 29 Mar 2023 23:34:59 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=Q40vDSNT; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=BXNDcLcm; spf=pass (imf03.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 68.232.141.245 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680132900; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m8DGghCmSgAemb4svVVGlv+++4fENJzFEd8XBTF9Do4=; b=vjtZoJK6zwZ8Fq2IR6sUd0230QJt+sZF1Gyd939uhP+0ubNepdcQDqzgb+rvdD26RnRGZI woqG3bC00Z3j3+rLa3TGpw10Lddwenz3/LZWIwRe9YGS95KVUXiagwVdIU6N1tZlgGCDDo xk4klzgtgy2r1IjJtiZP4NOPtNNP8AM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=Q40vDSNT; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=BXNDcLcm; spf=pass (imf03.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 68.232.141.245 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680132900; a=rsa-sha256; cv=none; b=3A74AARvZ1LlF20GUJc/fyS2Su/sey9+q4bj2f9mgz0iqvZjvyeyBNs2KHZGHNHO1c6tMD q4rdazCsVPuMR2rzaLAYefshQsHO3QUzQbbfe8gPIzLARSHy/P304eFvO/INIZP5zpK3XL ueeshU0kYPpXOm5w2zpulFdKldAjOaY= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680132900; x=1711668900; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=eeHaifFAhmRPPQjhcQgNdDiqHkPhvUoOQEh9qZdcZBI=; b=Q40vDSNTGIi54F12judAEoCbV5Cpu8JPgsOBSmHmhC2pijeDxgjtZ1NA Jk5X5N2iUO5XXoVdV7BGTyS7DU43uQrh6FRivE4z6MZCYG0RWdV4PUGqK wNXJz6tpaLFdH1uswxOf6YrzJdnY3n9J/rTRHmNcGvw29VXVNmstqFtDU 81LBvCGxbgTdYKX4OddF2n/fwhUgd51NuKsL1i7VxoiW/jS+lENVTMZQQ Ljfo9vEdzQV5sRIjto7vD0ZtVwRzTZpJ7pREJuQcvEOrdCPywctt+WV3l FFenvCRmjW7ufzqpKAJDzZfzIZju+zL5b2lQl1rS1Z36Ojrn73/gIXDPB A==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="338904056" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:34:58 +0800 IronPort-SDR: o/KVcg2KfJm+k+/vgDNesihFhs5hvhyEoXhzDAB7ly4xWheeSprPDzvQcUpkybkcwJv08CTvpW DRRkY26ILbdhl2TDKq2wfTmEchLy+kufT0yqPLpN/zzAz9TN+JhjjKYNlMS08tJQAXTja2MqQd jcXcJlXwPM1UZNxN/zjhe4CTk43mMIMCe7zabKjwliMIQzfld6GCRvz9NhEWCIDADMxd/ohf2x n8QA8zVde68lzux/djuIZMA6KtOTedg7UQySiw3CPJJCx59E5sBl01wEbQaCxpaR0Iglx4MYog P0Y= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:45:26 -0700 IronPort-SDR: r6ipvvam2Hs99HyGu7DMu53hEsWe3Hm5HBwz3/f0EmXkl0PsU6p5hqSWowoisD45/ty6k3ov51 ED0Lj/aTUoLgi9k6snCJ1PYXtfIvenxgOC9rsN9zXyN1WFBAMmElCv7BbO8T6f1tBigYoHs09e b1gHIfgDfKe4e2IS54aqwNB9vdEsb69MvoVbqRIY/6qe2nDkbyR9Ti6O/TKjNOZYJTHRmNxDHR MCyWyBwtbgZ/dUsCIzaSzFDjFQjAkf/nNAQKk/SXEyf2sXpx9IB/NNzPVbGJCBYl7FsYsUDI9D uio= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:34:58 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2w21jB8z1RtVp for ; Wed, 29 Mar 2023 16:34:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680132897; x=1682724898; bh=eeHaifFAhmRPPQjhcQgNdDiqHkPhvUoOQEh 9qZdcZBI=; b=BXNDcLcmPPrVqL0uFQjErIzucxTlO2TIjyuUMny2mRGUWmQis2+ Kp33jWSJF1g147Opo3rTneP3H7gwmNnEY+Up30cZQPxCibvRicdthlRAp7HwfA3s yZ2CR0pSt1DWieL+O+5noiTVyC18th0YJN7NxnEc9WA69UT3Aek5Gf1Ykc8KUD/E fCMhYTIDSrIhJoUmE5A9NvofEQI3CB/096YNkJxWerVVLA5+j1USgnk3t3REY1DB 4txAUQ8raXYpQ2EQFHL2FPvKU/3Tn62ZAbsAG7vjHNq3VUhum4TuE7DV08/TeyBl eQW/1XF2djdTME7GQEAjbOj7c59rU1TGj7Q== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id S14cWmxwXhqH for ; Wed, 29 Mar 2023 16:34:57 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2vy4wThz1RtVm; Wed, 29 Mar 2023 16:34:54 -0700 (PDT) Message-ID: <14a2f204-32a4-5108-560b-98c3dac2abfb@opensource.wdc.com> Date: Thu, 30 Mar 2023 08:34:53 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 11/19] gfs: use __bio_add_page for adding single page to bio Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <51e47d746d16221473851e06f86b5d90a904f41d.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <51e47d746d16221473851e06f86b5d90a904f41d.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0E8CF2001C X-Stat-Signature: yoppsziprqo6a99sotypktta6c5eo6ff X-Rspam-User: X-HE-Tag: 1680132899-734175 X-HE-Meta: U2FsdGVkX182hPCwayWIggYbla80uFn4gmk/0/Yr+VX014WZPUvHLTsIK8+RIo0gs4JVESs/ZdnVbcjlUtE+2TT1bkPnwx3nGUTUaHQus8N8NaCrH9aXDptYdlhIL/gpJ2W+fgKBWaF7gq3W4fW4qZUWJYxu33L5jM0jVp3pjO7mbiApxGccZqMBl1+/zKSZpcYH4uXq/R7/JOlfP07LYCTNKudH4csGbCMB3zVQNrtCtBL55ndvnzoOEHieyZkbVdIjaacJ/pPxWjYancgSQM/CYrz8A3SChE3zk5NQI4c/ijThg0NJT1ofbGSZv5a0B0Nba3pbFsRKHy4WldMPvK6qYraYACWlpMQ4lSsttz1oRRRsEi3gRGBGMs+JJiKP1OG9wxgUrqyfKZ/Udm8AXGbNnkiDoRDBEcS+oRv6tTus0ws1TL7h+l4atS71eMTle1ahiHme5qwc5iY8pRZWTSIbIgTfrh64r57uJPpshhQ8DGuj46g4gT0pzSiKmbURgWj3/dfK1g8ZSKMFODRw0bdzmw1BZ93s75XvikoMxOCvUCBqKPsqq1Yvc9aqqpoGY130r0ZqX5FvCAiw6hR2P/F/yBZ0sKCgVzUi8JiUgHZxEVTZ1Ju2CGv/1TmkIvXw4kI6YbsEjgHd2X/4tcCJkPiCyoTYY15Dn7SLRR+cf03hvlFAzV4CmDpnSVjS91fIyQtrIj2JYK8sVRLGX40zJYBTL/XES8D8NOgd1k32yBpiIKbT3FAdWlZGuPMiRzVHAvMlkldSbIqz3DMP5Xnb/atObEC/b0jYSw89fZl34gbSbHP1nBDbj4mmwm4xYAGIKhYNPggD1dpEpePWeEUY4sweqgGVMzTi50tmkp2kPQ1oLzEmKZmlnkkottYGz1fHXYNClUO7jLfsXx1ORgucMj2tDdnq9e/PWn1v8hZdNyegkA37aphDk8JjP0O8i/Eaby8YIyMqK9pJBhWZVPT 8wVqQB/j b3C3LeZLkN9blviEz2Ccj5zyHr1kR7pd8Z8vj9MOfHM858UBkEjHf8G7mbbUWDLEl/L0meikFMwLAdVBk8jcPlwHK01jjMlehDOJPsthjzqPtpCPA1UmYgh4J6Mw9a13N2m+a6RHspBRONkIybzxy7FQgj95HO+HU5w0MDQBnaXBJN/xepDh3ETZ/WtFAao6JPQgqPnHM2ecSdugc6Dcpv9nvZDbIwHTbnREFSzbE17Twxjxx+oP22UCg5QTS9CR87Qll6rh4c37Vhukobeiz19Q2qnIxLHYvavX6aPIGSCeyqQc4Sqh+2VZSTak5mjRupj1/OgOF7ZX9W1zjMEbiuim7ETRWj98P7lIwPCBFQeUxpn8bPP63+Oew5SkAj1Bw5AYd3NmrarJWAwHH/JuUQsuyInGvyiOWyah1ywdWoVAv55W2bOOw2BuvObC3eM5DwNhEz9U/ssbH+pJXgE2Pz9e7uwxOuROU3hYz9OWX+1qK0pyHdgKls6nip3HRiSA/6s+Bja9Y6bi3lIcD72IaAS9Crui6D0gwSNAGd2qBHQFSlJzJcPkYC5W+P7LaD2MM6Y8luvFpHI787dmXHquelXKxsyQUhPw9dWPVyZv97UrRInsINCLitxGxTuMIDp0Pf9Hgy4/bOM72XfbP7f6z1XWxLMDqtqVa4lasYQgoz5H7uMkF89gNfpQo6w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 02:05, Johannes Thumshirn wrote: > The GFS superblock reading code uses bio_add_page() to add a page to a > newly created bio. bio_add_page() can fail, but the return value is never > checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research