From: Mark Brown <broonie@kernel.org>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] regmap: Add maple tree based register cache
Date: Mon, 3 Apr 2023 19:40:23 +0100 [thread overview]
Message-ID: <149d2462-a190-4480-a501-d645a84ec1bf@sirena.org.uk> (raw)
In-Reply-To: <20230403182644.uylyonu6w6l63oze@revolver>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Mon, Apr 03, 2023 at 02:26:44PM -0400, Liam R. Howlett wrote:
> What you have will work. If you need more optimisations later, then we
> can have another look.
Yeah, what's there tests out OK. In terms of optimisation the baseline
requirement is that we have to be able to pull values out faster than
we'd be able to read them from the device so until we're working with
MMIO devices (which people do use regmap with sometimes but aren't the
common case) we can typically burn a *lot* of CPU cycles and still be
doing just fine. The hot spots are basic read/write of an existing
cached register, then sync and initial load in of cache defaults.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-04-03 18:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 0:10 [PATCH v3 0/2] regmap: Add basic maple tree " Mark Brown
2023-03-30 0:10 ` [PATCH v3 1/2] regmap: Factor out single value register syncing Mark Brown
2023-03-30 0:10 ` [PATCH v3 2/2] regmap: Add maple tree based register cache Mark Brown
2023-04-03 15:45 ` Liam R. Howlett
2023-04-03 16:58 ` Mark Brown
2023-04-03 18:26 ` Liam R. Howlett
2023-04-03 18:40 ` Mark Brown [this message]
2023-04-03 18:05 ` Mark Brown
2023-04-03 13:12 ` [PATCH v3 0/2] regmap: Add basic maple tree " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=149d2462-a190-4480-a501-d645a84ec1bf@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox