From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 937DFC001DC for ; Wed, 19 Jul 2023 08:18:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 327A68D0050; Wed, 19 Jul 2023 04:18:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B0E78D004B; Wed, 19 Jul 2023 04:18:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12C198D0050; Wed, 19 Jul 2023 04:18:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F1A0E8D004B for ; Wed, 19 Jul 2023 04:18:44 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B44621A01DB for ; Wed, 19 Jul 2023 08:18:44 +0000 (UTC) X-FDA: 81027660168.04.BC1B09B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 887AF100015 for ; Wed, 19 Jul 2023 08:18:42 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bNTxbP4X; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689754722; a=rsa-sha256; cv=none; b=ODDoUZA22s8y6SlWeTtWQcqxqi0ZDYnPXX0yN9tnbQb1eC0OFvc7RHSxYm+Z6abEVIUwig OmCftUIrBrdIK2uVg3ZoOL9ASPFD7qvlFhJNHezrE9QGfhEi4BOfXNvpm9fQPrvhez88EC qQQDZemhY+Ih7VRY4KfK4DwqupaJp3s= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bNTxbP4X; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689754722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WssQg9iV0YySJw5yTj4rTXaeROV2bWX6ZiqkxpcpXZY=; b=v8Iw/bwQ/KF6R+3DSbGR7L/XOPeHOYdaf9XAxwoRIvcSfEiU251zksjFplK8Ij6aRlAU6P 6kauFLpk7DJX5mgBMjIjD25u5ozeJgKFx2zrHzhDsP5FZB3O5uWr4A7ivxsjloG/sPYYUr lOalRRujpB08hbTiV1yh4GiENBi+B20= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689754721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WssQg9iV0YySJw5yTj4rTXaeROV2bWX6ZiqkxpcpXZY=; b=bNTxbP4XihI0W+CSLZmm2nMGanTeW7pQiYmAsubMcw5Ri9r5r5gzwJ1nfQNhSfAoBHKOty 3vC6D6wiVHaeaJRIfVAdf7N6aopUF3DHXEqO6/ZanFDB5IkXidD7x+0OhK/6DSxQPIrPt/ PU0bMHpHLSt78js5WqRPBO0WxuS3Xec= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-362-pdYrRk6bNueL4CiMBOYAHA-1; Wed, 19 Jul 2023 04:18:40 -0400 X-MC-Unique: pdYrRk6bNueL4CiMBOYAHA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-315998d6e7fso3660174f8f.3 for ; Wed, 19 Jul 2023 01:18:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689754719; x=1692346719; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WssQg9iV0YySJw5yTj4rTXaeROV2bWX6ZiqkxpcpXZY=; b=d8ckynM05+GsU/ONNPBy13ljpWl9IuJx3rQAqWk5ChNvBMqRE/aw8Z1f/5der/ZTth nWIxKBxaocDIVTBktol0dYqUM9t3izbmat8RgGuHjQxLD14JEDbdmiVGpbgy2v0P8ttV KZ7487boqkXABOyyOAXh85jP7HKMPGL7ICXovb7kYK9/UcDMXbGvT1EU5ja/0IhMNbrg boyI3SAURFrVA6BqF+b8XeLweIqqU16RbwVn1YeRj9p+348sUQZ3W3v6wMYkjempMZw0 OvH69NSmrVCyrlkgmjs6sa7AGUVjs0BbXlBVuBPH0k0chn4NCgUi1xMwV8AnyW0FFWHj U7XQ== X-Gm-Message-State: ABy/qLbw3IgphQwZZD0RcQphT4WkGxkjOHJmv8k3sm/fuARMXORcs8lB XVDxXgcdt1dlyKmmMX6BX2H6e2nSHFoeeBLs2bNUT6G7hB3fxfNXnrPQkfOZdqw8LMZ/GR9qrIY sduu8huEIyZDN+WkcUp4= X-Received: by 2002:a05:6000:196c:b0:313:e9d7:108f with SMTP id da12-20020a056000196c00b00313e9d7108fmr1523229wrb.33.1689754719290; Wed, 19 Jul 2023 01:18:39 -0700 (PDT) X-Google-Smtp-Source: APBJJlG4mVtD6KPNWpna0uoP5njNw9A2AvVcDer/KJcrmJqawn0BMPkdBDdKHedf8gqslDrAWE1usQ== X-Received: by 2002:a05:6000:196c:b0:313:e9d7:108f with SMTP id da12-20020a056000196c00b00313e9d7108fmr1523206wrb.33.1689754718915; Wed, 19 Jul 2023 01:18:38 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:4f00:b030:1632:49f2:63? (p200300cbc74b4f00b030163249f20063.dip0.t-ipconnect.de. [2003:cb:c74b:4f00:b030:1632:49f2:63]) by smtp.gmail.com with ESMTPSA id n6-20020a5d67c6000000b0030e5bd253aasm4592215wrw.39.2023.07.19.01.18.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jul 2023 01:18:38 -0700 (PDT) Message-ID: <149bdc44-eba1-1615-dd12-c3c324426dca@redhat.com> Date: Wed, 19 Jul 2023 10:18:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 2/4] drm/amdkfd: use vma_is_initial_stack() and vma_is_initial_heap() To: Kefeng Wang , Andrew Morton Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, selinux@vger.kernel.org, Felix Kuehling , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter References: <20230719075127.47736-1-wangkefeng.wang@huawei.com> <20230719075127.47736-3-wangkefeng.wang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230719075127.47736-3-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 887AF100015 X-Stat-Signature: tdsdun39fadxazude1uzaaw9ccnhnnzb X-Rspam-User: X-HE-Tag: 1689754722-808895 X-HE-Meta: U2FsdGVkX1/wGPXKUPa3+gsAbqQY9ofVsw9Gv7cIeBfxm7QMuFHu8Tv8AiHQtUmR/DFMfNymnRax9NnSA3Y3/zx/8jjhY1H40WcUdM/SFrHgu0tNM+RCz9d/YSToA8LmUlP5LvDXbSuuGzAdWlH+XPMa3+Zk4TX8RnKW1Bd39+H4xRKtDv2kuMfPNJhQqp2tJtSSy/YOdDlO3qYqjE/BKsBQ8jUo9vLrrye4AopQe1kICF8vxzxqRzxtFLk3K/jRmMFVCz+8HLbezLvE++ytFLlq97erq8cqag0POXKPHKsQW/+IKlZ+EJlU7bYRuJoW/m39OWhm8u1Iq5nsn18qU4S2F/5OR3dXJtStu+6cC6plLtY4G+/W/nE5aujnLAsLl1L9lmUrVn4lYTh/Tp0dtxnD71ww3DaieSsGAe7fHh59mE7P++CeDJRfJj+NZ1Yk6ThaKNpoyL8kdPhbUrIPQWPZySPH8RfXEh3pMT+71VIgu6j+CSnVO6CyAi6ZT6KWFnog3jEjZ3mR4j4thAXUcM2VjBwy7yYUR60MfSHK4nL8uR8dYQ0JUin6KMTXeqTN4DuL4bDOCTlaij+4H/ycA8J3QS8Yg2hn89dTEDb+pF/CtWQVnYX6fCvRqTdrR4i57aq4YdKINRz43mFbi0Zja7TQZ5wE5OduHKyGIhLquHFID9uflNdMjgdc7bBRxaXVPmcUm0EdICBcGP3prlyqlDFdxplAC/yX/Hcr+jDpCe/hAdk6dQWossT9bOdXpRWT66DSeM3L6N3C1WbDf/DbCeJotNMAWaehouCvbapL1GdmWQ1vc7HM++I9Sv3XHFjEXhy639BY4Y27p+Xoa24L1s8bG1OwRPDgXMzuTDzUNJ1DzsJ05F6ra6IwYCK6pNwGGAqy4+12TKv5usxN8HGuPnMAxocJdNjNDFk8WDho7dwhL31l1qY1e94TBisGcK+Q/vqvn43nHef9BLelQSo wHN3eF0V o5R8WoEgU5Tb70U/rpwyXVrEB1a2me2JhW70uNDyodOuevscljGIj4/kN/k6Dklr5Yi0eI0mjFACxu2aFhedMae/nV/k/0hLFm6piZHCA8UXGFZ13ceEFgOtnMqjbLjm3+VNyLqoFvt09A+q2KnMgZyLdDeIv6Kq+hzqeEWXTFyB2NBYc/gqfdjWQwLwwN6FpM3bNl8IjpqtTpniJnirmGT/nw5tqooI6xKyy99Pf+5mhjg16ZoEiuYqqHMnXL6r7EL9dNHgoLV6CapmgOkWZvWrWaPsOT/TYjJS7Tf++pOSKiSINUHhbGD8jNbITmNv2DAN7bWelHWtPEQKwPKLPWtZautTVcWqndqKqaYo+RYLyXGlg8iQcZOjnu5xQ9Mgwjw0HCfRaruCVZ5hpmC/FhidFdZT0Dx1dqogEO/BGzBh34io= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.07.23 09:51, Kefeng Wang wrote: > Use the helpers to simplify code. > > Cc: Felix Kuehling > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: David Airlie > Cc: Daniel Vetter > Signed-off-by: Kefeng Wang > --- > drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c > index 5ff1a5a89d96..0b7bfbd0cb66 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c > @@ -2621,10 +2621,7 @@ svm_range_get_range_boundaries(struct kfd_process *p, int64_t addr, > return -EFAULT; > } > > - *is_heap_stack = (vma->vm_start <= vma->vm_mm->brk && > - vma->vm_end >= vma->vm_mm->start_brk) || > - (vma->vm_start <= vma->vm_mm->start_stack && > - vma->vm_end >= vma->vm_mm->start_stack); > + *is_heap_stack = vma_is_initial_heap(vma) || vma_is_initial_stack(vma); > > start_limit = max(vma->vm_start >> PAGE_SHIFT, > (unsigned long)ALIGN_DOWN(addr, 2UL << 8)); Certainly a valid refactoring, although questionable if such code should care about that. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb