From: Vlastimil Babka <vbabka@suse.cz>
To: Yang Shi <yang.shi@linux.alibaba.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mel Gorman <mgorman@techsingularity.net>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] mm/compaction: fix the comment for try_to_compact_pages
Date: Wed, 17 Jan 2018 09:43:32 +0100 [thread overview]
Message-ID: <149a38e1-a8cc-1029-eb68-5cce1fa39496@suse.cz> (raw)
In-Reply-To: <1515801336-20611-1-git-send-email-yang.shi@linux.alibaba.com>
On 01/13/2018 12:55 AM, Yang Shi wrote:
> "mode" argument is not used by try_to_compact_pages() and sub functions
> anymore, it has been replaced by "prio". Fix the comment to explain the
> use of "prio" argument.
>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Mel Gorman <mgorman@techsingularity.net>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Cc: Michal Hocko <mhocko@suse.com>
> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/compaction.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 10cd757..2c8999d 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1738,7 +1738,7 @@ static enum compact_result compact_zone_order(struct zone *zone, int order,
> * @order: The order of the current allocation
> * @alloc_flags: The allocation flags of the current allocation
> * @ac: The context of current allocation
> - * @mode: The migration mode for async, sync light, or sync migration
> + * @prio: Determines how hard direct compaction should try to succeed
> *
> * This is the main entry point for direct page compaction.
> */
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2018-01-17 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 23:55 Yang Shi
2018-01-17 8:43 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=149a38e1-a8cc-1029-eb68-5cce1fa39496@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox