linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: zhongjiang <zhongjiang@huawei.com>
To: akpm@linux-foundation.org
Cc: mgorman@techsingularity.net, hannes@cmpxchg.org, vbabka@suse.cz,
	kirill.shutemov@linux.intel.com, linux-mm@kvack.org
Subject: [PATCH] mm: fix the memory leak after collapsing the huge page fails
Date: Tue, 9 May 2017 16:12:37 +0800	[thread overview]
Message-ID: <1494317557-49680-1-git-send-email-zhongjiang@huawei.com> (raw)

From: zhong jiang <zhongjiang@huawei.com>

Current, when we prepare a huge page to collapse, due to some
reasons, it can fail to collapse. At the moment, we should
release the preallocate huge page.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
 mm/khugepaged.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/khugepaged.c b/mm/khugepaged.c
index 7cb9c88..3f5749e 100644
--- a/mm/khugepaged.c
+++ b/mm/khugepaged.c
@@ -1080,6 +1080,7 @@ static void collapse_huge_page(struct mm_struct *mm,
 	result = SCAN_SUCCEED;
 out_up_write:
 	up_write(&mm->mmap_sem);
+	put_page(new_page);
 out_nolock:
 	trace_mm_collapse_huge_page(mm, isolated, result);
 	return;
-- 
1.8.3.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2017-05-09  8:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-09  8:12 zhongjiang [this message]
2017-05-09  8:42 ` Vlastimil Babka
2017-05-09  9:25   ` zhong jiang
2017-05-09  9:57   ` zhong jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494317557-49680-1-git-send-email-zhongjiang@huawei.com \
    --to=zhongjiang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox