From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D91B2C388F9 for ; Sat, 7 Nov 2020 13:34:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 25BB4206ED for ; Sat, 7 Nov 2020 13:34:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25BB4206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 23A436B0036; Sat, 7 Nov 2020 08:34:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EA526B005D; Sat, 7 Nov 2020 08:34:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D9AC6B0068; Sat, 7 Nov 2020 08:34:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id D4E2A6B0036 for ; Sat, 7 Nov 2020 08:34:51 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6ED1E181AEF0B for ; Sat, 7 Nov 2020 13:34:51 +0000 (UTC) X-FDA: 77457717582.20.error58_2913f3a272db Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 4C34B180C07A3 for ; Sat, 7 Nov 2020 13:34:51 +0000 (UTC) X-HE-Tag: error58_2913f3a272db X-Filterd-Recvd-Size: 3589 Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Sat, 7 Nov 2020 13:34:49 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R521e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UEWYIIT_1604756073; Received: from IT-FVFX43SYHV2H.lan(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UEWYIIT_1604756073) by smtp.aliyun-inc.com(127.0.0.1); Sat, 07 Nov 2020 21:34:33 +0800 Subject: Re: [PATCH] mm/memcg: update page struct member in comments To: Roman Gushchin Cc: hannes@cmpxchg.org, akpm@linux-foundation.org, Michal Hocko , Vladimir Davydov , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1604662413-5734-1-git-send-email-alex.shi@linux.alibaba.com> <20201106205140.GA2285866@carbon.dhcp.thefacebook.com> From: Alex Shi Message-ID: <1491c150-1cc0-6062-08ea-9c891548a3bc@linux.alibaba.com> Date: Sat, 7 Nov 2020 21:34:15 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201106205140.GA2285866@carbon.dhcp.thefacebook.com> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =D4=DA 2020/11/7 =C9=CF=CE=E74:51, Roman Gushchin =D0=B4=B5=C0: > There are "page and memcg binding" and "page's memcg" used in similar c= ases, > I think it's more obvious than "page_memcg(page) being stable". >=20 > Maybe it helps to address Ira's comment. >=20 > Anyway, please feel free to add: > Acked-by: Roman Gushchin >=20 > Thanks! Thanks a lot! Roman. here is the updated patch with your suggestion and ack. >From 0db2bd8f3833ec5e58c6978f771b05e4902e5156 Mon Sep 17 00:00:00 2001 From: Alex Shi Date: Fri, 6 Nov 2020 19:33:33 +0800 Subject: [PATCH v2] mm/memcg: update page struct member in comments The page->mem_cgroup member is replaced by memcg_data, and add a helper page_memcg() for it. Need to update comments to avoid confusing. Signed-off-by: Alex Shi Acked-by: Roman Gushchin Cc: Johannes Weiner Cc: Michal Hocko Cc: Vladimir Davydov Cc: Andrew Morton Cc: cgroups@vger.kernel.org Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/memcontrol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 7657f16cf992..b6560ab1adc4 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1330,7 +1330,7 @@ void lruvec_memcg_debug(struct lruvec *lruvec, stru= ct page *page) * @page: the page * @pgdat: pgdat of the page * - * This function relies on page->mem_cgroup being stable - see the + * This function relies on page's memcg being stable - see the * access rules in commit_charge(). */ struct lruvec *mem_cgroup_page_lruvec(struct page *page, struct pglist_d= ata *pgdat) @@ -2942,7 +2942,7 @@ static void commit_charge(struct page *page, struct= mem_cgroup *memcg) { VM_BUG_ON_PAGE(page_memcg(page), page); /* - * Any of the following ensures page->mem_cgroup stability: + * Any of the following ensures page's memcg stability: * * - the page lock * - LRU isolation --=20 1.8.3.1